https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38635 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38635 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175251|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 176037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176037&action=edit Bug 38635: Improve place hold confirmation page in the OPAC This patch makes some markup and style changes to the hold confirmation page in the OPAC with the intention of making the interface clearer and less cluttered. The "Place hold on" label for each title's checkbox has been hidden from sighted users and visually grouped with the title information. The checkbox itself is now hidden if only 1 hold is being placed. The title is now a <legend> inside a <fieldset> in order to take advantage of the fact that when fieldset has a "disabled" property the form controls contained within are all disabled. When placing multiple holds at once, unchecking the checkbox next to a title will disable that title's form fields and give it a "disabled" appearance. Some Bootstrap grid markup has been added in order to improve the page's responsive behavior. This update includes some indentation changes, so ignore whitespace when viewing the diff. Unrelated: Incorrect classes have been fixed on a few alerts. Also, CSS related to a long-removed 3rd party service "iDreamBooks" has been removed. To test, apply the patch and rebuild the OPAC CSS. - Log in to the OPAC as a user who can place holds. - Perform a catalog search which will return multiple results. - Next to one of those results, find a title which can be placed on hold and click the "Place hold" link. - On the hold confirmation page you should see the title of your hold and the standard controls. There should be no checkbox next to the title. - Return to the search results page and check the checkbox for at least two items which are available to be place on hold. Click the "Place hold" button in the search results toolbar. - On the hold confirmation page you should see the titles you selected, each with a checkbox next to the title. - Uncheck one of the checkboxes. The details for that title should switch to "disabled" appearance. You should be unable to change the pickup location or click the "Show more options" link. - Re-check the checkbox and click the "Show more options" link to expand more fields. - Uncheck the checkbox again. The expanded section should collapse. - Confirm that single and multiple holds are placed correctly. Test with various additional settings like expiration date or specific item to confirm that these options still work. Sponsored-by: Athens County Public Libraries Signed-off-by: esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38635 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Hi ! Thanks for your patch :) Tested multiple configuration for check/uncheck and worked perfectly I think that we could go a bit deeper, what do you think about following concerns ? 1 - When uncchecking, shouldn't be the label be way more light gray ? 2 - Shouldn't we add a + symbol left to show more and a - left to hide ? A bit like the +/- in the more/less options in advanced search in intranet (could not find example in the OPAC) 3 - I tested on KTD with bibilioitem 384, only title is displayed and not subtitle, I find it a bit weird, since title ends with a colon, shouldn't we put the subtitle also ? -- You are receiving this mail because: You are watching all bug changes.