[Bug 35554] New: Authority search popup is only 700px
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Bug ID: 35554 Summary: Authority search popup is only 700px Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Authority search popup is only 700 pixels width. Most popups use 800 pixels, like the z3950 one :
git grep 'width=' koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/ koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: window.open(link+"&result="+defaultvalue,"valuebuilder",'width=700,height=550,toolbar=false,scrollbars=yes'); koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=[% biblionumber | html %]"+strQuery,"z3950search",'width=800,height=550,location=yes,toolbar=no,scrollbars=yes,resize=yes'); koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt: window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=[% biblionumber | html %]"+strQuery,"z3950search",'width=800,height=500,location=yes,toolbar=no,scrollbars=yes,resize=yes'); koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/cataloging-home.tt: window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=[% biblionumber | html %]"+strQuery,"z3950search",'width=800,height=500,location=yes,toolbar=no,scrollbars=yes,resize=yes');
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 159778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159778&action=edit Bug 35554: Authority search popup width 800px Authority search popup is only 700 pixels width. Most popups use 800 pixels, like the z3950 one. Test plan : 1) Edit a biblio record 2) Click on value builder in a field linked to authority (ie 700) 3) Check popup is 800 pixels wide -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Barbara Petritsch <barbara.petritsch@wienmuseum.at> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.petritsch@wienmuseu | |m.at --- Comment #2 from Barbara Petritsch <barbara.petritsch@wienmuseum.at> --- After Applying the patch the value still doesn't change in the pop up window/Value builder of the field 700 a . Please can I get more instructions or if I did everything right the patch might not work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi Status|Needs Signoff |Failed QA --- Comment #3 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I had the same test results as Barbara in PTFS Europe's sandbox. Pop up doesn't get any wider. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159778|0 |1 is obsolete| | --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 160640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160640&action=edit Bug 35554: Authority search popup width 800px Authority search popup is only 700 pixels width. Most popups use 800 pixels, like the z3950 one. Test plan : 1) Edit a biblio record 2) Click on value builder in a field linked to authority (ie 700) 3) Check popup is 800 pixels wide 4) Same with advanced editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Anneli Österman from comment #3)
I had the same test results as Barbara in PTFS Europe's sandbox. Pop up doesn't get any wider.
Indeed ^^ Code to impact is in JS file, basic and advanced editors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.le-gac@inlibro.com Status|Needs Signoff |Failed QA --- Comment #6 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Failed QA The authority search popup remains at a width of 700 pixels after the patch is applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Phan Tung Bui <phan-tung.bui@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phan-tung.bui@inlibro.com --- Comment #7 from Phan Tung Bui <phan-tung.bui@inlibro.com> --- Failed QA The width of the popup remains 700px -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 161387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161387&action=edit Screenshot with patch Here is how I see it with patch Firefox inspector with mouse on body shows the size at top of the page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Matthias Le Gac from comment #6)
Failed QA
The authority search popup remains at a width of 700 pixels after the patch is applied.
(In reply to Phan Tung Bui from comment #7)
Failed QA The width of the popup remains 700px
Since this is a change in a javascript file, can you try clearing cache after applying patch (Ctrl+F5) ? Can you also try building koha-testing-docker with the patch ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160640|0 |1 is obsolete| | --- Comment #10 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 162295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162295&action=edit Bug 35554: Authority search popup width 800px Authority search popup is only 700 pixels width. Most popups use 800 pixels, like the z3950 one. Test plan : 1) Edit a biblio record 2) Click on value builder in a field linked to authority (ie 700) 3) Check popup is 800 pixels wide 4) Same with advanced editor Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- git grep 'width=1000,height' | wc -l 35 git grep 'width=800,height' | wc -l 15 git grep 'width=700,height' | wc -l 27 I'm not sure about "most popups use 800 pixels", it seems there's no consistency whatsoever. I don't wish to block this bug but could we perhaps consider this opportunity to standardize these pop-up sizes across the code-base? In a different bug perhaps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Sure. Maybe define at least 2 standard sizes for example small/large. Size may depend on the content. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162295|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162317&action=edit Bug 35554: Authority search popup width 800px Authority search popup is only 700 pixels width. Most popups use 800 pixels, like the z3950 one. Test plan : 1) Edit a biblio record 2) Click on value builder in a field linked to authority (ie 700) 3) Check popup is 800 pixels wide 4) Same with advanced editor Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36143 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|matthias.le-gac@inlibro.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.04 released in| | --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.04 |24.05.00,23.11.04,23.05.10 released in| | --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org