[Bug 35672] New: Update and Run SQL button should save changes even if report fails to run
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672 Bug ID: 35672 Summary: Update and Run SQL button should save changes even if report fails to run Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: andrewfh@dubcolib.org QA Contact: testopia@bugs.koha-community.org Depends on: 23824 To recreate: - have a report that works, example "SELECT 1+1" - edit your report to have a SQL error, example "SELECT 1 plus 1" - click Update and Run SQL, get an error message due to SQL error - click to edit report again, confirm none of your changes were saved - re-edit your report to contain the SQL error - click Update, confirm your report saves with an error When using Update and Run, we should save the SQL even if it has an error, just as we do with the old Update button. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 [Bug 23824] Add a 'Save and run' button to reports -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #1 from George Williams (NEKLS) <george@nekls.org> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #2 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- +1 as well -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672 Dave <ddaghita@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddaghita@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672 --- Comment #3 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- This bug continues to cause me to lose work when I mistakenly click "Update and Run" while testing new queries. If my changes have introduced an error, all changes are lost. While I suppose the ultimate answer here is to get so gud at SQL that I don't make mistakes, that may take some time. I'd love to be able to use this button in the meantime. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cj.lynce@westlakelibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- Is this still a bug? I tested on main and 23.05, but I was only able to reproduce this behavior if I used the browser's back button. Even then it only displays the original query, but the updated one with the error is actually saved in the database. I see that a nice thing to know in case you ever wanted to revert to the query with no error, you could click the browser's back button and copy and paste the query and save it again. After using the update and run button and getting an error, if you use the Koha interface the to return to editing the query you will see the edited query: - clicking on the name of the report in the breadcrumbs - selecting edit from the edit dropdown - using the 'return to previous page' link in the error message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org