[Bug 37078] New: Damaged Status not showing in detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Bug ID: 37078 Summary: Damaged Status not showing in detail.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Currently in 24.05 and in master, after setting an item to damaged, this status does not appear in the detail.pl page. The damaged status does show if the item is checked out, it will appear in the patron's checkouts with the damaged status. It also will show when the item is checked in. If changing the item to LOST or Not for Loan, these values do show. It appears to only not show when applying the item to the damaged status. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com Version|unspecified |Main -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 --- Comment #1 from Kelly McElligott <kelly@bywatersolutions.com> --- Oh, also the marking an item 'withdrawn' from the patron's account, the withdrawn status doesn't show the status in the patron's account but does show the withdrawn status from the bibliographic record page This is the opposite of the first comment on this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 holly@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |holly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33568 Component|Circulation |Staff interface Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | CC| |jonathan.druart@gmail.com Keywords| |regression --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Comment 1 would be something else, this is just from bug 33568 using the wrong term to find damaged in the API output it uses to build the holdings table for bib detail. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 168003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168003&action=edit Bug 37078: Damaged status not showing in detail.pl The API returns the fact that an item is damaged in 'damaged_status' but the code that builds the holdings table is looking for 'damaged' so it doesn't find that an item is damaged. Test plan: 1. Administration - Authorized values - DAMAGED row, click Add 2. Give it the Authorized value 2 and the Description Awful 3. On a record with more than one item, like Empress of the blues, edit one item to have Damaged status: Damaged and one to have Damaged status: Awful 4. On the bib detail view, note that the status column shows both as 'Available' 5. Apply patch, refresh 6. Note that now one shows as Damaged and one as Awful (verifying that the value is being read from the AV, not the fallback default which is also 'Damaged') -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168003|0 |1 is obsolete| | --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 168021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168021&action=edit Bug 37078: Damaged status not showing in detail.pl The API returns the fact that an item is damaged in 'damaged_status' but the code that builds the holdings table is looking for 'damaged' so it doesn't find that an item is damaged. Test plan: 1. Administration - Authorized values - DAMAGED row, click Add 2. Give it the Authorized value 2 and the Description Awful 3. On a record with more than one item, like Empress of the blues, edit one item to have Damaged status: Damaged and one to have Damaged status: Awful 4. On the bib detail view, note that the status column shows both as 'Available' 5. Apply patch, refresh 6. Note that now one shows as Damaged and one as Awful (verifying that the value is being read from the AV, not the fallback default which is also 'Damaged') Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Damaged Status not showing |Damaged status not showing |in detail.pl |in record detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Simple solution to fairly bad problem, thanks Phil. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168021|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 168068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168068&action=edit Bug 37078: Damaged status not showing in detail.pl The API returns the fact that an item is damaged in 'damaged_status' but the code that builds the holdings table is looking for 'damaged' so it doesn't find that an item is damaged. Test plan: 1. Administration - Authorized values - DAMAGED row, click Add 2. Give it the Authorized value 2 and the Description Awful 3. On a record with more than one item, like Empress of the blues, edit one item to have Damaged status: Damaged and one to have Damaged status: Awful 4. On the bib detail view, note that the status column shows both as 'Available' 5. Apply patch, refresh 6. Note that now one shows as Damaged and one as Awful (verifying that the value is being read from the AV, not the fallback default which is also 'Damaged') Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 CJ <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cj.lynce@westlakelibrary.or | |g --- Comment #8 from CJ <cj.lynce@westlakelibrary.org> --- Can this be pushed to 24.05? Not showing the correct status is a significant issue for staff who use the holdings information regularly. Thx! --CJ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 --- Comment #9 from CJ <cj.lynce@westlakelibrary.org> --- rather, backported to 24.05 Thx! --CJ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Keywords|rel_24_05_candidate | Version(s)|24.11.00 |24.11.00,24.05.02 released in| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- *** Bug 37372 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 33568 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Dave <ddaghita@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddaghita@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the record release notes| |details page to correctly | |show the damaged status for | |items in the holdings table | |status column, instead of | |showing them as available. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the record |This fixes the record release notes|details page to correctly |details page to correctly |show the damaged status for |show the damaged status for |items in the holdings table |an item in the holdings |status column, instead of |table status column, |showing them as available. |instead of showing it as | |available. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078 Bug 37078 depends on bug 33568, which changed state. Bug 33568 Summary: Use the REST API to display items on the staff biblio detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org