[Bug 4248] New: Cities Town Pull Down Missing Zip
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4248 Summary: Cities Town Pull Down Missing Zip Product: Koha Version: HEAD Platform: PC OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com Estimated Hours: 0.0 Change sponsored?: --- Created an attachment (id=1673) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1673) pull down without zips Many cities have multiple zip codes, but the pull down on the patrons page only shows the city, state - not the zip - so you see duplicates and triplicates and have no idea which is the right one. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4248 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2010-02-23 17:13:42 --- Created an attachment (id=1674) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1674) cities admin with zip -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4248 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|oleonard@myacpl.org |gmcharlt@gmail.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2010-02-23 18:38:06 --- reassigning because I looked into this and it's not a template issue - it's a db function issue - the function only returns city,state - and I don't know how to fix it to return the zip as well. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4248 --- Comment #3 from Garry Collum <gcollum@gmail.com> 2010-02-24 01:12:51 --- Created an attachment (id=1682) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1682) Proposed patch -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4248 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs- | |europe.com --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> 2010-02-24 15:57:52 --- The routine is also adding two blank lines instead of one. Working on a patch which incorporates Garry's fix and also removes the extra empty option and hopefully leaves GetCities a clearer piece of code. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4248 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #1682 is|0 |1 obsolete| | AssignedTo|gmcharlt@gmail.com |colin.campbell@ptfs- | |europe.com Status|NEW |ASSIGNED --- Comment #5 from Colin Campbell <colin.campbell@ptfs-europe.com> 2010-02-24 16:58:02 --- Created an attachment (id=1686) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1686) Proposed Patch Reworked the underlying routine to have a cleaner interface. Hopefully the code is more maintainable now. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4248 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4248 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> 2010-04-30 02:21:51 --- Pushed Colin's patch. Please test and close. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4248 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> 2010-04-30 16:50:02 --- Created an attachment (id=1845) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1845) Follow-up patch with markup corrections - Missing "=" in attribute - TMPL_IF nested in HTML tag, which breaks translation script -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4248 --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> 2010-04-30 21:07:40 --- Pushed Owen's follow-up. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4248 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #9 from Nicole C. Engard <nengard@gmail.com> 2010-05-01 01:16:02 --- looks great -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com