[Bug 15129] New: Koha::object for issuing rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Bug ID: 15129 Summary: Koha::object for issuing rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: j.kylmala@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com We should add a new Koha::Object(s) for issuing rule because it makes the code hopefully in the future more usable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 --- Comment #1 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 44418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44418&action=edit Bug 15129: Add Koha::Object for issuing rules and let smart-rules.pl use it Test plan: 1. Make sure that in koha/admin/smart-rules.pl you can still create new rules and that the new rules have all their values remained after saving the rule (so put to every field something). Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Testing with "All libraries" selected. Test 1: ------- - In dropdown box select a patron category that not yet has a rule e.g. Teacher (T) - Fill in some fields - Click "Save" Result: New row with values for this category, values saved OK Test 2: ------ - Click on "Edit" for a I want to change (at the right) - Fill in and/or change some fields - Save Result for editing category from Test 1: DBIx::Class::Row::update_or_insert(): Duplicate entry '*-T-*' for key 'PRIMARY' at /usr/share/kohaclone/Koha/Object.pm line 109 Same error with other categories, e.g. for Juvenile (J) DBIx::Class::Row::update_or_insert(): Duplicate entry '*-J-*' for key 'PRIMARY' at /usr/share/kohaclone/Koha/Object.pm line 109 Same error while editing "All" DBIx::Class::Row::update_or_insert(): Duplicate entry '*-*-*' for key 'PRIMARY' at /usr/share/kohaclone/Koha/Object.pm line 109 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44418|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 44537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44537&action=edit Bug 15129: Add Koha::Object for issuing rules and let smart-rules.pl use it Test plan: 1. Make sure that in koha/admin/smart-rules.pl you can still create new rules and that the new rules have all their values remained after saving the rule (so put to every field something). 2. Make sure you can edit that rule 3. Make sure you can delete that rule Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44537|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 44540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44540&action=edit Bug 15129: Add Koha::Object for issuing rules and let smart-rules.pl use it Test plan: 1. Make sure that in koha/admin/smart-rules.pl you can still create new rules and that the new rules have all their values remained after saving the rule (so put to every field something). 2. Make sure you can edit that rule 3. Make sure you can delete that rule Sponsored-by: Vaara-kirjastot Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44540|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44579&action=edit [PASSED QA] Bug 15129: Add Koha::Object for issuing rules and let smart-rules.pl use it Test plan: 1. Make sure that in koha/admin/smart-rules.pl you can still create new rules and that the new rules have all their values remained after saving the rule (so put to every field something). 2. Make sure you can edit that rule 3. Make sure you can delete that rule Sponsored-by: Vaara-kirjastot Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to master - Thanks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org