[Bug 12337] New: Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12337 Bug ID: 12337 Summary: Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Each time the "renew all" or "renew or return" buttons are click, the renewal process is triggered. If the patron only has one renewal left, and the button is multi-clicked, the librarian may receive a "renewal failed" message even though the renewal did occur. In addition, this can just unwanted multiple consecutive renewals as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12337 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12337 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12337 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28568&action=edit Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message. Each time the "renew all" or "renew or return" buttons are click, the renewal process is triggered. If the patron only has one renewal left, and the button is multi-clicked, the librarian may receive a "renewal failed" message even though the renewal did occur. In addition, this can just unwanted multiple consecutive renewals as well. Test Plan: 1) Check out an item to a patron that can have 1 renewal 2) Click the "renew all" button multiple times, fast and furiously 3) Note the "renewal failed" messaged 4) Apply this patch 5) Repeat steps 1 and 2 6) Note the item is now renewed without the failure message -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12337 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12337 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28568|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12337 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 28665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28665&action=edit Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message. Each time the "renew all" or "renew or return" buttons are click, the renewal process is triggered. If the patron only has one renewal left, and the button is multi-clicked, the librarian may receive a "renewal failed" message even though the renewal did occur. In addition, this can just unwanted multiple consecutive renewals as well. Test Plan: 1) Check out an item to a patron that can have 1 renewal 2) Click the "renew all" button multiple times, fast and furiously 3) Note the "renewal failed" messaged 4) Apply this patch 5) Repeat steps 1 and 2 6) Note the item is now renewed without the failure message Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12337 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12337 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28665|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28709&action=edit Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message. Each time the "renew all" or "renew or return" buttons are click, the renewal process is triggered. If the patron only has one renewal left, and the button is multi-clicked, the librarian may receive a "renewal failed" message even though the renewal did occur. In addition, this can just unwanted multiple consecutive renewals as well. Test Plan: 1) Check out an item to a patron that can have 1 renewal 2) Click the "renew all" button multiple times, fast and furiously 3) Note the "renewal failed" messaged 4) Apply this patch 5) Repeat steps 1 and 2 6) Note the item is now renewed without the failure message Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12337 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org