[Bug 9107] New: DidYouMeanFromAuthorities syspref obsolete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9107 Bug ID: 9107 Summary: DidYouMeanFromAuthorities syspref obsolete Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: System Administration Assignee: jcamins@cpbibliography.com Reporter: jcamins@cpbibliography.com CC: gmcharlt@gmail.com The DidYouMeanFromAuthorities syspref has been replaced by a Did You Mean? configuration page, but it's still showing up in the Searching sysprefs tab on Master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9107 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9107 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13532&action=edit Bug 9107: Remove the obsolete DidYouMeanFromAuthorities syspref Even though the DidYouMeanFromAuthorities syspref was replaced by a "Did You Mean?" configuration page, the syspref was showing up in the syspref editor on the Searching tab. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9107 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9107 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Is this just master? or 3.10 too? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9107 --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #2)
Is this just master? or 3.10 too?
Both. At the moment master is 3.10 for all practical purposes, since I haven't pushed any 3.12-only patches to git.k-c.org yet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9107 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13532|0 |1 is obsolete| | --- Comment #4 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 13540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13540&action=edit [Signed off] Bug 9107: Remove the obsolete DidYouMeanFromAuthorities syspref Even though the DidYouMeanFromAuthorities syspref was replaced by a "Did You Mean?" configuration page, the syspref was showing up in the syspref editor on the Searching tab. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9107 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melia@bywatersolutions.com --- Comment #5 from Melia Meggs <melia@bywatersolutions.com> --- To test I looked at the searching tab of the sysprefs. Before applying the patch, I could see the DidYouMeanFromAuthorities sys pref. After applying the patch, I can no longer see it. If that's all this patch does, then I think it works! Signing off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9107 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: Remove the entry DidYouMeanFromAuthorities in a syspref description file. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9107 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13543&action=edit Bug 9107: Remove the obsolete DidYouMeanFromAuthorities syspref Even though the DidYouMeanFromAuthorities syspref was replaced by a "Did You Mean?" configuration page, the syspref was showing up in the syspref editor on the Searching tab. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9107 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13544&action=edit Bug 9107 remove the syspref from the database, as well, The syspref has been introduced during 3.9, so only a few libraries should have it but for consistency, it must be removed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9107 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13540|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9107 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |3.10 Severity|blocker |normal --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * tiny patch that just remove useless things It's better to also remove the syspref from the database as well. I've added a follow-up (with the DB version, as I'll pass QA), to remove it Lowering the severity, it's not a BLO at all -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9107 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9107 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9107 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This syspref does not appear in Master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org