[Bug 15923] New: Export records by id list impossible in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Bug ID: 15923 Summary: Export records by id list impossible in export_records.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Trying to use export_records.pl for exporting biblios by biblionumber (through list_id_file option) fails. It exports whole catalogue instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |major --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Trying to export using a biblionumber file from the staff interface only gives me an empty file. Exporting the same records using the 'form bilbio nubmer' and 'to bilbio number' options works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14722 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 [Bug 14722] Refactor the catalogue export tool (command-line tools/export.pl does not work anymore. Use misc/export_catalogue.pl instead) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48429&action=edit Bug 15923: Take the id list file into account when exporting records When exporting records (tools/export.pl or misc/export_records.pl), a file of ids (authid or biblionumber) can be passed to filter the results. Bug 14722 has broken this behavior. Test plan: Export records and specify a list of records to filter the results. Prior to this patch, the record with the id 1 was exported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli@cineca.it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48429|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48430&action=edit Bug 15923: Take the id list file into account when exporting records When exporting records (tools/export.pl or misc/export_records.pl), a file of ids (authid or biblionumber) can be passed to filter the results. Bug 14722 has broken this behavior. Test plan: Export records and specify a list of records to filter the results. Prior to this patch, the record with the id 1 was exported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Thank for quick patch Jonathan. In user interface it works as expected, but from command line I'm still getting all the record - not filtered by id_list_file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Josef, thx for the quick testing. If you discover a problem, please feel free to set the status to 'failed qa'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Thanks Katrin, I'll try to remember it for next time ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- There is probably problem on another place too. Looking to the code: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/export_record... 176 if ( @record_ids and my $id_list_file ) { 177 my @filter_record_ids = <$id_list_file>; redeclaring variable $id_list_file may be the problem? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48439&action=edit Bug 15923: Fix --id_list_file option for misc/export_records.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I just c/p stupidly the line to the misc file, but the option was buggy. It should work fine now; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48430|0 |1 is obsolete| | --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 48444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48444&action=edit Bug 15923: Take the id list file into account when exporting records When exporting records (tools/export.pl or misc/export_records.pl), a file of ids (authid or biblionumber) can be passed to filter the results. Bug 14722 has broken this behavior. Test plan: Export records and specify a list of records to filter the results. Prior to this patch, the record with the id 1 was exported. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48439|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 48445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48445&action=edit Bug 15923: Fix --id_list_file option for misc/export_records.pl Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48444|0 |1 is obsolete| | Attachment #48445|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 48527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48527&action=edit [PASSED QA] Bug 15923: Take the id list file into account when exporting records When exporting records (tools/export.pl or misc/export_records.pl), a file of ids (authid or biblionumber) can be passed to filter the results. Bug 14722 has broken this behavior. Test plan: Export records and specify a list of records to filter the results. Prior to this patch, the record with the id 1 was exported. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 48528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48528&action=edit [PASSED QA] Bug 15923: Fix --id_list_file option for misc/export_records.pl Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #14 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to stable, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #16 from Frédéric Demians <frederic@tamil.fr> --- Can't be backported to 3.20 due to bug 14722 not being backported to 3.20. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org