[Bug 7271] New: Change sort on detail.pl to be by home library instead of holding branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7271 Bug #: 7271 Summary: Change sort on detail.pl to be by home library instead of holding branch Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client AssignedTo: paul.poulain@biblibre.com ReportedBy: wizzyrea@gmail.com QAContact: ian.walls@bywatersolutions.com CC: gmcharlt@gmail.com The fix to bug 6600 changed the default sort order of the items display - it used to order by home branch and now it orders by holding branch, a source of confusion for our libraries. There are a couple of ways to fix this problem - 1. tablesort items and set the default sort 2. change the default ORDER BY in Items.pm I have a patch for 2, but am worried about ramifications of that change. 1 might cause problems for bibs with many items. What do you think, which is better? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7271 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> 2011-11-28 22:39:58 UTC --- Created attachment 6450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6450 Bug 7271 - change sort in items.pm to sort by home library instead of holding branch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7271 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |wizzyrea@gmail.com AssignedTo|paul.poulain@biblibre.com |wizzyrea@gmail.com --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2011-11-28 22:44:02 UTC --- As Ian reports in but 6600 - GetItemsInfo is used in the following scripts: ./C4/XSLT.pm ./C4/Reserves.pm ./reports/reservereport.pl ./labels/label-item-search.pl ./virtualshelves/sendshelf.pl ./catalogue/moredetail.pl ./catalogue/detailprint.pl ./catalogue/detail.pl ./basket/basket.pl ./basket/sendbasket.pl ./serials/routing-preview.pl ./misc/migration_tools/rebuild_zebra.pl ./opac/opac-reserve.pl ./opac/opac-sendbasket.pl ./opac/opac-detail.pl ./opac/opac-ISBDdetail.pl ./opac/opac-sendshelf.pl So it seems reasonable that one should check all of these places during testing - I admit that I have not *yet* made it through this whole list, but I wanted to get the patch out for further review and/or "that's a terrible idea don't do that!" This does fix a micro-regression in that the sorting of items was different/confusing after the patch for bug 6600, and also preserves the functionality of 6600. I am sure that QA will have an opinion on this one. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7271 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Change sort on detail.pl to |Revert getitems default |be by home library instead |sort to homebranch instead |of holding branch |of holding branch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7271 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2011-12-13 18:19:18 UTC --- Isn't this the kind of thing that should be a preference? Some library asked for it to sort the way it does, so changing it on them would probably upset them. Just a thought. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7271 --- Comment #4 from Liz Rea <wizzyrea@gmail.com> 2011-12-13 20:20:50 UTC --- No, actually the sort here isn't intentional - this is a regression. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7271 --- Comment #5 from Liz Rea <wizzyrea@gmail.com> 2011-12-13 20:21:46 UTC --- that is to say - it puts it back the way it was before the patch that changed the sort - the change to the sort was an unintended side effect of another patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7271 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7271 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6450|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 7998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7998&action=edit Bug 7271 - change sort in items.pm to sort by home library instead of holding branch Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7271 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz Severity|enhancement |normal --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Fixes a regression. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7271 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Ian Walls <koha.sekjal@gmail.com> --- JOINS with 'branches' table twice, once for home and once for holding, and elegantly distinguishes the two. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7271 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7271 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7271 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7271 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9264 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org