[Bug 28749] New: All backups on 21.05 behave as if --without-db-name is passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Bug ID: 28749 Summary: All backups on 21.05 behave as if --without-db-name is passed Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: JBoyer@equinoxOLI.org QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Created attachment 123114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123114&action=edit Restore the database name to Koha dumps The line to use the --databases flag with mysqldump by default was accidentally removed from koha-dump when the --schema-only option was added. This makes all backups act as if koha-dump is called with the --without-db-name flag, causing koha-restore to fail to restore the database because it's neither CREATEd or USEd. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Jason Boyer <JBoyer@equinoxOLI.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |JBoyer@equinoxOLI.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Depends on| |26947 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Caused by: commit d406d9016460ec8819d68d5d861627c5b3b5accb Bug 26947: Add schema-only option to koha-dump Is your patch ready for testing, Jason? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 [Bug 26947] kohastructure.sql should be updated for each release -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |unspecified -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 --- Comment #2 from Jason Boyer <JBoyer@equinoxOLI.org> --- It is, I just missed changing the status to say so. Thanks for the reminder. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Jason Boyer <JBoyer@equinoxOLI.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |JBoyer@equinoxOLI.org |ity.org | Summary|All backups on 21.05 behave |All backups behave as if |as if --without-db-name is |--without-db-name is passed |passed | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123254&action=edit Bug 28749: Restore the database name to Koha dumps The line to use the --databases flag with mysqldump by default was accidentally removed from koha-dump when the --schema-only option was added. This makes all backups act as if koha-dump is called with the --without-db-name flag, causing koha-restore to fail to restore the database because it's neither CREATEd or USEd. This patch restores that line To test: 1 - sudo debian/scripts/koha-dump kohadev 2 - zcat /var/spool/koha/kohadev/kohadev-2021-07-28.sql.gz | grep DATABASE 3 - Notice no output 4 - Apply patch 5 - sudo debian/scripts/koha-dump kohadev 6 - zcat /var/spool/koha/kohadev/kohadev-2021-07-28.sql.gz | grep DATABASE 7 - You get the line: CREATE DATABASE /*!32312 IF NOT EXISTS*/ `koha_kohadev` /*!40100 DEFAULT CHARACTER SET latin1 */; Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123114|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Trivial, passing QA Thanks Jason! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Congratulations, Jason, for your first patch pushed! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 --- Comment #7 from Jason Boyer <JBoyer@equinoxOLI.org> --- Woo! Hopefully the next one will be a bit more substantial. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 26947 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org