[Bug 40780] New: Removing rows on advanced search should not lose focus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40780 Bug ID: 40780 Summary: Removing rows on advanced search should not lose focus Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jake.deery@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org When removing search fields on the advanced search page of the OPAC, focus is lost. This shouldn't happen; focus should move to a sane location instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40780 --- Comment #1 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 186309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186309&action=edit Bug 40780: Advsearch ButtonMinus moves focus to next or prev line This patch will cause the ButtonMinus button on each of the advsearch fieldsets to jump the focus to the next or previous line, whichever is available. This is in response to a recent accessibility audit performed by one of our customers. Thanks! TO TEST: a) go to /cgi-bin/koha/opac-search.pl?expanded_options=1 b) click / tab onto the ButtonMinus next to a field, click / press enter c) notice how the focus disappears APPLY PATCH d) repeat steps a-b e) notice how the focus now either goes to the next line (if available) or the previous line (otherwise) SIGN OFF -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40780 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40780 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery@openfifth.co.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40780 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Assignee|oleonard@myacpl.org |jake.deery@openfifth.co.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40780 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186309|0 |1 is obsolete| | --- Comment #2 from Emmanuel Bétemps <e.betemps@gmail.com> --- Created attachment 186399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186399&action=edit Bug 40780: Advsearch ButtonMinus moves focus to next or prev line This patch will cause the ButtonMinus button on each of the advsearch fieldsets to jump the focus to the next or previous line, whichever is available. This is in response to a recent accessibility audit performed by one of our customers. Thanks! TO TEST: a) go to /cgi-bin/koha/opac-search.pl?expanded_options=1 b) click / tab onto the ButtonMinus next to a field, click / press enter c) notice how the focus disappears APPLY PATCH d) repeat steps a-b e) notice how the focus now either goes to the next line (if available) or the previous line (otherwise) SIGN OFF Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40780 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40780 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40780 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186399|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186467&action=edit Bug 40780: Advsearch ButtonMinus moves focus to next or prev line This patch will cause the ButtonMinus button on each of the advsearch fieldsets to jump the focus to the next or previous line, whichever is available. This is in response to a recent accessibility audit performed by one of our customers. Thanks! TO TEST: a) go to /cgi-bin/koha/opac-search.pl?expanded_options=1 b) click / tab onto the ButtonMinus next to a field, click / press enter c) notice how the focus disappears APPLY PATCH d) repeat steps a-b e) notice how the focus now either goes to the next line (if available) or the previous line (otherwise) SIGN OFF Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40780 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40780 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40780 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40780 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40780 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40780 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not easy to apply on 24.11.x, since it is minor I skip -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org