[Bug 16810] New: Fines note not showing on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Bug ID: 16810 Summary: Fines note not showing on checkout Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 52865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52865&action=edit no fines warning This screenshot from an earlier manual : http://manual.koha-community.org/3.22/en/images/circ/patronnotes.png shows the fines note to the right of the checkout box, but I don't see it anymore in master. My patron owes over $10 but I'm not seeing the note. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Appears to be a regression from bug 14497 - the entire block is inside this if: [% IF NoIssuesCharge && fines > NoIssuesCharge %] So you don't get the warning about having any fines unless you have fines over the NoIssuesCharge -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Version|16.05 |master --- Comment #2 from Marc Véron <veron@veron.ch> --- Same issue on master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 53125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53125&action=edit Bug 16810 - Fines note not showing on checkout Fines did not show on patron checkout and detail pages unless amout was greater than syspref NoIssueCharges. This patch fixes the logic in koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc Additionally, it changes links to buttons and makes some small text changes to ease translation. To test: - Apply patch - Display checkout or detail page and verify proper display for a patron who has - no fines (no message) - fines not exceeding syspref NoissueCharges (message) - fines exceeding syspref NoIssueCharges (message) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53125|0 |1 is obsolete| | --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53137&action=edit [SIGNED-OFF]Bug 16810: Fines note not showing on checkout Fines did not show on patron checkout and detail pages unless amout was greater than syspref NoIssueCharges. This patch fixes the logic in koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc Additionally, it changes links to buttons and makes some small text changes to ease translation. To test: - Apply patch - Display checkout or detail page and verify proper display for a patron who has - no fines (no message) - fines not exceeding syspref NoissueCharges (message) - fines exceeding syspref NoIssueCharges (message) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16861 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 [Bug 16861] Translatability: Fix separated "abow" in circulation.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, a fine not exceeding noissuecharge isn't showing for me, but it should. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry... didn't test this right (you should actually apply the patch... right?). But good news is, that this works fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53137|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 53301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53301&action=edit [PASSED QA] Bug 16810: Fines note not showing on checkout Fines did not show on patron checkout and detail pages unless amout was greater than syspref NoIssueCharges. This patch fixes the logic in koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc Additionally, it changes links to buttons and makes some small text changes to ease translation. To test: - Apply patch - Display checkout or detail page and verify proper display for a patron who has - no fines (no message) - fines not exceeding syspref NoissueCharges (message) - fines exceeding syspref NoIssueCharges (message) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212@gmail.com --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 16957 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in 3.22.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com --- Comment #12 from Francois Charbonnier <francois.charbonnier@inlibro.com> --- *** Bug 17442 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org