[Bug 19083] New: 'Show all details' checkbox on basket summary page is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083 Bug ID: 19083 Summary: 'Show all details' checkbox on basket summary page is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org 'Show all details' used to make additional columns appear on the basket summary page. This functionality appears to be broken. To test: - Create a basket in acq - Add some order lines - Test the 'show all detail' link - Verify that the clicking the check box doesn't change anything in the view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah, noticed something: It's not working when the basket is closed and in a basket group. So this should be added to the test plan. Otherwise it appears to work still. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12333 Status|NEW |ASSIGNED CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12333 [Bug 12333] Add floating toolbar to acquisition basket summary page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67874&action=edit Bug 19083: Fix 'show all details' link on closed basket detail 'Show all details' add columns on the basket summary page. This link is broken if the basket is closed. Indeed there is a JS error raised by $('#toolbar').fixFloat(); The toolbar is not displayed if the basket is closed. This is caused by bug 12333, which added the floating toolbar. Test plan: Create 2 baskets with orders Close 1 basket Click on the 'show all details' links and confirm it works as expected Also confirm that the toolbar works correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67874|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 67958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67958&action=edit Bug 19083: Fix 'show all details' link on closed basket detail 'Show all details' add columns on the basket summary page. This link is broken if the basket is closed. Indeed there is a JS error raised by $('#toolbar').fixFloat(); The toolbar is not displayed if the basket is closed. This is caused by bug 12333, which added the floating toolbar. Test plan: Create 2 baskets with orders Close 1 basket Click on the 'show all details' links and confirm it works as expected Also confirm that the toolbar works correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@ptfs-europe.com --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Patch tested with a sandbox, by Jon Knight <J.P.Knight@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67958|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083 --- Comment #5 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 67965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67965&action=edit Bug 19083: Fix 'show all details' link on closed basket detail 'Show all details' add columns on the basket summary page. This link is broken if the basket is closed. Indeed there is a JS error raised by $('#toolbar').fixFloat(); The toolbar is not displayed if the basket is closed. This is caused by bug 12333, which added the floating toolbar. Test plan: Create 2 baskets with orders Close 1 basket Click on the 'show all details' links and confirm it works as expected Also confirm that the toolbar works correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67965|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 68056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68056&action=edit Bug 19083: Fix 'show all details' link on closed basket detail 'Show all details' add columns on the basket summary page. This link is broken if the basket is closed. Indeed there is a JS error raised by $('#toolbar').fixFloat(); The toolbar is not displayed if the basket is closed. This is caused by bug 12333, which added the floating toolbar. Test plan: Create 2 baskets with orders Close 1 basket Click on the 'show all details' links and confirm it works as expected Also confirm that the toolbar works correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19083 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org