[Bug 21181] New: Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Bug ID: 21181 Summary: Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Debatable, but that problem as it arose: 1 - Patron places a hold, sets 'not needed after' to July 1 2 - Hold is put in transit 3 - Time passes, it is now July 2 4 - Cancel expired holds cron does not cancel hold - found='W' 5 - Hold arrives at destination on July 3 6 - Hold is trapped, patron is notified -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77582&action=edit Bug 21181: Make cancel_expired_reserves.pl Cancel all holds not waiting if ExpireReservesMaxPickupDelay not set To test: 0 - Make sure ExpireReservesMaxPickupDelay is set to 'Don't allow' 1 - Place a hold for a patron 2 - Check in at another library to set it in transit 3 - Update expirationdate of hold to be in the past UPDATE reserves SET expirationdate='1999-12-31' 4 - Run cancel_expired_holds.pl 5 - Hold is not canceled 6 - Apply patch 7 - Run again 8 - Hold is cancelled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz Attachment #77582|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81049&action=edit Bug 21181: Make cancel_expired_reserves.pl Cancel all holds not waiting if ExpireReservesMaxPickupDelay not set To test: 0 - Make sure ExpireReservesMaxPickupDelay is set to 'Don't allow' 1 - Place a hold for a patron 2 - Check in at another library to set it in transit 3 - Update expirationdate of hold to be in the past UPDATE reserves SET expirationdate='1999-12-31' 4 - Run cancel_expired_holds.pl 5 - Hold is not canceled 6 - Apply patch 7 - Run again 8 - Hold is cancelled Followed test plan and patch works as described, also passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It seems that you forgot to attach the tests you wrote before this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88583&action=edit Bug 21181: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81049|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88584&action=edit Bug 21181: Make cancel_expired_reserves.pl Cancel all holds not waiting if ExpireReservesMaxPickupDelay not set To test: 0 - Make sure ExpireReservesMaxPickupDelay is set to 'Don't allow' 1 - Place a hold for a patron 2 - Check in at another library to set it in transit 3 - Update expirationdate of hold to be in the past UPDATE reserves SET expirationdate='1999-12-31' 4 - Run cancel_expired_holds.pl 5 - Hold is not canceled 6 - Apply patch 7 - Run again 8 - Hold is cancelled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 --- Comment #6 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 90489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90489&action=edit [SIGNED-OFF] Bug 21181: Unit tests Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 --- Comment #7 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 90490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90490&action=edit [SIGNED-OFF] Bug 21181: Make cancel_expired_reserves.pl Cancel all holds not waiting if ExpireReservesMaxPickupDelay not set To test: 0 - Make sure ExpireReservesMaxPickupDelay is set to 'Don't allow' 1 - Place a hold for a patron 2 - Check in at another library to set it in transit 3 - Update expirationdate of hold to be in the past UPDATE reserves SET expirationdate='1999-12-31' 4 - Run cancel_expired_holds.pl 5 - Hold is not canceled 6 - Apply patch 7 - Run again 8 - Hold is cancelled Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #0)
Debatable, but that problem as it arose:
Should we ask the list then? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88584|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88583|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |In Discussion --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8)
(In reply to Nick Clemens from comment #0)
Debatable, but that problem as it arose:
Should we ask the list then?
Yeah, might be safer way to go. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 (little late for a comment on the list) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- List comments were positive, I also taked with our trainers. They agreed, if a patron has said they don't want a book after a certain date, then they don't want it after that date. In terms of patron experience, they don't know the book is in-transit, so would be a mystery why they sometimes get a notice for a hold they said they didn't want. Back to Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90489|0 |1 is obsolete| | Attachment #90490|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 91313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91313&action=edit Bug 21181: Unit tests Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 91314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91314&action=edit Bug 21181: Make cancel_expired_reserves.pl Cancel all holds not waiting if ExpireReservesMaxPickupDelay not set To test: 0 - Make sure ExpireReservesMaxPickupDelay is set to 'Don't allow' 1 - Place a hold for a patron 2 - Check in at another library to set it in transit 3 - Update expirationdate of hold to be in the past UPDATE reserves SET expirationdate='1999-12-31' 4 - Run cancel_expired_holds.pl 5 - Hold is not canceled 6 - Apply patch 7 - Run again 8 - Hold is cancelled Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.03 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- This is a small behavior change but I think we should avoid backport to stable. This should have a text to go in the release notes no ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch corrects a release notes| |behaviour where an in | |transit hold would not be | |cancelled if even the | |patron specified they did | |not need the hold after a | |certain date. In some cases | |they would receive a notice | |to pickup a hold they no | |longer wanted. | | | |Now these | |holds will be cancelled | |while in transit, and | |should be routed to their | |home location when checked | |in with no notice to the | |patron. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 --- Comment #17 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Fridolin SOMERS from comment #16)
This should have a text to go in the release notes no ?
Thanks a lot Nick ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00,19.05.03 |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org