[Bug 13449] New: Syndetics TOC will not display in some cases
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Bug ID: 13449 Summary: Syndetics TOC will not display in some cases Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org For reasons unknown, the table of contents data from Syndetics will not display if there is no p element, even though within that if for the p element there's a second one for the p element! This is neither good nor necessary. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34358&action=edit Bug 13449 - Syndetics TOC will not display in some cases For reasons unknown, the table of contents data from Syndetics will not display if there is no p element, even though within that if for the p element there's a second one for the p element! This is neither good nor necessary. Test Plan: 1) Enable Syndetics 2) Find a record that should have a Syndetics TOC but doesn't 3) Apply this patch 4) Reload the page 5) Note the Syndetics TOC data now displays -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Julius <julius.fleschner@briarcliff.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julius.fleschner@briarcliff | |.edu --- Comment #2 from Julius <julius.fleschner@briarcliff.edu> --- This patch has been applied and tested on our instance of Koha. Marked as signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34358|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34365&action=edit Bug 13449 - Syndetics TOC will not display in some cases For reasons unknown, the table of contents data from Syndetics will not display if there is no p element, even though within that if for the p element there's a second one for the p element! This is neither good nor necessary. Test Plan: 1) Enable Syndetics 2) Find a record that should have a Syndetics TOC but doesn't 3) Apply this patch 4) Reload the page 5) Note the Syndetics TOC data now displays Signed-off-by: Julius Fleschner <julius.fleschner@briarcliff.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34365|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34386&action=edit [PASSED QA] Bug 13449 - Syndetics TOC will not display in some cases For reasons unknown, the table of contents data from Syndetics will not display if there is no p element, even though within that if for the p element there's a second one for the p element! This is neither good nor necessary. Test Plan: 1) Enable Syndetics 2) Find a record that should have a Syndetics TOC but doesn't 3) Apply this patch 4) Reload the page 5) Note the Syndetics TOC data now displays Signed-off-by: Julius Fleschner <julius.fleschner@briarcliff.edu> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I couldn't test but from reading the code this should not have any negative consequences. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org