[Bug 12847] New: Date comparisons in C4::Members::IssueSlip is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Bug ID: 12847 Summary: Date comparisons in C4::Members::IssueSlip is broken Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In C4/Members.pm: 2379 sub IssueSlip { 2380 my ($branch, $borrowernumber, $quickslip) = @_; 2381 2382 # return unless ( C4::Context->boolean_preference('printcirculationslips') ); 2383 2384 my $now = POSIX::strftime("%Y-%m-%d", localtime); 2385 2386 my $issueslist = GetPendingIssues($borrowernumber); 2387 foreach my $it (@$issueslist){ 2388 if ((substr $it->{'issuedate'}, 0, 10) eq $now || (substr $it->{'lastreneweddate'}, 0, 10) eq $now) { 2389 $it->{'now'} = 1; 2390 } 2391 elsif ((substr $it->{'date_due'}, 0, 10) le $now) { 2392 $it->{'overdue'} = 1; 2393 } 2394 my $dt = dt_from_string( $it->{'date_due'} ); 2395 $it->{'date_due'} = output_pref( $dt );; 2396 } At line 2384, $now is being defined with the format "%Y-%m-%d", however this is being compared against 'issuedate', 'lastrenewdate' and 'date_due'. 'date_due' is formatted '09/04/2014 23:59' The comparison only uses the first 10 characters of 'date_due', so we can ignore the timestamp at the end, but it's trying to compare 'YYYY-MM-DD' against 'MM/YY/DDDD', e.g. 2014-08-28 against 09/04/2014 -- This is a string comparison; so the initial '0' in '09/04/2014' sorts before the '2' in '2014-08-28'... since the date due is less than $now, the 'overdue' flag is set for this item. I believe that all of the dates involved (issuedate, lastreneweddate, and date_due) are Koha::DateUtils objects; as such it should be possible to define $now the same way, and use Koha::DateUtils methods directly for date comparisons, rather than doing string comparisons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Date comparisons in |Date comparisons in |C4::Members::IssueSlip is |C4::Members::IssueSlip are |broken |broken -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #1 from Barton Chittenden <barton@bywatersolutions.com> --- All items checked out by a patron will show between <overdue></overdue> tags in ISSUESLIP. To replicate: go to cgi-bin/koha/tools/letter.pl?op=add_form&module=circulation&code=ISSUESLIP Add the following section <h4>Overdues</h4> <overdue> <p> <<biblio.title>> <br /> Date due: <<issues.date_due>> at <<issues.branchcode>><br /> </p> </overdue> Check out an item. to a sample patron. Print the issue slip for that patron. Even though the item is not overdue, it will show in the 'Overdues' section. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31280&action=edit Bug 12847 - Date comparisons in C4::Members::IssueSlip are broken Test Plan: 1) Ensure you have the default Koha issue slip 2) Check out an item 3) Print the issue slip for that patron 4) Even though the item is not overdue, it will show in the 'Overdues' section 5) Apply this patch 6) Re-print the issue slip 7) The item should no longer be in the overdues section -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31281&action=edit Bug 12847 [Follwup] - Remove code that calculates "overdue" key as C4::Members::GetPendingIssues already creates it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31281|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31286&action=edit Bug 12847 [Followup] - Remove code that calculates "overdue" key as C4::Members::GetPendingIssues already creates it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Impossible to reproduce this bug. Following the test plan, at step 4, I don't have last issue printed in the 'overdue' section. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Frédéric Demians from comment #5)
Impossible to reproduce this bug. Following the test plan, at step 4, I don't have last issue printed in the 'overdue' section.
I think it will depend on the date, also the syspref you have set. eg if you have it dd/mm/yyyy 28/10/2014 > 2014-10-28 .. so i think you need to make sure you have it set to mm/dd/yyyy (american format) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Chris Cormack from comment #6)
28/10/2014 > 2014-10-28 .. so i think you need to make sure you have it set to mm/dd/yyyy (american format)
I already tested switching dateformat do dd/mm/yyyy. It doesn't help. Sorry. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #8 from Barton Chittenden <barton@bywatersolutions.com> --- (In reply to Frédéric Demians from comment #7)
(In reply to Chris Cormack from comment #6)
28/10/2014 > 2014-10-28 .. so i think you need to make sure you have it set to mm/dd/yyyy (american format)
I already tested switching dateformat do dd/mm/yyyy. It doesn't help. Sorry.
Frédéric: did you test dd/mm/yyyy or mm/dd/yyyy? The latter is the one we're having trouble with. Your reply above suggests that you tested the former, but I can't tell if you mis-typed your answer or mis-tested. No big deal either way, I'm just looking for clarification. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Barton Chittenden from comment #8)
Frédéric: did you test dd/mm/yyyy or mm/dd/yyyy? The latter is the one we're having trouble with. Your reply above suggests that you tested the former, but I can't tell if you mis-typed your answer or mis-tested.
No big deal either way, I'm just looking for clarification.
Sorry. I've tried all values for dateformat syspref, and it always works on master. I can't understand how it wouldn't work, indeed. You said: 'date_due' is formatted '09/04/2014 23:59' But this is not what I have. I have yyyy/mm/dd hh:mm, and so the code in master seems valid. There is a mystery... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is this really 3.14, or should it be master? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the other problem blocking this is that people haven't been able to see the issue, could we get a more detailed test plan? Maybe with an example date? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #12 from Barton Chittenden <barton@bywatersolutions.com> --- Created attachment 35969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35969&action=edit Bug 12847 [Follwup] - Remove code that calculates "overdue" key as C4::Members::GetPendingIssues already creates it Signed-off-by: Laurie McKee <lmckee@littleelm.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31286|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Status|Signed Off |ASSIGNED --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #11)
I think the other problem blocking this is that people haven't been able to see the issue, could we get a more detailed test plan? Maybe with an example date?
Could we get an answer? Please add the syspref value + the dates to reproduce the issue. Confirm the issue is still on master. Back to assigned. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #14 from Nick Clemens <nick@quecheelibrary.org> --- Taking a guess at problems I had in bug 13679 I was able to recreate the issue today. Materials needed to be issued prior to today, but due today. I checked out an item as due today (February 19, 2015) , updated the issuedate to set it to 8 days prior (February 11, 2015), then printed a due slip: item showed as overdue Applied patch: Item no longer showed as overdue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31280|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 36048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36048&action=edit [SIGNED OFF] Bug 12847 - Date comparisons in C4::Members::IssueSlip are broken Test Plan: 1) Ensure you have the default Koha issue slip 2) Check out an item 3) Print the issue slip for that patron 4) Even though the item is not overdue, it will show in the 'Overdues' section 5) Apply this patch 6) Re-print the issue slip 7) The item should no longer be in the overdues section Signed-off-by: Nick <Nick@quechelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35969|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 36049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36049&action=edit [SIGNED OFF] Bug 12847 [Follwup] - Remove code that calculates "overdue" key as C4::Members::GetPendingIssues already creates it Signed-off-by: Laurie McKee <lmckee@littleelm.org> Signed-off-by: Nick <Nick@quechelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle (or someone else), Could you add some tests to highlight the problem? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 8813 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Failing QA for missing tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WORKSFORME --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- I can no longer reproduce this issue. It appears to be fixed in master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just got a screenshot proof from a library on 3.18.5.1 - it's still happening. Item is due today, 23:59 Dateformat is set to metric. ISSUSLIP <checkedout> <p> <<biblio.title>> <br /> Signatur: <<items.itemcallnumber>><br/> Barcode: <<items.barcode>><br /> Fällig am: <<issues.date_due>><br /> </p> </checkedout> <br /> <h4>Überfällig</h4> <overdue> <p> <<biblio.title>> <br /> Signatur: <<items.itemcallnumber>><br/> Barcode: <<items.barcode>><br /> Fällig am: <<issues.date_due>><br /> </p> </overdue> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37908&action=edit screenshot of the wrong display note date on top and overdues (Überfällig) due date -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, I am not able to reproduce the issue, and looking at the cait's data: issuedate: '2015-04-15 16:16:14' lastreneweddate: NULL I really don't understand how this code (C4::Members::IssueSlip) 2443 if ((substr $it->{'issuedate'}, 0, 10) eq $now || (substr $it->{'lastreneweddate'}, 0, 10) eq $now) { 2444 $it->{'now'} = 1; 2445 } 2446 elsif ((substr $it->{'date_due'}, 0, 10) le $now) { 2447 $it->{'overdue'} = 1; 2448 } could set overdue :) All what I know is that in 3.18.05.1, GetPendingIssues does some stuff with the date_due using DateTime::Format::DateParse, which has been removed from master. Anyway, the overdue flag is set in GetPendingIssues, why don't you remove all the code around the date manipulations? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Even if we weren't able to figure it out yet, this: 2446 elsif ((substr $it->{'date_due'}, 0, 10) le $now) { 2447 $it->{'overdue'} = 1; ... is wrong, if you think of hourly loans, I think? So we shouldn't keep that alive. I can see that we need the flag now for the Quick slip, but why do we need to mangle with the overdue status here...? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I managed to create a test case: 1) Check out an item today, due date is today 23.59 2) Check out an item yesterday (change issue date in db), due date is today 23:59 ... and the ISSUESLIP is reliably wrong it appears. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #26 from Jonathan Druart <jonathan.druart@biblibre.com> --- So, confirmed on master. make sure you have: item1 => date_due = today, issuedate = yesterday item2 => date_due = today, issuedate = today -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Kyle, would you be ok squashing the patches? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, some questions have been asked, please have a look. Also tests are missing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|kyle@bywatersolutions.com |jonathan.druart@biblibre.co | |m --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- I will try to provide a patch today. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36048|0 |1 is obsolete| | Attachment #36049|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37946&action=edit Bug 12847: Items issued today is considered as overdue The date comparisons in C4::Members::IssueSlip does not work as expected. Is an item is issue yesterday and due today (23:59), it should not be considered as an overdue yet. Test plan: Define a valid issue slip (code ISSUESLIP) Check 2 items out and update the issuedate value for one of them as yesterday (using the mariadb/mysql cli or similar) Print the slip Before this patch the item marked as issued yesterday is considered as overdue. Special cases: - hourly loans - Quick slip is impacted too -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37946|0 |1 is obsolete| | --- Comment #31 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 37992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37992&action=edit [SIGNED OFF] Bug 12847: Items issued today is considered as overdue The date comparisons in C4::Members::IssueSlip does not work as expected. Is an item is issue yesterday and due today (23:59), it should not be considered as an overdue yet. Test plan: Define a valid issue slip (code ISSUESLIP) Check 2 items out and update the issuedate value for one of them as yesterday (using the mariadb/mysql cli or similar) Print the slip Before this patch the item marked as issued yesterday is considered as overdue. Special cases: - hourly loans - Quick slip is impacted too Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37992|0 |1 is obsolete| | --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38020&action=edit [PPASSED QA] Bug 12847: Items issued today is considered as overdue The date comparisons in C4::Members::IssueSlip does not work as expected. Is an item is issue yesterday and due today (23:59), it should not be considered as an overdue yet. Test plan: Define a valid issue slip (code ISSUESLIP) Check 2 items out and update the issuedate value for one of them as yesterday (using the mariadb/mysql cli or similar) Print the slip Before this patch the item marked as issued yesterday is considered as overdue. Special cases: - hourly loans - Quick slip is impacted too Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13601 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #34 from Chris Cormack <chris@bigballofwax.co.nz> --- Doesn't apply to 3.18.x please rebase if it is needed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's needed - library found this in 3.18.5.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #36 from Chris Cormack <chris@bigballofwax.co.nz> --- Right, well you've (collective you) have a few hours to get it in a state to apply on 3.18.x (until Bernardo sends the po files and I do the release that is) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Trying to see if I can fix it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38020|0 |1 is obsolete| | --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38302&action=edit [3.18.x] Bug 12847: Items issued today is considered as overdue The date comparisons in C4::Members::IssueSlip does not work as expected. Is an item is issue yesterday and due today (23:59), it should not be considered as an overdue yet. Test plan: Define a valid issue slip (code ISSUESLIP) Check 2 items out and update the issuedate value for one of them as yesterday (using the mariadb/mysql cli or similar) Print the slip Before this patch the item marked as issued yesterday is considered as overdue. Special cases: - hourly loans - Quick slip is impacted too Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 13601 is not in 3.18.x, so I removed the change connected to that and it still tested ok. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #39 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org