[Bug 21387] New: Receive items from - form should include tax hints the same as the ordering form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Bug ID: 21387 Summary: Receive items from - form should include tax hints the same as the ordering form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org On the 'New order' page in the 'Accounting details' section of the form there are clarifications on which amount (with/without tax) one is expected to enter. These clarifications should be replicated to the 'Accounting details' form on the 'Receive items from: ' page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79212&action=edit Bug 21387: Receive items from - form should include tax hints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Would appreciate you're eye on the UI here Owen :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- We usually use a "hint" class for adding additional information to a form or similar display. To my eye it looks good inline, so <span class="hint"> around the new text. I think it would be better not to abbreviate "inc" and "exc." One problem I saw: In my test system I got this: Retail price: 18.58 Adjusted for , tax exc. I don't know why it isn't displaying the active currency. Also: This will require a rebase on top of Bug 21454, Remove html filter for Price filtered variables. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79212|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79751&action=edit Bug 21387: Receive items from - form should include tax hints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79751|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79753&action=edit Bug 21387: Receive items from - form should include tax hints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the review Owen. I've added the "hint" classes and correct the missing currency.. seems I forgot to commit the corresponding script change.. oops. As for the abbreviation, I was trying to make it as close to the hints on the orderempty form as possible. For consistency would you prefer I change both templates or leave hat to a second bug perhaps? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- I think a separate bug for expanding those abbreviations would be good. Unless there is a difficult space restraint my vote would be to avoid abbreviations whenever we can. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21619 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21619 [Bug 21619] Tax hints should not be abbreviated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, I've created a dependent bug and asked for guidance on the approved wording at bug 21619 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79753|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80930&action=edit Bug 21387: Receive items from - form should include tax hints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs Signoff |Failed QA --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I ran into a problem. Here's what I did: 1) Before starting, my vendor had both "list prices" and "invoice prices" set to "don't include tax". 2) I created an order line. The hints were "tax exc.", which is ok 3) I received an item. The hints were "tax exc.", which is ok 4) I went in my vendor and changed the "list prices" and "invoices princes" and set them to "include tax" 5) I created an order line. The hints, specifically "vendor price", "retail price", "budgeted cost" and "actual cost" were "tax inc.", which is ok 6) I received the same item. The hints, specifically "retail price", "budgeted cost" and "actual cost", were "tax exc." (but the same price was written as when I ordered, tax included). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Any thoughts on the above Jonathan? I'm going to try to replicate this today, if I can it feels like a bug higher up the stack that this patch, but I'm not sure how it was intended to work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Caroline Cyr La Rose from comment #10)
I ran into a problem. Here's what I did:
4) I went in my vendor and changed the "list prices" and "invoices princes" and set them to "include tax"
This step should not be done I would say, once they have been set you should not change these values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- So I should try with another vendor to see the different links? Also, if we're not supposed to change the vendor tax settings, they shouldn't be editable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Caroline Cyr La Rose from comment #13)
So I should try with another vendor to see the different links?
Also, if we're not supposed to change the vendor tax settings, they shouldn't be editable.
Yes I think they should not be editable unless there is no order yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for your comments Jonathan, my gut feeling was the same but as you wrote most of the current tax handling code I thought you'd be best to weight in :). So perhaps a new bug to prevent editing of that setting once an order exists against the vendor... or a way to record which way the setting was set at the time of order.. either way, it feels like a new bug and shouldn't prevent this one moving forward in my opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #16 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I created a new vendor and set the tax parameters to "include tax" for both invoice price and list price. When I order an item from this vendor, hints are ok (tax inc.) But when I receive the same item from this vendor, the tax hints are wrong (tax exc.) Am I understanding what this is supposed to do? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80930|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81639&action=edit Bug 21387: Receive items from - form should include tax hints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch Caroline.. I'd completely missed passing a couple of variables through. Should work as expected now.. you were completely right in your testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 --- Comment #19 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- The hints in ordering and receiving form now match. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81639|0 |1 is obsolete| | --- Comment #20 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 81917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81917&action=edit Bug 21387: Receive items from - form should include tax hints Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81917|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81999&action=edit Bug 21387: Receive items from - form should include tax hints Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #24 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I prefer not to change display in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21929 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929 [Bug 21929] Typo in orderreceive.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22225 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22225 [Bug 22225] Tax hints and prices on orderreceive.pl may not match -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org