[Bug 33837] New: Objects->filter_by_last_update: Does not allow time comparison
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Bug ID: 33837 Summary: Objects->filter_by_last_update: Does not allow time comparison Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 151720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151720&action=edit Bug 33837: Add datetime comparison to filter_by_last_update Test plan: Verify that filter_by_last_update still works as expected by running cleanup_database.pl with --messages DAYS parameter. Look at the oldest messages.message_date (or insert one). Run with -days X where today - X is before that date. Run with -days Y where today - Y is just after it. Note: misc/cronjobs/cleanup_database.pl -confirm -messages -1 -v will remove all messages including one you inserted just now. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 151721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151721&action=edit Bug 33837: Add unit test Test plan: Run t/db_dependent/Koha/Objects.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 151722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151722&action=edit Bug 33837: filter_by_last_update: Add older_than and younger_than Test plan: Run t/db_dependent/Koha/Objects.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 151723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151723&action=edit Bug 33837: Replace days_inclusive by min_days Instead of passing days and days_inclusive, this patch adds min_days as replacement. Since days_inclusive is not widely used, this can be done easily. It removes the confusion whether days_inclusive impacted other parameters or not. Test plan: Run t/db_dependent/Koha/Objects.t Run t/db_dependent/Koha/Old/Checkouts.t Run t/db_dependent/Koha/Patrons.t (verifying the change in the Koha::Patrons module for filtering by expiration date). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33843 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33843 [Bug 33843] Use filter_by_last_update in Koha::Notice::Util -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The datetime switch is weird. I am wondering if we should not switch to always datetime, and adjust the existing occurrence, I've caught only one. Setting HH:MM to 00:00. Would that work? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153778&action=edit Bug 33837: Remove datetime parameter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patch for discussion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Last patch should not do this: diff --git a/Koha/Notice/Util.pm b/Koha/Notice/Util.pm index 4e515d4b5db..903550b893e 100644 --- a/Koha/Notice/Util.pm +++ b/Koha/Notice/Util.pm @@ -122,7 +122,7 @@ sub _get_domain_count { message_transport_type => 'email', status => 'sent', to_address => { 'LIKE', '%'.$domain }, - })->filter_by_last_update({ timestamp_column_name => 'updated_on', from => $start_dt, datetime => 1 })->count; + })->filter_by_last_update({ timestamp_column_name => 'updated_on', from => $start_dt, })->count; } $limits->{$group}->{count} = $sum; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- /usr/share/koha/t/db_dependent/Koha/Old/Checkouts.t (Wstat: 256 Tests: 2 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=2, 7 wallclock secs ( 0.05 usr 0.00 sys + 5.75 cusr 1.14 csys = 6.94 CPU) Result: FAIL /usr/share/koha/t/db_dependent/Koha/Objects.t (Wstat: 256 Tests: 23 Failed: 1) Failed test: 19 Non-zero exit status: 1 Files=1, Tests=23, 19 wallclock secs ( 0.07 usr 0.01 sys + 14.52 cusr 3.00 csys = 17.60 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Without last patch: Running tests (2) * Proving /usr/share/koha/t/db_dependent/Koha/Objects.t OK! * Proving /usr/share/koha/t/db_dependent/Koha/Old/Checkouts.t OK! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #5)
The datetime switch is weird.
The name could be improved? Was struggling with that. I had first something like truncate_to_days. Open for suggestions here. Note that I did this to keep backward compatibility (or 'no behavior change').
I am wondering if we should not switch to always datetime, and adjust the existing occurrence, I've caught only one. Setting HH:MM to 00:00. Would that work?
I would rather do this on a separate report. Change behavior ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153778|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 153778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153778 Bug 33837: Remove datetime parameter Moving this to obsolete for now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Note that there is always a difference between last 3 days meaning TODAY, TODAY-1 and TODAY-2 (and TODAY-3?) or so and last 3*24 hours. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- compare_time => 1 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153898&action=edit Bug 33837: Remove datetime parameter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- New suggestion, tests are passing now. What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153898|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153900&action=edit Bug 33837: Remove datetime parameter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #16)
New suggestion, tests are passing now. What do you think?
Thanks. Having a look now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Kind of distracted by this code construction in the context: try { $count = $patrons->filter_by_last_update( { timestamp_column_name => 'updated_on', from => '1970-12-31' } ) ->count; print 0/0; } catch { ok( $_->isa( 'No exception raised, from and to parameters can take an iso formatted date' ) ); }; The print is from me. We pass a string too to isa. So isa compares the exception with the string and always returns false to ok. And ok raises a warning without description. The description was obviously meant for ok and not for isa. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Funny remember the cardnumber patch? t/db_dependent/Koha/Patrons.t ........ 27/43 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry '123456789' for key 'cardnumber' at /usr/share/koha/Koha/Object.pm line 170 Still have that borrower and it makes Patrons.t fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151720|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153915&action=edit Bug 33837: Add datetime comparison to filter_by_last_update Test plan: Verify that filter_by_last_update still works as expected by running cleanup_database.pl with --messages DAYS parameter. Look at the oldest messages.message_date (or insert one). Run with -days X where today - X is before that date. Run with -days Y where today - Y is just after it. Note: misc/cronjobs/cleanup_database.pl -confirm -messages -1 -v will remove all messages including one you inserted just now. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151721|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153916&action=edit Bug 33837: Add unit test Test plan: Run t/db_dependent/Koha/Objects.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151722|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153917&action=edit Bug 33837: filter_by_last_update: Add older_than and younger_than Test plan: Run t/db_dependent/Koha/Objects.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151723|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153918&action=edit Bug 33837: Replace days_inclusive by min_days Instead of passing days and days_inclusive, this patch adds min_days as replacement. Since days_inclusive is not widely used, this can be done easily. It removes the confusion whether days_inclusive impacted other parameters or not. Test plan: Run t/db_dependent/Koha/Objects.t Run t/db_dependent/Koha/Old/Checkouts.t Run t/db_dependent/Koha/Patrons.t (verifying the change in the Koha::Patrons module for filtering by expiration date). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153900|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153919&action=edit Bug 33837: Remove datetime parameter Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Perltidied one line in cleanup_database.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- t/db_dependent/Koha/Objects.t # Subtest: filter_by_last_update ok 1 - Should raise an exception if no parameter given ok 2 - filter_by_last_update must return a Koha::Objects-based object ok 3 - 3 patrons have been updated before the last 2 days (exclusive) ok 4 - 4 patrons have been updated before the last 2 days (inclusive) ok 5 - 4 patrons have been updated before yesterday (exclusive) ok 6 - 5 patrons have been updated before yesterday (inclusive) ok 7 - 5 patrons have been updated before today (exclusive) ok 8 - 6 patrons have been updated before today (inclusive) ok 9 - 1 patron has been updated "from today" (inclusive) ok 10 - 6 patrons have been updated "to today" (inclusive) ok 11 - 3 patrons have been updated between D-4 and D-2 # Subtest: Parameters older_than, younger_than ok 1 - All updated yesterday ok 2 - Yesterday, truncated from is inclusive ok 3 - Yesterday, not truncated, one hour too late ok 4 - Yesterday - 1h, not truncated, within time frame 1..4 ok 12 - Parameters older_than, younger_than 1..12 ok 19 - filter_by_last_update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- prove t/db_dependent/Koha/Pseudonymization.t All tests successful. Files=1, Tests=3, 4 wallclock secs ( 0.03 usr 0.00 sys + 3.32 cusr 0.37 csys = 3.72 CPU) Result: PASS prove t/db_dependent/Koha/Old/Checkouts.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Old/Checkouts.t .. ok t/db_dependent/Koha/Patrons.t ........ ok All tests successful. Files=2, Tests=45, 61 wallclock secs ( 0.20 usr 0.04 sys + 47.23 cusr 9.25 csys = 56.72 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153920&action=edit Bug 33837: Perl tidy block in Objects.t WARN t/db_dependent/Koha/Objects.t WARN tidiness The file is less tidy than before (bad/messy lines before: 319, now: 320) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153915|0 |1 is obsolete| | Attachment #153916|0 |1 is obsolete| | Attachment #153917|0 |1 is obsolete| | Attachment #153918|0 |1 is obsolete| | Attachment #153919|0 |1 is obsolete| | Attachment #153920|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153947&action=edit Bug 33837: Add datetime comparison to filter_by_last_update Test plan: Verify that filter_by_last_update still works as expected by running cleanup_database.pl with --messages DAYS parameter. Look at the oldest messages.message_date (or insert one). Run with -days X where today - X is before that date. Run with -days Y where today - Y is just after it. Note: misc/cronjobs/cleanup_database.pl -confirm -messages -1 -v will remove all messages including one you inserted just now. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153948&action=edit Bug 33837: Add unit test Test plan: Run t/db_dependent/Koha/Objects.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153949&action=edit Bug 33837: filter_by_last_update: Add older_than and younger_than Test plan: Run t/db_dependent/Koha/Objects.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153950&action=edit Bug 33837: Replace days_inclusive by min_days Instead of passing days and days_inclusive, this patch adds min_days as replacement. Since days_inclusive is not widely used, this can be done easily. It removes the confusion whether days_inclusive impacted other parameters or not. Test plan: Run t/db_dependent/Koha/Objects.t Run t/db_dependent/Koha/Old/Checkouts.t Run t/db_dependent/Koha/Patrons.t (verifying the change in the Koha::Patrons module for filtering by expiration date). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153951&action=edit Bug 33837: Remove datetime parameter Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Perltidied one line in cleanup_database.pl. Bug 33837: Perl tidy block in Objects.t WARN t/db_dependent/Koha/Objects.t WARN tidiness The file is less tidy than before (bad/messy lines before: 319, now: 320) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35041 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35041 [Bug 35041] Fix Jenkins failure on t_db_dependent_Koha_Patron_t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #36 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org