[Bug 11487] New: Untranslatable tooltip "Dates of birth should be entered in the format ..."
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 Bug ID: 11487 Summary: Untranslatable tooltip "Dates of birth should be entered in the format ..." Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr The following text is not picked up by the translation toolchain: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc: content: 'Dates of birth should be entered in the format "[% format %]"', -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 24322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24322&action=edit Bug 11487: Untranslatable tooltip "Dates of birth should be entered in the format ..." Test plan: 1. Test that tooltip still shows 2. We couldn't test the translations so please can someone else test it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |aleishaamohia@hotmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- I really don't know why but this patch does not work. After applying it: ./translate update fr-FR I don't find the string in the po file. Marked as Failed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11488 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- see Owen's comment on bug 11488. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Severity|enhancement |normal --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I suggest: var dob = _("Dates of birth should be entered in this format:")+ " '"+[% format %]+"'"; ...and note that my comment on Bug 11488 about tab indentation is true of this patch as well. Ditto on the translation test step. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 --- Comment #5 from paxed <pasi.kallinen@pttk.fi> --- (In reply to Owen Leonard from comment #4)
I suggest:
var dob = _("Dates of birth should be entered in this format:")+ " '"+[% format %]+"'";
...and note that my comment on Bug 11488 about tab indentation is true of this patch as well.
Ditto on the translation test step.
Please do not advocate hard-coding the placement of placeholders, it makes translation harder. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to paxed from comment #5)
Please do not advocate hard-coding the placement of placeholders, it makes translation harder.
If you would like to convince me, please don't criticize without providing an explanation. Help me understand rather than just telling me I'm wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Since the strings are currently not translatable, Owen's proposition seems to be a good compromise. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- This bug is proving to be quite the instruction for the high school students. Mostly in how not to communicate if you want someone to work on your fix. Thanks Owen and Jonathan for bringing it back. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11487 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED CC| |bgkriegel@gmail.com Resolution|--- |FIXED --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- This problem was fixed in Bug 11753 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org