[Bug 35272] New: Add padding above vendor contracts section
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 Bug ID: 35272 Summary: Add padding above vendor contracts section Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org This is very minor. I noticed that when a vendor has contracts, the space between the contracts section and the other sections disappeared. Here is what it looked like https://koha-community.org/manual/23.05/en/html/_images/vendorpage.png And this is what I currently have: https://snipboard.io/pTKWIA.jpg Notice how there is no more grey section between the ordering information section and the contracts section. To recreate: 1. If needed, create a vendor 1.1. Go to Acquisitions > New vendor 1.2. Fill out the form, including the contacts section 1.3. Click Save 2. Create a contract 2.1. Click New > Contract 2.2. Fill out the form 2.3. Click Save --> Notice there is no space between ordering information and contracts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33798 Version|unspecified |master Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 [Bug 33798] Vendor details - improve consistency of edit forms and display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158594&action=edit Bug 35272: Add padding above vendor contracts section This patch makes minor updates to the CSS and markup of the vendor detail page so that the different page sections have the correct margins. To test, apply the patch and rebuild the staff interface CSS. - In Acquisitions, locate a vendor and add at least one contract if necessary. - View the vendor details page. Each section (Vendor details, Ordering information, Contracts) should have comfortable and consistent margins. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158594|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 158600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158600&action=edit Bug 35272: Add padding above vendor contracts section This patch makes minor updates to the CSS and markup of the vendor detail page so that the different page sections have the correct margins. To test, apply the patch and rebuild the staff interface CSS. - In Acquisitions, locate a vendor and add at least one contract if necessary. - View the vendor details page. Each section (Vendor details, Ordering information, Contracts) should have comfortable and consistent margins. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158600|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158625&action=edit Bug 35272: Add padding above vendor contracts section This patch makes minor updates to the CSS and markup of the vendor detail page so that the different page sections have the correct margins. To test, apply the patch and rebuild the staff interface CSS. - In Acquisitions, locate a vendor and add at least one contract if necessary. - View the vendor details page. Each section (Vendor details, Ordering information, Contracts) should have comfortable and consistent margins. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.06 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |pedro.amorim@ptfs-europe.co | |m Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org