[Bug 35689] New: Add id and classes to each MARC note in OPAC bibliographic details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Bug ID: 35689 Summary: Add id and classes to each MARC note in OPAC bibliographic details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 14156 Same as Bug 14156 but in the OPAC. Add an id and class attributes to each note in the title notes tab. Replacing this HTML: <div id="marcnotes"> <p> Antonio Chavarrias</p> <p>Tristan Ulloa, Unax Ugalde</p> <p>The great virtue in this film is the persistent sense that something pretty bad is on it's way.</p> </div> With this: <div id="marcnotes"> <p id="marcnote-508-1" class="marcnote marcnote-508"> Antonio Chavarrias</p> <p id="marcnote-511-1" class="marcnote marcnote-511">Tristan Ulloa, Unax Ugalde</p> <p id="marcnote-520-1" class="marcnote marcnote-520">The great virtue in this film is the persistent sense that something pretty bad is on it's way.</p> </div> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14156 [Bug 14156] Add id tags to each MARC note in the display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160474&action=edit Bug 35689: Add id and classes to each MARC note in OPAC bibliographic details Building on Bug 14156, this patch updates the OPAC bibliographic detail page's display of MARC notes to add the tag number in both a class (for consistent styling across the same tag number) and id (for unique styling for each repeated tag). To test: - As a quick test for custom CSS, go to Administration -> System preferences and locate the OPACUserCSS preference. - Add this testing CSS: .marcnote { font-size:140%; font-family: serif; } .marcnote-500 { background-color: #66FFCC; } .marcnote-511 { background-color: #99FFFF; } .marcnote-520 { background-color: #CCFF00; } .marcnote-521 { background-color: #CCFFFF; } .marcnote-538 { background-color: #FFCCCC; } .marcnote-546 { background-color: #FFFFCC; } - Locate a record with multiple notes fields. In the sample data, record 46, "Viridiana" is a good example which works well with the above CSS. - On the bibliographic detail page for the record, click the "Descriptions" tab. - Each MARC note should be colored according to the tag it comes from. - Inspect the HTML to confirm that each paragraph also has its own unique ID. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160474|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 160475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160475&action=edit Bug 35689: Add id and classes to each MARC note in OPAC bibliographic details Building on Bug 14156, this patch updates the OPAC bibliographic detail page's display of MARC notes to add the tag number in both a class (for consistent styling across the same tag number) and id (for unique styling for each repeated tag). To test: - As a quick test for custom CSS, go to Administration -> System preferences and locate the OPACUserCSS preference. - Add this testing CSS: .marcnote { font-size:140%; font-family: serif; } .marcnote-500 { background-color: #66FFCC; } .marcnote-511 { background-color: #99FFFF; } .marcnote-520 { background-color: #CCFF00; } .marcnote-521 { background-color: #CCFFFF; } .marcnote-538 { background-color: #FFCCCC; } .marcnote-546 { background-color: #FFFFCC; } - Locate a record with multiple notes fields. In the sample data, record 46, "Viridiana" is a good example which works well with the above CSS. - On the bibliographic detail page for the record, click the "Descriptions" tab. - Each MARC note should be colored according to the tag it comes from. - Inspect the HTML to confirm that each paragraph also has its own unique ID. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160475|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 164843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164843&action=edit Bug 35689: Add id and classes to each MARC note in OPAC bibliographic details Building on Bug 14156, this patch updates the OPAC bibliographic detail page's display of MARC notes to add the tag number in both a class (for consistent styling across the same tag number) and id (for unique styling for each repeated tag). To test: - As a quick test for custom CSS, go to Administration -> System preferences and locate the OPACUserCSS preference. - Add this testing CSS: .marcnote { font-size:140%; font-family: serif; } .marcnote-500 { background-color: #66FFCC; } .marcnote-511 { background-color: #99FFFF; } .marcnote-520 { background-color: #CCFF00; } .marcnote-521 { background-color: #CCFFFF; } .marcnote-538 { background-color: #FFCCCC; } .marcnote-546 { background-color: #FFFFCC; } - Locate a record with multiple notes fields. In the sample data, record 46, "Viridiana" is a good example which works well with the above CSS. - On the bibliographic detail page for the record, click the "Descriptions" tab. - Each MARC note should be colored according to the tag it comes from. - Inspect the HTML to confirm that each paragraph also has its own unique ID. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds id |This enhancement adds id release notes|and class tags to each MARC |and class attributes to |note in the description tab |each MARC note in the |for the OPAC bibliographic |description tab for the |detail page. |OPAC bibliographic detail | |page. |It adds a | |unique id for each note |It adds a unique id |(for unique styling of each |for each note (for unique |repeated tag), and a |styling of each repeated |general and unique class |tag), and a general and |for each tag (for |unique class for each tag |consistent styling across |(for consistent styling |the same tag number). An |across the same tag |example of the HTML output: |number). An example of the | |HTML output: |``` |``` |<p id="marcnote-500-2" |<p |class="marcnote |id="marcnote-500-2" |marcnote-500">...</p> |class="marcnote |``` |marcnote-500">...</p> |Styles can be defined for |``` |notes and individual tags |Styles can be defined for |in the `OPACUserCSS` system |notes and individual tags |preference - see the test |in the `OPACUserCSS` system |plan for an example. |preference - see the test | |plan for an example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.06 released in| | --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Nice small enhancement, I backport Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org