[Bug 12163] New: Adding a new quote fails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12163 Bug ID: 12163 Summary: Adding a new quote fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: robin@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Adding a new quote doesn't work right, as there is an error in the javascript to re-draw the table row. Everything actually works, but it appears to the user as though nothing is happening. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12163 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 27792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27792&action=edit Bug 12163 - fix adding new quotes Something changed somewhere (maybe a new jQuery or datatables version) and the javascript that redrew the table row after a new quote was saved stopped working. This fixes the call to the datatables function so that it matches the API. To test: * Go and add a quote. * Note that when you press enter after finishing the quote, the line stops being an editor, and becomes just a display, like it should. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12163 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9048 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12163 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12163 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |robin@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12163 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12163 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27792|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 27819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27819&action=edit Bug 12163 - fix adding new quotes Something changed somewhere (maybe a new jQuery or datatables version) and the javascript that redrew the table row after a new quote was saved stopped working. This fixes the call to the datatables function so that it matches the API. To test: * Go and add a quote. * Note that when you press enter after finishing the quote, the line stops being an editor, and becomes just a display, like it should. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12163 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |gmcharlt@gmail.com --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Taking the liberty of pushing this to master because of the regression. Thanks, Robin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12163 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org