http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11350 Bug ID: 11350 Summary: Holds offered to patrons who are not allowed to put the item on hold Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: p.thrasher@dover.nh.gov QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Occurs in 3.10 and current master If there are two items on a bib record with different item types, then a copy that cannot be put on hold by a particular patron will be offered to that patron when the copy is checked in. There are two scenarios: First, if some items can only be put on hold by the home library (set in the Holds policy by item type at the bottom of the circ rules), then if a patron from a different branch puts on a bib level hold it and the restricted copy is checked in, it is offered through the popup to the patron from the different branch. Second, if some patron types are allowed to put holds on an item type and others are not, then when the restricted copy is checked in it is offered to the patron who is not allowed to put a hold on it. It's a little clearer in the test plan... Scenario One Create branches East West Create item types Book Restricted Set Circ rules (Holds policy by item type at the bottom) Add All-All-All rule for all libraries (Set AllowOnShelfHolds in System Preferences/Circulation/Holds to Allow) For East branch for Restricted item type: From home library for West branch for Restricted item type: From home library Create patrons East Patron (branch: East, patron type: Normal) West Patron (Branch: West, patron type: Normal) AnotherEast Patron (branch: East, patron type: Normal) Add a bib record (Koha Item Type Book) with two items item1 (homebranch: East, item type: Book) item2 (homebranch: East, item type: Restricted) Verify that item2 can be put on item specific hold (but don't actually put it on hold) for East Patron Verify that item2 cannot be put on item specific hold for West Patron Log into Staff client at EastBranch Check out item1 to East Patron Check out item2 to AnotherEast Patron Put a bib level hold on the title for West Patron Check in item2 Incorrect behavior: a popup offering the hold to West patron Correct behavior: No popup, item2 can go back on the shelf Scenario Two Create one branch East Create item types Book Restricted Create patron types Normal Special Set Circ rules for East branch Add All-All-All rule for all libraries (Set AllowOnShelfHolds in System Preferences/Circulation/Holds to Allow) Book: All patron types can put 5 holds Restricted: Normal patron type can put 0 holds Special Patron Type can put 5 holds Create patrons East Patron (branch: East, patron type: Special) AnotherEast Patron (branch: East, patron type: Normal) ThirdEast Patron (branch: East, patron type: Normal) Add a bib record with two items item1 (homebranch: East, item type: Book) item2 (homebranch: East, item type: Restricted) Verify that item2 can be put on item specific hold (but don't actually put it on hold) for East Patron Verify that item2 cannot be put on item specific hold for AnotherEast Patron Log into Staff client at East branch Check out item1 to East Patron Check out item2 to AnotherEast Patron Put a bib level hold on the title for ThirdEast Patron Check in item2 Incorrect behavior: a popup offering the hold to ThirdEast patron Correct behavior: No popup, item2 can go back on the shelf Koha figures out properly if an item can be put on hold, we need to use that same logic during checkin when determining who to offer the hold to. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.