http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8811 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7993 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> ---

From IRC:

[10:29] <oleonard> nengard: The link doesn't appear because [% id %] is not present in the template, and the button doesn't work because [% id %] isn't present in the template [10:30] <oleonard> the edit button won't work either for the same reason -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8811 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12475&action=edit Bug 8811 - can't run report after saving The fix for Bug 7993 removed some lines from guided_reports.pl which passed a new report's name and id to the template after saving. For some reason this was removed, making it impossible to run or edit a new report immediately after saving. This patch adds back that part of the script which passes those variables to the template. Before this patch, after adding a new SQL report you would not see a "run this report" link. The "run this report" and "edit" buttons in the toolbar would not work. After applying the patch these should work. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8811 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12475|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 12476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12476&action=edit [SIGNED-OFF] Bug 8811 - can't run report after saving The fix for Bug 7993 removed some lines from guided_reports.pl which passed a new report's name and id to the template after saving. For some reason this was removed, making it impossible to run or edit a new report immediately after saving. This patch adds back that part of the script which passes those variables to the template. Before this patch, after adding a new SQL report you would not see a "run this report" link. The "run this report" and "edit" buttons in the toolbar would not work. After applying the patch these should work. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested creating reports and was able to run them after saving. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8811 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #4)

Created attachment 12476 [details] [SIGNED-OFF] Bug 8811 - can't run report after saving

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested creating reports and was able to run them after saving.

works well, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 6c18204) * d42ef70 Bug 8811 - can't run report after saving reports/guided_reports.pl * reports/guided_reports.pl OK -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8811 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12476|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8811 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8811 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris@bigballofwax.co.nz Resolution|--- |FIXED --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.