[Bug 32382] New: Fund input misaligned on invoice summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 Bug ID: 32382 Summary: Fund input misaligned on invoice summary page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 30952 When you 'finish receiving' you'll see information about your invoice on top. The fund pull down there is misaligned. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 144387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144387&action=edit Bug 32382: Fix alignment on invoice summary page To test: 1. Apply patch 2. Have some funds from budgets that are both active and inactive 3. Receive a basket and click 'Finish receiving' to get to the invoice page 4. Look at the Fund/Show inactive line and make sure it is aligned right 5. With some inactive funds click 'Show inactive' and make sure they appear in this dropdown 6. Click 'Add an adjustment'. Make sure the Fund/Show inactive line looks correct there as well/ 7. Make an adjustment and click 'Update adjustments' make sure the line also looks right in the table that appears. 8. Inside that table make sure you can click the 'Show inactive' checkbox and the inactive budgets appears. Note: Some of the HTML was ouside of the HTML body, so I moved it into the HTML body so it will be valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | CC| |lucas@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Maybe this is for another bug but we build an HTML element called 'all_fund_dropdown'. This is never actually shown, we just use the inner HTML to build all the other '.fund_dropdown' dropdowns on the page. Would it not be better to handle that all with JS? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |andrewfh@dubcolib.org --- Comment #3 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Alignment looks good. On both the Shipping fund and the Adjustment fund, after I've checked the Show Inactive box once, inactive funds show in the dropdown forever, even after I uncheck the box. I've confirmed this doesn't happen without your patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 144727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144727&action=edit Bug 32382: (follow-up) Fix selector -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #3)
Alignment looks good.
On both the Shipping fund and the Adjustment fund, after I've checked the Show Inactive box once, inactive funds show in the dropdown forever, even after I uncheck the box. I've confirmed this doesn't happen without your patches.
Nice catch, I provided a follow up that should fix that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144387|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 144853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144853&action=edit Bug 32382: Fix alignment on invoice summary page To test: 1. Apply patch 2. Have some funds from budgets that are both active and inactive 3. Receive a basket and click 'Finish receiving' to get to the invoice page 4. Look at the Fund/Show inactive line and make sure it is aligned right 5. With some inactive funds click 'Show inactive' and make sure they appear in this dropdown 6. Click 'Add an adjustment'. Make sure the Fund/Show inactive line looks correct there as well/ 7. Make an adjustment and click 'Update adjustments' make sure the line also looks right in the table that appears. 8. Inside that table make sure you can click the 'Show inactive' checkbox and the inactive budgets appears. Note: Some of the HTML was ouside of the HTML body, so I moved it into the HTML body so it will be valid. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144727|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 144854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144854&action=edit Bug 32382: (follow-up) Fix selector Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a great bug fix. For the future, I think we should reuse the new logic from the 'receive' form where we have the sub-headings for the budgets and the 'keep current' feature for a fund you don't have access to. I've filed that separately: Bug 32760 - Reuse new display of funds list from bug 20212 for shipping cost fund list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144853|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145835&action=edit Bug 32382: Fix alignment on invoice summary page To test: 1. Apply patch 2. Have some funds from budgets that are both active and inactive 3. Receive a basket and click 'Finish receiving' to get to the invoice page 4. Look at the Fund/Show inactive line and make sure it is aligned right 5. With some inactive funds click 'Show inactive' and make sure they appear in this dropdown 6. Click 'Add an adjustment'. Make sure the Fund/Show inactive line looks correct there as well/ 7. Make an adjustment and click 'Update adjustments' make sure the line also looks right in the table that appears. 8. Inside that table make sure you can click the 'Show inactive' checkbox and the inactive budgets appears. Note: Some of the HTML was ouside of the HTML body, so I moved it into the HTML body so it will be valid. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144854|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145836&action=edit Bug 32382: (follow-up) Fix selector Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 --- Comment #12 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 Bug 32382 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org