[Bug 25728] New: Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Bug ID: 25728 Summary: Add the ability to create a new authorised value within the cataloguing module Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl If you are editing a bibliographic record, then you realised that you need a new authorised values, you have to go to the admin module, and reload the page. It would be handy to create it directly from the cataloguing module. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17390, 25727 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 [Bug 17390] Add REST API endpoint for Authorised Values https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 [Bug 25727] Update the Select2 JS lib -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- How it looks like: https://snipboard.io/FYuAay.jpg https://snipboard.io/CL7vTo.jpg https://snipboard.io/B5aJ7m.jpg https://snipboard.io/HL9lfO.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105837&action=edit Bug 25728: Create AV when cataloguing a bibliographic record This whole patch set adds the ability to create a new authorised value directly from the cataloguing module. It will prevent the cataloger to leave and reload the page if they need a new one. Test plan: If you are logged in with a patron with the manage_authorised_values subpermission you will be able to: * Edit a bibliographic record * Search for a subfield linked to an authorised values (not the "fake" AV like itemtypes, branches, cn) * Click the dropdown list and start searching for a value that does not exist * Click enter * Fill the fields in the popup * Save => Your dropdown list has the new AV :) Note: This does not work for the advanced editor. It does not have select2 applied to the selects. I have hardly tried but failed. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105838&action=edit Bug 25728: Create AV when adding a new item We do a bit of refactoring to make the code reusable. Test plan: Same as the first patch but when adding/editing an item QA note: There is a warning from the QA tools FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt FAIL js_in_body A <script> tag found inside head, must be moved to the body (see bug 17858) I don't think how we could avoid it. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105839&action=edit Bug 25728: Create AV when cataloguing an authority record Test plan: Same as the first patch but when cataloguing an authority record Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105840&action=edit Bug 25728: Don't explode in the advanced editor Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105841&action=edit Bug 25728: Fix the clone field feature Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105842&action=edit Bug 25728: Don't explode if no CAN_* var defined Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105852&action=edit Bug 25728: Use a svc script instead of the REST API endpoint The try to implement correctly the REST API endpoint for authorised values failed. This patch uses an easy to implement svc script for the POST route. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17390 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 [Bug 17390] Add REST API endpoint for Authorised Values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #1)
How it looks like: https://snipboard.io/FYuAay.jpg https://snipboard.io/CL7vTo.jpg https://snipboard.io/B5aJ7m.jpg https://snipboard.io/HL9lfO.jpg
Pretty! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105837|0 |1 is obsolete| | --- Comment #10 from Hugo Agud <hagud@orex.es> --- Created attachment 106696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106696&action=edit Bug 25728: Create AV when cataloguing a bibliographic record This whole patch set adds the ability to create a new authorised value directly from the cataloguing module. It will prevent the cataloger to leave and reload the page if they need a new one. Test plan: If you are logged in with a patron with the manage_authorised_values subpermission you will be able to: * Edit a bibliographic record * Search for a subfield linked to an authorised values (not the "fake" AV like itemtypes, branches, cn) * Click the dropdown list and start searching for a value that does not exist * Click enter * Fill the fields in the popup * Save => Your dropdown list has the new AV :) Note: This does not work for the advanced editor. It does not have select2 applied to the selects. I have hardly tried but failed. Sponsored-by: Orex Digital Signed-off-by:Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105838|0 |1 is obsolete| | --- Comment #11 from Hugo Agud <hagud@orex.es> --- Created attachment 106697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106697&action=edit Bug 25728: Create AV when adding a new item We do a bit of refactoring to make the code reusable. Test plan: Same as the first patch but when adding/editing an item QA note: There is a warning from the QA tools FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt FAIL js_in_body A <script> tag found inside head, must be moved to the body (see bug 17858) I don't think how we could avoid it. Sponsored-by: Orex Digital Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105839|0 |1 is obsolete| | --- Comment #12 from Hugo Agud <hagud@orex.es> --- Created attachment 106698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106698&action=edit Bug 25728: Create AV when cataloguing an authority record Test plan: Same as the first patch but when cataloguing an authority record Sponsored-by: Orex Digital Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105840|0 |1 is obsolete| | --- Comment #13 from Hugo Agud <hagud@orex.es> --- Created attachment 106699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106699&action=edit Bug 25728: Don't explode in the advanced editor Sponsored-by: Orex Digital Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105841|0 |1 is obsolete| | --- Comment #14 from Hugo Agud <hagud@orex.es> --- Created attachment 106700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106700&action=edit Bug 25728: Fix the clone field feature Sponsored-by: Orex Digital Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105842|0 |1 is obsolete| | --- Comment #15 from Hugo Agud <hagud@orex.es> --- Created attachment 106701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106701&action=edit Bug 25728: Don't explode if no CAN_* var defined Sponsored-by: Orex Digital Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105852|0 |1 is obsolete| | --- Comment #16 from Hugo Agud <hagud@orex.es> --- Created attachment 106702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106702&action=edit Bug 25728: Use a svc script instead of the REST API endpoint The try to implement correctly the REST API endpoint for authorised values failed. This patch uses an easy to implement svc script for the POST route. Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This depends on bug 25727 that hasn't been signed off yet. There has also been something gone wrong with the sign-off line on these patches here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106696|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108356&action=edit Bug 25728: Create AV when cataloguing a bibliographic record This whole patch set adds the ability to create a new authorised value directly from the cataloguing module. It will prevent the cataloger to leave and reload the page if they need a new one. Test plan: If you are logged in with a patron with the manage_authorised_values subpermission you will be able to: * Edit a bibliographic record * Search for a subfield linked to an authorised values (not the "fake" AV like itemtypes, branches, cn) * Click the dropdown list and start searching for a value that does not exist * Click enter * Fill the fields in the popup * Save => Your dropdown list has the new AV :) Note: This does not work for the advanced editor. It does not have select2 applied to the selects. I have hardly tried but failed. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106697|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108357&action=edit Bug 25728: Create AV when adding a new item We do a bit of refactoring to make the code reusable. Test plan: Same as the first patch but when adding/editing an item QA note: There is a warning from the QA tools FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt FAIL js_in_body A <script> tag found inside head, must be moved to the body (see bug 17858) I don't think how we could avoid it. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106698|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108358&action=edit Bug 25728: Create AV when cataloguing an authority record Test plan: Same as the first patch but when cataloguing an authority record Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106699|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108359&action=edit Bug 25728: Don't explode in the advanced editor Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106700|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108360&action=edit Bug 25728: Fix the clone field feature Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106701|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108361&action=edit Bug 25728: Don't explode if no CAN_* var defined Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106702|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108362&action=edit Bug 25728: Use a svc script instead of the REST API endpoint The try to implement correctly the REST API endpoint for authorised values failed. This patch uses an easy to implement svc script for the POST route. Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108356|0 |1 is obsolete| | Attachment #108357|0 |1 is obsolete| | Attachment #108358|0 |1 is obsolete| | Attachment #108359|0 |1 is obsolete| | Attachment #108360|0 |1 is obsolete| | Attachment #108361|0 |1 is obsolete| | Attachment #108362|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108883&action=edit Bug 25728: Create AV when cataloguing a bibliographic record This whole patch set adds the ability to create a new authorised value directly from the cataloguing module. It will prevent the cataloger to leave and reload the page if they need a new one. Test plan: If you are logged in with a patron with the manage_authorised_values subpermission you will be able to: * Edit a bibliographic record * Search for a subfield linked to an authorised values (not the "fake" AV like itemtypes, branches, cn) * Click the dropdown list and start searching for a value that does not exist * Click enter * Fill the fields in the popup * Save => Your dropdown list has the new AV :) Note: This does not work for the advanced editor. It does not have select2 applied to the selects. I have hardly tried but failed. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108884&action=edit Bug 25728: Create AV when adding a new item We do a bit of refactoring to make the code reusable. Test plan: Same as the first patch but when adding/editing an item QA note: There is a warning from the QA tools FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt FAIL js_in_body A <script> tag found inside head, must be moved to the body (see bug 17858) I don't think how we could avoid it. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108885&action=edit Bug 25728: Create AV when cataloguing an authority record Test plan: Same as the first patch but when cataloguing an authority record Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108886&action=edit Bug 25728: Don't explode in the advanced editor Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108887&action=edit Bug 25728: Fix the clone field feature Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108888&action=edit Bug 25728: Don't explode if no CAN_* var defined Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108889&action=edit Bug 25728: Use a svc script instead of the REST API endpoint The try to implement correctly the REST API endpoint for authorised values failed. This patch uses an easy to implement svc script for the POST route. Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108890&action=edit Bug 25728: fix rebase issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #25)
Can you please rebase?
Rebased, that was painful. The QA failure is ok "A <script> tag found inside head, must be moved to the body" I had to put it in head. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Joubu, finally get to test here :) 1) QA test tools: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt OK filters OK forbidden patterns OK git manipulation FAIL js_in_body A <script> tag found inside head, must be moved to the body (see bug 17858) 2) GUI I would suggest a small change. Most of the codes should best be added capitalized and without special characters. I'd suggest either pre-filling the code or the description with the entered text, leaning towards the description. One argument for description would be that most of the item status fields only work with numerical codes. Also the code field and description should be required fields in the modal. What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Talked to Joubu: - We indeed to not have these fields are required on the admin screen, so we just match the behaviour in the modal. - We also do not keep people from adding values that won't work... so validation should be handled separately as well. - The JS error from the QA script was checked and is ok (see comment#34) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've now tested in authorities and cataloguing too. I still feel like we should not pre-fill the authorised value with the text entered, but only the description. Otherwise this works really nicely. Codes should be picked wisely, I think that would better support this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108922&action=edit Bug 25728: Don't prefill av's code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108883|0 |1 is obsolete| | --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108923&action=edit Bug 25728: Create AV when cataloguing a bibliographic record This whole patch set adds the ability to create a new authorised value directly from the cataloguing module. It will prevent the cataloger to leave and reload the page if they need a new one. Test plan: If you are logged in with a patron with the manage_authorised_values subpermission you will be able to: * Edit a bibliographic record * Search for a subfield linked to an authorised values (not the "fake" AV like itemtypes, branches, cn) * Click the dropdown list and start searching for a value that does not exist * Click enter * Fill the fields in the popup * Save => Your dropdown list has the new AV :) Note: This does not work for the advanced editor. It does not have select2 applied to the selects. I have hardly tried but failed. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108884|0 |1 is obsolete| | --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108924&action=edit Bug 25728: Create AV when adding a new item We do a bit of refactoring to make the code reusable. Test plan: Same as the first patch but when adding/editing an item QA note: There is a warning from the QA tools FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt FAIL js_in_body A <script> tag found inside head, must be moved to the body (see bug 17858) I don't think how we could avoid it. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108885|0 |1 is obsolete| | --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108925&action=edit Bug 25728: Create AV when cataloguing an authority record Test plan: Same as the first patch but when cataloguing an authority record Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108886|0 |1 is obsolete| | --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108926&action=edit Bug 25728: Don't explode in the advanced editor Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108887|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108927&action=edit Bug 25728: Fix the clone field feature Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108888|0 |1 is obsolete| | --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108928&action=edit Bug 25728: Don't explode if no CAN_* var defined Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108889|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108929&action=edit Bug 25728: Use a svc script instead of the REST API endpoint The try to implement correctly the REST API endpoint for authorised values failed. This patch uses an easy to implement svc script for the POST route. Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108890|0 |1 is obsolete| | --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108930&action=edit Bug 25728: fix rebase issues Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108922|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108931&action=edit Bug 25728: Don't prefill av's code Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #49 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When a librarian is release notes| |cataloguing a bibliographic | |record and needs a new | |authorised value, they will | |now be able to create it | |directly from the edit | |form. | |It also works on the | |item and authority editing | |forms. | |They will need the | |necessary permission: | |manage_authorised_values. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27128 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27128 [Bug 27128] Follow-up to bug 25728 - Don't prefill av's code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Klas Blomberg <klas.blomberg@skovde.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |klas.blomberg@skovde.se --- Comment #50 from Klas Blomberg <klas.blomberg@skovde.se> --- I don't like this patch at all! After just a few weeks we have dozens of new locations created by mistake, like HORS, FICT, NON-FI &c, &c Staff type just the first letters of a location and then hit enter, and voila, there is a new location! Please make a syspref for this, and make it disabled by default - or set it as a permission that could be turned off, even for superlibrarians -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Klas Blomberg from comment #50)
I don't like this patch at all! After just a few weeks we have dozens of new locations created by mistake, like HORS, FICT, NON-FI &c, &c
Staff type just the first letters of a location and then hit enter, and voila, there is a new location!
Please make a syspref for this, and make it disabled by default - or set it as a permission that could be turned off, even for superlibrarians
Hi Klas, this is not how it should work. The intended behaviour is that it opens up a modal where you have to enter further information - code and descripton for the new authorised value. If it works like you describe, this would be a bug. It is already tied to a permission - you can't add them if you don't have managing authorised values permission. Does that help? Also: Filing a new bug and linking to the existing bug once released is better, we will have to do this for this to progress and with the link everyone added here will also get emailed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 [Bug 29137] Unwanted to authorised values are too easily created via the cataloging module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|When a librarian is |When a librarian is release notes|cataloguing a bibliographic |cataloguing a bibliographic |record and needs a new |record and needs a new |authorised value, they will |authorised value, they will |now be able to create it |now be able to create it |directly from the edit |directly from the edit |form. |form. |It also works on the |It also works on the |item and authority editing |item and authority editing |forms. |forms. |They will need the |They will need the |necessary permission: |necessary permission: |manage_authorised_values. |manage_auth_values. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org