[Bug 5026] New: Undefined dates not formatted in serials update
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 Summary: Undefined dates not formatted in serials update Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Serials AssignedTo: colin.campbell@ptfs-europe.com ReportedBy: colin.campbell@ptfs-europe.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Supplementary to Bug 5021 : dates are also incorrectly formatted in serials edit if not defined. Apply similar processing in display. In test version (for 3.4) this should be handled for all cases in one place rather than the current format ad hoc all over the place -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 2380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2380 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Patch withdrawn. Needs a couple of other cases dealt with -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2380|0 |1 is obsolete| | --- Comment #3 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 2381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2381 Updated fuller patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2010-12-20 12:17:40 UTC --- Patch fails at current master. HEAD is now at 3c19f22 Merge remote branch 'kc/new/enh/bug_5283' into kcmaster error: patch failed: serials/serials-edit.pl:90 error: serials/serials-edit.pl: patch does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2381|0 |1 is obsolete| | --- Comment #5 from Colin Campbell <colin.campbell@ptfs-europe.com> 2010-12-21 10:21:38 UTC --- Created attachment 2898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2898 Proposed Patch Patch rebased against current master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 --- Comment #6 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-01-11 12:58:20 UTC --- This bug is mentioned in: Bug 5026 Undefined dates formatted poorly in serials-edit http://lists.koha-community.org/pipermail/koha-patches/2010-December/013450.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-01-13 11:21:33 UTC --- Thanks for updating the patch. Testing these changes seemed fine, but it is hard to say if you cover all changes. Did some code checking too on these changes and have four questions. Serials.pm 1) Line 734 $line->{planneddate} should be $line->{$datefield} ? serials-edit.pl 2) Line 99 If you assign to @serialsid in the for loop, you only keep the last results. There was a push to this array in the old code. Looks like a bug? 3) Line 119 This was already, but why is debug 1 ? 4) Line 376 A former comment stated that the sort was needed. Sure that you could remove it? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2898|0 |1 is obsolete| | --- Comment #8 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-01-13 14:17:22 UTC --- Created attachment 2984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2984 Revised Patch Revised patch which addresses some issues in the original patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 --- Comment #9 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-01-13 14:31:53 UTC --- Thanks for spotting those issues. I'm sending an amended patch. I've fixed the typos in 1 & 2 As for 3 most/all the serials cgi scripts set debug to 1 but looking at the called routine that parameter appears not to be examined. I'll look further but I think we can remove these. I'll generate a bug/patch for that. 4. Yes - the comment was a bit opaque in not saying why. In fact there are two redirects to serials-collections.pl and one sorted and one didn't. What I've done in the revised patch is move the sort to serials-collection so that the fact that the list is sorted is apparent where it is used and consistent. I'll take a closer look at serials-collection.pl, its not as clear as it could be. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 --- Comment #10 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-01-13 16:14:20 UTC --- Created attachment 2988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2988 Patch (version for 3.2) Patch did not cleanly apply against 3.2.x have added a version that does -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-01-17 08:20:43 UTC --- Tested revised patch on master. Works OK. Just a note: Still see some XXX's in date fields on serials-collection.pl. Originate probably from routine PrepareSerialsData in Serials.pm. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> 2011-01-17 10:01:55 UTC --- Pushed to master, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org