[Bug 8524] New: Add barcode plugin that does not autofill
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Priority: P5 - low Change sponsored?: --- Bug ID: 8524 CC: m.de.rooy@rijksmuseum.nl Assignee: jcamins@cpbibliography.com Summary: Add barcode plugin that does not autofill Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: ASSIGNED Version: master Component: Cataloging Product: Koha The current barcode plugin uses the autobarcode syspref to decide which type of barcode to generate, then *always* inserts a barcode. There should be a plugin which will only insert the barcode when the plugin link is clicked. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11271&action=edit Bug 8524: Add a non-automatic barcode plugin In addition to adding a new barcode plugin, this commit begins refactoring the barcode generation code using a new module, C4::Barcodes::ValueBuilder. From the POD: This module is intended as a shim to ease the eventual transition from having all barcode-related code in the value builder plugin barcode.pl file to using C4::Barcodes. Since the shift will require a rather significant amount of refactoring, this module will return value builder-formatted results, at first by merely running the code that was formerly in the barcodes.pl value builder, but later by using C4::Barcodes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- To test: 1) Set the plugin for 952$p (or UNIMARC equivalent to items.barcode) for one of your frameworks to barcode_manual.pl instead of barcode.pl. 2) Turn on autobarcode. 3) Observe that when you click in the barcode field, nothing happens. 4) Observe that when you click the value builder link next to the plugin, the barcode field is filled in. 5) Run t/Barcodes_ValueBuilder.t, ensure that the tests complete. That's it, really. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11271|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11343&action=edit Bug 8524: Add a non-automatic barcode plugin In addition to adding a new barcode plugin, this commit begins refactoring the barcode generation code using a new module, C4::Barcodes::ValueBuilder. From the POD: This module is intended as a shim to ease the eventual transition from having all barcode-related code in the value builder plugin barcode.pl file to using C4::Barcodes. Since the shift will require a rather significant amount of refactoring, this module will return value builder-formatted results, at first by merely running the code that was formerly in the barcodes.pl value builder, but later by using C4::Barcodes. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- You plan 15 tests in t/Barcodes_ValueBuilder.t but only 10 are run. You can replace use Test::More tests => 15; with use Test::More; and at the end of the file: done_testing; or use Test::More tests => 15; => use Test::More tests => 10; + 2 warnings: t/Barcodes_ValueBuilder.t .. 1/15 Use of uninitialized value $scr in numeric eq (==) at t/Barcodes_ValueBuilder.t line 43. C4::Barcodes::ValueBuilder::incremental::get_barcode returns 1 results not 2. $src is always undefined. Same thing for C4::Barcodes::ValueBuilder::annual::get_barcode Marking as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11481&action=edit Bug 8524 follow-up: fix broken test The t/Barcodes_ValueBuilder.t test had the wrong number of tests declared, and rather than checking that a variable was undefined I was checking that it had a length of zero. Fixed both issues. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11481|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11484&action=edit Bug 8524 follow-up: fix broken test The t/Barcodes_ValueBuilder.t test had the wrong number of tests declared, and rather than checking that a variable was undefined I was checking that it had a length of zero. Fixed both issues. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11485&action=edit Bug 8524: Followup FIX an undeclared variable $query -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Jared, Sorry, but another problem already exists. When I click twice on '...' to fill with the barcode value, a JS error occured: "force is not defined". The issue only exist for the plugin barcode_manual.pl. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #8)
Jared, Sorry, but another problem already exists. When I click twice on '...' to fill with the barcode value, a JS error occured: "force is not defined". The issue only exist for the plugin barcode_manual.pl.
Ooh, good test. It never occurred to me to click twice. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11491&action=edit Bug 8524 follow-up: fix Javascript syntax error -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11491|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11492&action=edit Bug 8524 follow-up: fix Javascript syntax error Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #9)
Ooh, good test. It never occurred to me to click twice.
I didn't do it on purpose :) I just forgot to reload the page... Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11484|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11493&action=edit Bug 8524 follow-up: fix broken test The t/Barcodes_ValueBuilder.t test had the wrong number of tests declared, and rather than checking that a variable was undefined I was checking that it had a length of zero. Fixed both issues. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11485|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11494&action=edit Bug 8524: Followup FIX an undeclared variable $query Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11492|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11495&action=edit Bug 8524 follow-up: fix Javascript syntax error Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Last question :) Why didn't you remove the other plugin (barcode.pl) ? It seems they do exacly the same (except for $autoBarcodeType eq 'EAN13'). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #16)
Last question :) Why didn't you remove the other plugin (barcode.pl) ? It seems they do exacly the same (except for $autoBarcodeType eq 'EAN13').
barcode.pl works exactly the way it always has: whenever the barcode field has focus, it is populated. For many libraries this is not the desired functionality. barcode_manual.pl will not populate the barcode unless the ellipsis is clicked. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> --- I haven't tested that the new plugin work, but the old plugin still work, I've tested that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz Version|rel_3_10 |master --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- After no objections, this was pushed to 3.8.x and will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org