https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Aleisha, 1) there were several complaints by the QA tools that I have fixed 2 in separate follow-up patches. Could you please fix the third one? I have not been able to figure this one out: FAIL acqui/moddeliverydate.pl FAIL valid Useless use of private variable in void context 2) This bit here is not translatable: var modalTitle = $(this).attr("title") + " (order number " + ordernumber + ")"; 3) When adding a new order, there is no calendar widget for the estimated delivery date column. I have tried to do an update to flatpickr in a follow-up, but I think it's not complete yet. I believe these type of lines need to be removed from the files as well: $("#estimated_delivery_date").datepicker(); 4) Looking for 'datepicker' in the code, I saw that there is code for a modal in lateorders.tt, but it doesn't appear to be used, it looks like moddeliverdatey.tt is used instead. A modal like the edit notes one on the same page would really nice and more consistent: <div class="modal-content"> <div class="modal-header"> <button type="button" class="closebtn" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">×</span></button> <h4 class="modal-title" id="dateEditorLabel">Estimated delivery date</h4> </div> <div class="modal-body"> <input type="text" id="estimated_delivery_date" size="10" name="estimated_delivery_date" class="datepicker" value="[% estimated_delivery_date | html %]"/> <div class="hint">[% INCLUDE 'date-format.inc' %]</div> <input type="hidden" id="date_ordernumber" name="ordernumber" value="" /> <input type="hidden" name="op" value="save" /> </div> 5) It's not possible to edit the estimated delivery date from a closed basket. If you reopen and close the basket, the close date will be updated, that is also used as the order date. So we need to be able to update this without reopening. 6) When editing the delivery date from the late orders page, things would explode. I fixed the import statements in a follow-up. Hope I caught them all. -- You are receiving this mail because: You are watching all bug changes.