[Bug 20366] New: More information about orders linked to subscriptions on "Acquisition details" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Bug ID: 20366 Summary: More information about orders linked to subscriptions on "Acquisition details" tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: severine.queune@bulac.fr QA Contact: testopia@bugs.koha-community.org On the 'Acquisition detail' tab on bibliographic record, we cant' know if orders are placed on bibliographic or subscription level. It is quite complicated when several subscriptions are attached to this record to have a clear history of the acquisitions. It would be great for order managers if we could have 2 more columns on this tab, one with the 'aqorders.subsciptionid' and one with 'subscription.callnumber'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking developer --- Comment #1 from Séverine Queune <severine.queune@bulac.fr> --- The BULAC (http://www.bulac.fr/) would like to sponsor this development ! As long as “Change sponsored?” is set on “Seeking developer”, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: <sigb@bulac.fr>. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Seeking developer |Sponsored Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20365 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20365 [Bug 20365] Allow several open orders on subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75174&action=edit Bug 20366: Add new method Koha::Acquisition::Order->subscription Can be moved to a separate bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75175&action=edit Bug 20366: Add new method Koha::Acquisition::Basket->basket_group Can be moved to a separate bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75176&action=edit Bug 20366: Add subscription info to the acq tab on the biblio detail page On the "Acquisition details" tab of the bibliographic detail page, the subscription information are missing. This patch replace the call to GetHistory with Koha::Acquisition::Orders in order to simplify the code and make use of new Koha:: packages/methods. TODO: Add column settings (show/hide columns) to this table (?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Attached to test but will certainly need to be adjusted depending on the decisions from bug 20726. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #6 from Séverine Queune <severine.queune@bulac.fr> --- I was curious to see what it looks like, but can't apply patches. $ git bz apply 20366 Bug 20366 - More information about orders linked to subscriptions on "Acquisition details" tab 75174 - Bug 20366: Add new method Koha::Acquisition::Order->subscription 75175 - Bug 20366: Add new method Koha::Acquisition::Basket->basket_group 75176 - Bug 20366: Add subscription info to the acq tab on the biblio detail page Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20366: Add new method Koha::Acquisition::Order->subscription fatal: sha1 information is lacking or useless (Koha/Acquisition/Order.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 20366: Add new method Koha::Acquisition::Order->subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- You need to apply patches from bug 20365 first, and so the ones from bug 20726 too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have pushed a branch to my gitlab repo to help testing: https://gitlab.com/joubu/Koha/tree/bug_20366 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 [Bug 15184] Ability to duplicate existing order lines to a given basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- I get an error when I try to view detail.pl: Template process failed: undef error - DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.created_by' in 'field list' at /home/vagrant/kohaclone/Koha/Objects.pm line 269 at /home/vagrant/kohaclone/C4/Templates.pm line 122 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not recreate that, could you confirm you do not have this issue on master? Or without patches from this bug, i.e. with patches from bug 20365? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #10)
Or without patches from this bug, i.e. with patches from bug 20365?
I have this problem on master, only happens after applying this patch set (not with the patch dependencies). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I guess you have some data inconsistencies, or the bug comes somewhere else. I do not see how it could be related to this bug (I may be wrong ofc). Maybe you will get the same error browsing the acq module? I am resetting to needs signoff in order to get other tests on it, let me know if you have more pointers to give me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75174|0 |1 is obsolete| | Attachment #75175|0 |1 is obsolete| | Attachment #75176|0 |1 is obsolete| | --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 77438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77438&action=edit Bug 20366: Add new method Koha::Acquisition::Order->subscription Can be moved to a separate bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 77439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77439&action=edit Bug 20366: Add new method Koha::Acquisition::Basket->basket_group Can be moved to a separate bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 77440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77440&action=edit Bug 20366: Add subscription info to the acq tab on the biblio detail page On the "Acquisition details" tab of the bibliographic detail page, the subscription information are missing. This patch replace the call to GetHistory with Koha::Acquisition::Orders in order to simplify the code and make use of new Koha:: packages/methods. TODO: Add column settings (show/hide columns) to this table (?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 77441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77441&action=edit Bug 20366: (follow-up) Fix link to subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77438|0 |1 is obsolete| | Attachment #77439|0 |1 is obsolete| | Attachment #77440|0 |1 is obsolete| | Attachment #77441|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77452&action=edit Bug 20366: Add new method Koha::Acquisition::Order->subscription Can be moved to a separate bug report. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77453&action=edit Bug 20366: Add new method Koha::Acquisition::Basket->basket_group Can be moved to a separate bug report. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77454&action=edit Bug 20366: Add subscription info to the acq tab on the biblio detail page On the "Acquisition details" tab of the bibliographic detail page, the subscription information are missing. This patch replace the call to GetHistory with Koha::Acquisition::Orders in order to simplify the code and make use of new Koha:: packages/methods. TODO: Add column settings (show/hide columns) to this table (?) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77455&action=edit Bug 20366: (follow-up) Fix link to subscription Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77452|0 |1 is obsolete| | Attachment #77453|0 |1 is obsolete| | Attachment #77454|0 |1 is obsolete| | Attachment #77455|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77508&action=edit Bug 20366: Add new method Koha::Acquisition::Order->subscription Can be moved to a separate bug report. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77509&action=edit Bug 20366: Add new method Koha::Acquisition::Basket->basket_group Can be moved to a separate bug report. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77510&action=edit Bug 20366: Add subscription info to the acq tab on the biblio detail page On the "Acquisition details" tab of the bibliographic detail page, the subscription information are missing. This patch replace the call to GetHistory with Koha::Acquisition::Orders in order to simplify the code and make use of new Koha:: packages/methods. TODO: Add column settings (show/hide columns) to this table (?) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77511&action=edit Bug 20366: (follow-up) Fix link to subscription Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21166 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #4)
TODO: Add column settings (show/hide columns) to this table (?)
See bug 21166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21166 [Bug 21166] Add columns settings to the acquisition details table (record detail view) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77508|0 |1 is obsolete| | Attachment #77509|0 |1 is obsolete| | Attachment #77510|0 |1 is obsolete| | Attachment #77511|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78070&action=edit Bug 20366: Add new method Koha::Acquisition::Order->subscription Can be moved to a separate bug report. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78071&action=edit Bug 20366: Add new method Koha::Acquisition::Basket->basket_group Can be moved to a separate bug report. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78072&action=edit Bug 20366: Add subscription info to the acq tab on the biblio detail page On the "Acquisition details" tab of the bibliographic detail page, the subscription information are missing. This patch replace the call to GetHistory with Koha::Acquisition::Orders in order to simplify the code and make use of new Koha:: packages/methods. TODO: Add column settings (show/hide columns) to this table (?) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78073&action=edit Bug 20366: (follow-up) Fix link to subscription Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Bug 20366 depends on bug 20365, which changed state. Bug 20365 Summary: Allow several open orders on subscription https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20365 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24058 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 [Bug 24058] acquisition table displayed even if no order exist (bib detail) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org