[Bug 13613] New: Don't allow digest to be selected without a digest-able transport selected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Bug ID: 13613 Summary: Don't allow digest to be selected without a digest-able transport selected Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org By default, only the email transport is enabled. This gives the messaging preferences the look of having email and digest and two options. I.E. to some users it appears that you check email for single emails, *or* you check digest for a digest email. To help remove this possible confusion, the digest mode checkbox should be disabled if no digest-able transports are checked for a given notice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35471&action=edit Bug 13613 - Don't allow digest to be selected without a digest-able transport selected By default, only the email transport is enabled. This gives the messaging preferences the look of having email and digest and two options. I.E. to some users it appears that you check email for single emails, *or* you check digest for a digest email. To help remove this possible confusion, the digest mode checkbox should be disabled if no digest-able transports are checked for a given notice. Test Plan: 1) Apply this patch 2) For both the staff interface and the opac, note that the digest checkbox is disabled any time that no digest enabled transport ( email, sms if enabled ) is checked for the patron editor. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org Status|Needs Signoff |Failed QA --- Comment #2 from Nick Clemens <nick@quecheelibrary.org> --- I tried testing, in terms of not letting me check digest box until I checked email it worked. But I ran into some issues: 1 - When initially trying to click on the digest box (with nothing else checked) my browser focus jumps to the top of the page, same when I click on email box. Third try stayed and let me click email box. 2 - If I had only email enabled I was unable to save any preferences, I got a "Please enter a valid email address" note in red next to the checkbox. Entering a valid email did not clear it, entering secondary etc. emails did not. Editing the account to add a valid email, saving, then trying to check a messaging box also failed. The only way I could past this error was to enable additional transports, phone or SMS in any combination removed the error amd actually let me check email whether or not I had a valid email address on file. When I switch to master I cannot get this error 3 - While I was prevented from checking digest until another transport was selected, digest wasn't cleared when I unchecked the emial box. It didn't save, which is good, but the box should be cleared too. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org