[Bug 8679] New: Remove usage of Amazon API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8679 Priority: P5 - low Change sponsored?: --- Bug ID: 8679 Assignee: gmcharlt@gmail.com Summary: Remove usage of Amazon API Severity: normal Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha Koha hasn't been updated to use the new Amazon API and no one appears to want to do so. Anyone choosing to undertake the task would appear to do so at their own risk, given the Amazon.com Product Advertising API License Agreement (https://affiliate-program.amazon.com/gp/advertising/api/detail/agreement.htm...) says that Amazon must approve each system's request for API access and: "Unsuitable applications include those that: ... do not have as their principal purpose advertising and marketing the Amazon Site and driving sales of products and services on the Amazon Site." Instead of continuing to ship new versions of Koha with broken Amazon integration I think we should remove the functionality which depends on the API. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8679 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8679 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8679 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11807&action=edit Bug 8679 - Remove usage of Amazon API This patch removes the AmazonReviews and AmazonSimilarItems features from the OPAC and staff client. With on Amazon feature remaining, cover images, the *AmazonEnabled preference is also removed in favor of checking the *AmazonCoverImages preference. The Amazon module is removed. Two other system preferences, AWSAccessKeyID and AWSPrivateKey are removed as they were required only by Amazon.pm. Handling of book cover images from Amazon is unchanged. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8679 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8679 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11807|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 11808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11808&action=edit [SIGNED-OFF] Bug 8679 - Remove usage of Amazon API This patch removes the AmazonReviews and AmazonSimilarItems features from the OPAC and staff client. With on Amazon feature remaining, cover images, the *AmazonEnabled preference is also removed in favor of checking the *AmazonCoverImages preference. The Amazon module is removed. Two other system preferences, AWSAccessKeyID and AWSPrivateKey are removed as they were required only by Amazon.pm. Handling of book cover images from Amazon is unchanged. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Turned on amazon covers in opac and staff client and all worked as expected. Then tested to make sure other cover image services still worked and they do. Signing off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8679 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: All seems good. But there is 1 occurrence left of C4::External::Amazon in the unit test : t/db_dependent/Amazon.t Marked as Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8679 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11808|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11863&action=edit Bug 8679 [REVISED] Remove usage of Amazon API This patch removes the AmazonReviews and AmazonSimilarItems features from the OPAC and staff client. With on Amazon feature remaining, cover images, the *AmazonEnabled preference is also removed in favor of checking the *AmazonCoverImages preference. Two other system preferences, AWSAccessKeyID and AWSPrivateKey are removed as they were required only by the removed features. Handling of book cover images from Amazon is unchanged. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8679 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8679 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11863|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 11864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11864&action=edit [SIGNED-OFF] Bug 8679 [REVISED] Remove usage of Amazon API This patch removes the AmazonReviews and AmazonSimilarItems features from the OPAC and staff client. With on Amazon feature remaining, cover images, the *AmazonEnabled preference is also removed in favor of checking the *AmazonCoverImages preference. Two other system preferences, AWSAccessKeyID and AWSPrivateKey are removed as they were required only by the removed features. Handling of book cover images from Amazon is unchanged. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Turned on amazon covers in opac and staff client and all worked as expected. Then tested to make sure other cover image services still worked and they do. Signing off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8679 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8679 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed. I suggest that it's not backported to 3.8 even it's it's a bugfix, because some hidden problem could be hard to detect. I checked that there is no more occurrences of the removed sysprefs or subs, could not find any problem -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8679 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org