[Bug 11248] New: Problems with translated list email sent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Bug ID: 11248 Summary: Problems with translated list email sent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Same encoding issue as bug 10605. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22927&action=edit Bug 11248: Encoding issue on sending a list (OPAC) See bug 10605 for more details. Test plan: - send a list via email with the english version. - translate templates and retry with another language. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22928&action=edit Bug 11248: Encoding issue on sending a list (INTRANET) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10605 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22927|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22929&action=edit Bug 11248: Encoding issue on sending a list (OPAC) See bug 10605 for more details. Test plan: - send a list via email with the english version. - translate templates and retry with another language. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a bit confusing. without the patch the translated Email has 'no subject' and no content, but I thought that had been fixed a while ago? With the patch applied, the line breaks are missing: Guten Tag, dies ist Ihre Liste TEST, die Sie sich aus unserem Online-Katalog zugeschickt haben. Bitte beachten Sie, dass es sich bei der angehängten Datei um Daten im bibliographischen MARC-Format handelt, dass Sie in eine persönliche Literaturverwaltungssoftware wie EndNote, Reference Manager oder ProCite importieren können. --------------------------------------------- Der Tagesspiegel : Weitere Verfasser: Reger, Erik Verlag: Verl. Der Tagesspiegel, 57 Fußnoten: Begr.: Erik Reger, Walther Karsch, Edwin Redslob; Mitbegr.: Peter de Mendelssohn; Hrsg.: Hellmuth Karasek, Hermann Rudolph; 1949 - 1984: Franz Karl Maier, Heik Afheldt; ab 2004,Aug.: Giovanni di Lorenzo; verantw. Red. bis 2004,Juli: Giovanni di Lorenzo; Verleger ab ca. 1993: Dieter von Holtzbrinck. Amerikan. Lizenz: Nr. 16; ZKZ: 6622; Relaunch: 1994, 2.Sept. u. 1999, 23.Mai. Exemplar(e) : --------------------------------------------- Die Weltwoche Verlag: Weltwoche-Verl. | Die Weltwoche c/o Jean Frey AG,, 57 Exemplar(e) : --------------------------------------------- Südkurier : Verlag: Südkurier, 57 Fußnoten: VKZ: E 6576. Exemplar(e) : --------------------------------------------- The broken umlauts in that example go away, when I tell Thunderbird that the encoding is UTF-8 - is there a way to make it autodetect that correctly? (That's for staff). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 22980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22980&action=edit Bug 11248: Follow up - Fix template for translated list emails in staff Copied over the template changes done for the OPAC to the staff template. To test: - Update and install translation files - Send yourself a shelf from the staff interface vie email - Check formatting and links are correct -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22980|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22928|0 |1 is obsolete| | Attachment #22929|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 22981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22981&action=edit [SIGNED OFF] Bug 11248: Encoding issue on sending a list (INTRANET) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Sending an intranet list from translated templates requires a new list template for the intranet. I have added the needed changes in a follow-up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 22982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22982&action=edit [SIGNED OFF] Bug 11248: Encoding issue on sending a list (OPAC) See bug 10605 for more details. Test plan: - send a list via email with the english version. - translate templates and retry with another language. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely. Links to the OPAC are correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 22983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22983&action=edit Bug 11248: Follow up - Fix template for translated list emails in staff Copied over the template changes done for the OPAC to the staff template. To test: - Update and install translation files - Send yourself a shelf from the staff interface vie email - Check formatting and links are correct -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, could you take a look at my follow up? The list emails from staff were missing the template changes needed to make them survive the translation scripts unharmed :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22983|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 22984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22984&action=edit Bug 11248: Follow up - Fix template for translated list emails in staff Copied over the template changes done for the OPAC to the staff template. To test: - Update and install translation files - Send yourself a shelf from the staff interface vie email - Check formatting and links are correct Removes reference to [% BIBLIO_RESULT.size %], because with TT this will be the count of elements instead of the content of the field. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #9)
Hi Jonathan, could you take a look at my follow up?
The list emails from staff were missing the template changes needed to make them survive the translation scripts unharmed :)
I agree with the call to the url filter. But I am not sure the others changes is needed: - [% IF BIBLIO_RESULT.size %] - , [% BIBLIO_RESULT.size %] - [% END %] Why do you remove these lines? - In online catalog: [% OPACBaseURL %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% BIBLIO_RESULT.biblionumber %] + In online catalog: http://[% OPACBaseURL %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% BIBLIO_RESULT.biblionumber %] Why do you add the http before the OPACBaseURL? It does not exist in others places? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, 2 good questions - and I should have explained the changes better. I removed the [% BIBLIO_RESULT.size %] because the information it should display is not super important and it won't display currently. For TT size means to count the number of elements (I noticed that it was always 57 or something like that in my tests) and not the content of the database field. This is not an important, please undo it if you want, or I can do it, but not before much later tonight. I added the http:// because without the link was not working and appeared incomplete. Actually you are right and I should have looked into it more to see why it does not happen in the OPAC, there is also a bug for it (bug 5010). But why does it not happen on OPAC? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I found the difference that is causing the problems with the URL, but I will fix those on a separate bug. I will remove both changes Jonathan thought were suspicious (and he was right of course :) from my follow-up). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22984|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23360&action=edit Bug 11248: Follow up - Fix template for translated list emails in staff - Fixes some capitalization problems - Adds an URL filter -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5010 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11357 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I messed up a bit here, hope the redone follow-up makes more sense. Could you take a look Jonathan and switch to Signed off if it's ok? If the follow-up gives problems just obsolete it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5010 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|5010 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23360|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23369&action=edit [SIGNED OFF] Bug 11248: Follow up - Fix template for translated list emails in staff - Fixes some capitalization problems - Adds an URL filter Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Katrin, Thank you the followup. It looks good now :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- for* -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Note that someone other than Katrin and me is needed to QA these patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22981|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24140&action=edit Bug 11248: Encoding issue on sending a list (INTRANET) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Sending an intranet list from translated templates requires a new list template for the intranet. I have added the needed changes in a follow-up. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22982|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24141&action=edit Bug 11248: Encoding issue on sending a list (OPAC) See bug 10605 for more details. Test plan: - send a list via email with the english version. - translate templates and retry with another language. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely. Links to the OPAC are correct. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23369|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24142&action=edit Bug 11248: Follow up - Fix template for translated list emails in staff - Fixes some capitalization problems - Adds an URL filter Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- This is a major. The received email is empty and the subject is "no subject" on master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11944 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #25 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #26 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Picked for 3.12.15! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13239 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13239 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13596 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org