[Bug 17816] New: Useless call to GetBibioData in bulkmarcimport.pl(?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17816 Bug ID: 17816 Summary: Useless call to GetBibioData in bulkmarcimport.pl(?) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: glasklas@gmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz This call to GetBibioData seems without purpose: https://github.com/Koha-Community/Koha/blob/2fe2ef41bd8bf2f142597e39f493edbd... $biblioitemnumber is either overwritten on the lines below, or update/create failed/was skipped and the later AddItemBatchFromMarc will fail anyways. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17816 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- Ok, seems like ModBiblio returns 1(!), not id and itemid. So the lvalues for ModBibilio must be removed. I think I saw another bug-report on this somewhere. Think this takes some more effort to fix, AddItemBatchFromMarc should only be run on insert, so the line can still be removed. But some further refactoring is also needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17816 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org