[Bug 19166] New: Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Bug ID: 19166 Summary: Add the ability to add adjustments to an invoice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: nick@bywatersolutions.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The goal of this enhancement is to allow libraries to make adjustments to invoices based on feedback form a vendor (credit for returned books, damaged books, or fees for extra charges etc.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 66475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66475&action=edit Bug 19166 - Database changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 66476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66476&action=edit Bug 19166 - Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |katrin.fischer@bsz-bw.de, | |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- This needs tests and more work (rollover etc.) but I wanted to get any initial opinions on the intended functionality. Probably should be Koha::Acquisitions::Invoices::Adjustments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10412 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Patrick Robitaille <patrick.robitaille@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |San Diego Law release notes| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|San Diego Law |Sponsored by San Diego Law release notes| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nick, I know it's a somewhat early draft, hope the comments are still helpful: - Maybe the reason should be an authorised values list. Or a list in combination with a notes field? - I am not sure about the use case for encumber now/encumber later. Do you have a bit more information about this requirement maybe? (please take a look at my comments and tests on bug 18999) - If I choose "encumber while open" - should it show up as "spent"? And otherwise as "ordered"? It only seems to be taken into account on the acq start page right now when the checkbox is checked. - Budget should be fund in the form (the code is confusing here as budget and fund were switched in the GUI after the new acq module was written). - I think a delete link or button might be nicer than the checkbox - or have both in a nice table. - Adjustments can be stored currently without a fund, I think this needs some validation. - Adjustments can be positive or negative, right? (credit (-) and additional shipping/processing costs (+)?) So far this seems to work. - Format prices nicely using the TT plugin everywhere. - For the rollover things should be alright for the open orders as the new feature should not take effect there. But moving remaining funds over would have to take the actual amount into account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- One more addition: This is a much asked for and needed feature - please keep it going! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at bug 10412: Could we imagine a use case where the credit note is independent from an invoice? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #4)
I know it's a somewhat early draft, hope the comments are still helpful: Yes! Good to get feedback early :-)
- Maybe the reason should be an authorised values list. Or a list in combination with a notes field? The first I planned as a later enhancement, but the second is interesting, I will take a look
- I am not sure about the use case for encumber now/encumber later. Do you have a bit more information about this requirement maybe? (please take a look at my comments and tests on bug 18999) Yes, 'encumber while open' decide if your credits affect the invoice when open, or only when closed. If 'encumber while open' is checked then adjustments should show in 'ordered' until invoice is closed - once it is closed they move to 'spent' If not 'encumber while open' the adjustments have no effect on 'ordered' while invoice is open and move to 'spent' when closed
- Budget should be fund in the form Yup, will fix
- I think a delete link or button might be nicer than the checkbox - or have both in a nice table. I am working on improving the GUI
- Adjustments can be stored currently without a fund, I think this needs some validation. This was to mirror 'Shipping cost' which may not have a fund, it seems the value is not deducted when this is used? It can be removed if not necessary
- Adjustments can be positive or negative, right? (credit (-) and additional shipping/processing costs (+)?) So far this seems to work. Yes, the intention is to allow corrections of any kind to the invoice
- Format prices nicely using the TT plugin everywhere. Will fix
- For the rollover things should be alright for the open orders as the new feature should not take effect there. But moving remaining funds over would have to take the actual amount into account. Hmmm...as I understand the process a rollover only moves unreceived orders - we are dealing with things at the invoice level - any invoices/adjustments should be closed and affect the old budget only - if you have a remaning credit from an invoice that should end up in the 'move remaining funds' and the adjustments should be taken into account there. I think that should work right now
This is a much asked for and needed feature - please keep it going! Agreed :-)
Looking at bug 10412: Could we imagine a use case where the credit note is independent from an invoice? I think these achieve similar ends by different means - an invoice with adjustments and no orders seems equivalent to a free standing credit - it seemed logical to have an invoice for any monetary adjustment and if that bug is resurrected it could be done without the option to link to invoices and be compatible with this.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #8 from Colin Campbell <colin.campbell@ptfs-europe.com> --- In an EDI environment credit note messages are a type of invoice message, and we'd have to drive the creation of th Adjustment from there. With that case in mind (but also with manual cases) It would be useful to have a field similar to the invoicenumber in the aqinvoice table to record the suppliers document number (mandatory in edifact where its a max 35 character field) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Jonathan Field <jonathan.field@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66475|0 |1 is obsolete| | Attachment #66476|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67599&action=edit Bug 19166 - Database changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67600&action=edit Bug 19166 - Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct Conflicts: C4/Budgets.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67601&action=edit Bug 19166 - Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67602&action=edit Bug 19166: DO NOT PUSH - Schema updates Included to ease testing :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Colin Campbell from comment #8)
In an EDI environment credit note messages are a type of invoice message, and we'd have to drive the creation of th Adjustment from there. With that case in mind (but also with manual cases) It would be useful to have a field similar to the invoicenumber in the aqinvoice table to record the suppliers document number (mandatory in edifact where its a max 35 character field)
Do you want this field simply added to the DB changes for future use? Does it need to be displayed/editable? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, tests are failing: t/db_dependent/Budgets.t .. 2/145 # Failed test 'total ordered price is 20' # at t/db_dependent/Budgets.t line 475. # got: '26' # expected: '20.000000' t/db_dependent/Budgets.t .. 99/145 # Looks like you failed 1 test of 145. t/db_dependent/Budgets.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/145 subtests Test Summary Report ------------------- t/db_dependent/Budgets.t (Wstat: 256 Tests: 145 Failed: 1) Failed test: 65 Non-zero exit status: 1 Files=1, Tests=145, 4 wallclock secs ( 0.04 usr 0.00 sys + 3.57 cusr 0.36 csys = 3.97 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67601|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67890&action=edit Bug 19166 - Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #16 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I want this so much to work! I've been asked for this many many times! But I got a software error. BIx::Class::Storage::DBI::_dbh_execute(): Table 'koha_master_dev_inlibro.invoice_adjustments' doesn't exist at /inlibro/git/koha-master-dev-inlibro/Koha/Object.pm line 121 Plus the prove -v ... returned red. DBD::mysql::st execute failed: Table 'koha_master_dev_inlibro.invoice_adjustments' doesn't exist [for Statement "SELECT `me`.`adjustment_id`, `me`.`invoiceid`, `me`.`adjustment`, `me`.`reason`, `me`.`note`, `me`.`budget_id`, `me`.`encumber_open`, `me`.`timestamp` FROM `invoice_adjustments` `me` JOIN `aqinvoices` `invoiceid` ON `invoiceid`.`invoiceid` = `me`.`invoiceid` WHERE ( ( `budget_id` = ? AND `closedate` IS NOT NULL ) )" with ParamValues: 0='6'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1765. DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha_master_dev_inlibro.invoice_adjustments' doesn't exist at /inlibro/git/koha-master-dev-inlibro/Koha/Objects.pm line 209 # Looks like your test exited with 255 just after 60. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 85/145 subtests Test Summary Report ------------------- t/db_dependent/Budgets.t (Wstat: 65280 Tests: 60 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 145 tests but ran 60. Files=1, Tests=60, 1 wallclock secs ( 0.02 usr 0.00 sys + 1.49 cusr 0.08 csys = 1.59 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #16)
I want this so much to work! I've been asked for this many many times!
But I got a software error.
BIx::Class::Storage::DBI::_dbh_execute(): Table 'koha_master_dev_inlibro.invoice_adjustments' doesn't exist at /inlibro/git/koha-master-dev-inlibro/Koha/Object.pm line 121
Plus the prove -v ... returned red.
HI Caroline, Did you run the database updates? It looks like the tables introduced in this patchset have not been created. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight@lboro.ac.uk --- Comment #18 from Jon Knight <J.P.Knight@lboro.ac.uk> --- I have applied the database changes on my kohadevbox and I get this from `prove -v t/db_dependent/Budgets.t` (first 128 tests of the 145 are OK, so looks like test 129 is blowing up, so I won't include all the output for brevity here): ok 127 - MoveOrders updated the budget amount with the previous unspent budget (for budget budget_2) ok 128 - MoveOrders updated the budget amount with the previous unspent budget (for budget budget_21) DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT `account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types` (`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `account_offsets` ( `amount`, `debit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=173079442325239000000.000000, 1='1', 2='Manual Debit'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT `account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types` (`type`) ON DELETE CASCADE ON UPDATE CASCADE) at /home/vagrant/kohaclone/Koha/Object.pm line 122 # Looks like your test exited with 255 just after 128. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 17/145 subtests Test Summary Report ------------------- t/db_dependent/Budgets.t (Wstat: 65280 Tests: 128 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 145 tests but ran 128. Files=1, Tests=128, 5 wallclock secs ( 0.04 usr 0.02 sys + 3.98 cusr 0.44 csys = 4.48 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67599|0 |1 is obsolete| | Attachment #67600|0 |1 is obsolete| | Attachment #67602|0 |1 is obsolete| | Attachment #67890|0 |1 is obsolete| | --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70413&action=edit Bug 19166 - Database changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70414&action=edit Bug 19166 - Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct Conflicts: C4/Budgets.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70415&action=edit Bug 19166: DO NOT PUSH - Schema updates Included to ease testing :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70416&action=edit Bug 19166 - Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |victor.grousset@biblibre.co | |m --- Comment #23 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- conflicts ~/d/koha ❯❯❯ git bz apply 19166 Bug 19166 - Add the ability to add adjustments to an invoice 70413 - Bug 19166 - Database changes 70414 - Bug 19166 - Add the ability to add adjustments to an invoice 70415 - Bug 19166: DO NOT PUSH - Schema updates 70416 - Bug 19166 - Unit tests for GetBudgetSpent and GetBudget ordered Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19166 - Database changes Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/kohastructure.sql Applying: Bug 19166 - Add the ability to add adjustments to an invoice Using index info to reconstruct a base tree... M acqui/invoice.pl M acqui/ordered.pl M acqui/spent.pl M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt Auto-merging acqui/spent.pl Auto-merging acqui/ordered.pl Auto-merging acqui/invoice.pl Applying: Bug 19166: DO NOT PUSH - Schema updates Using index info to reconstruct a base tree... M Koha/Schema/Result/Aqbudget.pm M Koha/Schema/Result/Aqinvoice.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/Aqinvoice.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Aqinvoice.pm Auto-merging Koha/Schema/Result/Aqbudget.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Aqbudget.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 19166: DO NOT PUSH - Schema updates The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19166-DO-NOT-PUSH---Schema-updates-Wq9yGZ.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70413|0 |1 is obsolete| | --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72702&action=edit Bug 19166 - Database changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70414|0 |1 is obsolete| | --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72703&action=edit Bug 19166 - Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct Conflicts: C4/Budgets.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70415|0 |1 is obsolete| | --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72704&action=edit Bug 19166: DO NOT PUSH - Schema updates Included to ease testing :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70416|0 |1 is obsolete| | --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72705&action=edit Bug 19166 - Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #28 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I have very strange results on the acqui-home table. I put a order with 2 titles of each 20€ tax excluded with 1.10 GST I received my first title with a shipment cost of 15€ and add a negative adjustement (-10) on this one. When I added the adjustment, I didn't check "Encumber while invoice open" but it was checked when I save it. Adjustements are added to ordered orders but the sums in acqui-home page are wrong. Ordered : 26,10 Title 2 = 21,10 € Adjustement = -10 -> should be 11,10 € Spent : 36,10 Title 1 = 21,10 Shipment cost = 15 ->ok -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72744&action=edit Bug 19116: Get correct value for encumbering when open for new lines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72978&action=edit Bug 19166: (follow-up) Shipment cost is always added to 'spent' Two koha professionals agreed, also it is current behvaiour so this patch removes a change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|victor.grousset@biblibre.co | |m | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #31 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- What is the authorized value category for the "reason" column? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72702|0 |1 is obsolete| | Attachment #72703|0 |1 is obsolete| | Attachment #72704|0 |1 is obsolete| | Attachment #72705|0 |1 is obsolete| | Attachment #72744|0 |1 is obsolete| | Attachment #72978|0 |1 is obsolete| | --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73481&action=edit Bug 19166: Database changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73482&action=edit Bug 19166: Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct Conflicts: C4/Budgets.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73483&action=edit Bug 19166: DO NOT PUSH - Schema updates Included to ease testing :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #35 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73484&action=edit Bug 19166: Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #36 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73485&action=edit Bug 19166: Get correct value for encumbering when open for new lines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73486&action=edit Bug 19166: (follow-up) Shipment cost is always added to 'spent' Two koha professionals agreed, also it is current behvaiour so this patch removes a change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73487&action=edit Bug 19166: (follow-up) Add ADJ_REASON auhtorised value category and minor fixes This patch adds the ADJ_REASON authorised value category tot he atomic update, and fixes code to display a hint of no reasons are defined other minor updates to remove warns in logs To test: Apply patches Run updates Check authorised value categories to see ADJ_REASON exists Add an adjustment, not you have no reaosn drop down Note there is a hint if you hover Add a value to ADJ_REASON add another adjustment, note you can now add reasons (or not) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #31)
What is the authorized value category for the "reason" column?
It is ADJ_REASON - I now add this in the updates and fixed the hint that displays so the user knows where to add reasons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #40 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73481|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73482|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73483|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73484|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73485|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73486|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73487|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #41 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 74742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74742&action=edit Bug 19166: Database changes Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #42 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 74743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74743&action=edit Bug 19166: Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct Conflicts: C4/Budgets.pm Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #43 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 74744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74744&action=edit Bug 19166: DO NOT PUSH - Schema updates Included to ease testing :-) Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #44 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 74745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74745&action=edit Bug 19166: Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #45 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 74746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74746&action=edit Bug 19166: Get correct value for encumbering when open for new lines https://bugs.koha-community.org/show_bug.cgi?id=19166 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #46 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 74747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74747&action=edit Bug 19166: (follow-up) Shipment cost is always added to 'spent' Two koha professionals agreed, also it is current behvaiour so this patch removes a change Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #47 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 74748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74748&action=edit Bug 19166: (follow-up) Add ADJ_REASON auhtorised value category and minor fixes This patch adds the ADJ_REASON authorised value category tot he atomic update, and fixes code to display a hint of no reasons are defined other minor updates to remove warns in logs To test: Apply patches Run updates Check authorised value categories to see ADJ_REASON exists Add an adjustment, not you have no reaosn drop down Note there is a hint if you hover Add a value to ADJ_REASON add another adjustment, note you can now add reasons (or not) Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nick, some complaints in the QA tools, especially this one: FAIL installer/data/mysql/kohastructure.sql FAIL charset_collate The table invoice_adjustments does not have the current charset collate (see bug 18336) OK git manipulation Can you please take a look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74843&action=edit Bug 19166: Correct charset collate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |oleonard@myacpl.org --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nick, The GUI could still needs some improvement, but I think this could be done in a separate bug report, as logic and calculations appear to work ok. Some notes: I'd remove the reason column when the authorised category is not set up with values and remove the 'none' it displays now. Also, you show one line for each adjustment on an invoice in the spent and ordered tables. I'd either summarize them (one line for each invoice) or give more detail (reason and note). For an easier to handle table, maybe 1 is the better option. I'd move the save button from the Invoice closer to the invoice detail box to make it clearer that it only applies to this part of the page. The 2 separate save buttons are not ideal. A long note won't be displayed nicely in the notes field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74742|0 |1 is obsolete| | --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74893&action=edit Bug 19166: Database changes Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74743|0 |1 is obsolete| | --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74894&action=edit Bug 19166: Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct Conflicts: C4/Budgets.pm Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74744|0 |1 is obsolete| | --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74895&action=edit Bug 19166: DO NOT PUSH - Schema updates Included to ease testing :-) Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74745|0 |1 is obsolete| | --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74896&action=edit Bug 19166: Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74746|0 |1 is obsolete| | --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74897&action=edit Bug 19166: Get correct value for encumbering when open for new lines https://bugs.koha-community.org/show_bug.cgi?id=19166 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74747|0 |1 is obsolete| | --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74898&action=edit Bug 19166: (follow-up) Shipment cost is always added to 'spent' Two koha professionals agreed, also it is current behvaiour so this patch removes a change Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74748|0 |1 is obsolete| | --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74899&action=edit Bug 19166: (follow-up) Add ADJ_REASON auhtorised value category and minor fixes This patch adds the ADJ_REASON authorised value category tot he atomic update, and fixes code to display a hint of no reasons are defined other minor updates to remove warns in logs To test: Apply patches Run updates Check authorised value categories to see ADJ_REASON exists Add an adjustment, not you have no reaosn drop down Note there is a hint if you hover Add a value to ADJ_REASON add another adjustment, note you can now add reasons (or not) Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74843|0 |1 is obsolete| | --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74900&action=edit Bug 19166: Correct charset collate Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #60 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75014&action=edit Bug 19166: Follow-up - Reformat the new adjustments markup This follow-up makes some changes to the way invoice adjustments are displayed and added: - Move this section into a <fieldset> to set it off visually from the other sections of the page. - Take the "add adjustment" fields out of the table and display them in a standard way. - Hide the "add adjustment" fields by default, shown via "add an adjustment" link. - Add deletion confirmation to adjustment deletions. To test, add, delete, and change invoice adjustments as instructed in the original test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75014|0 |1 is obsolete| | --- Comment #61 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 75043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75043&action=edit Bug 19166: (follow-up) Reformat the new adjustments markup This follow-up makes some changes to the way invoice adjustments are displayed and added: - Move this section into a <fieldset> to set it off visually from the other sections of the page. - Take the "add adjustment" fields out of the table and display them in a standard way. - Hide the "add adjustment" fields by default, shown via "add an adjustment" link. - Add deletion confirmation to adjustment deletions. To test, add, delete, and change invoice adjustments as instructed in the original test plan. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- QA Comment: Acquisitions is one of the few places where we're fairly consistent with table names (i.e. they have a prepended aq_).. did we want to follow that convention through here too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Encumber is a really odd term.. I'm wondering where it came from.. even as a native english speaker I can't entirely work out what it means in this context. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I take that last comment back.. once I found the right accounting book to read it made a lot more sense.. though I'm not sure how well it translates to credits.. 'encumbered' tends to mean 'committed to paying', but a credit it sorta the opposite. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I agree this should be moved to Koha::Acquisitions::Invoices::Adjustments, InvoiceAdjustments without the prepended Acquisitions could well be confused with Accounts processing in the future... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- When running the QA scripts I'm seeing a number of warnings: Argument "" isn't numeric in numeric gt (>) at /home/martin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt line 85. Argument "" isn't numeric in numeric gt (>) at /home/martin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt line 162. Argument "" isn't numeric in numeric gt (>) at /home/martin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt line 85. Argument "" isn't numeric in numeric gt (>) at /home/martin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt line 103. And also some POD warnings too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Charles Quain <csq@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |csq@interleaf.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74893|0 |1 is obsolete| | Attachment #74894|0 |1 is obsolete| | Attachment #74895|0 |1 is obsolete| | Attachment #74896|0 |1 is obsolete| | Attachment #74897|0 |1 is obsolete| | Attachment #74898|0 |1 is obsolete| | Attachment #74899|0 |1 is obsolete| | Attachment #74900|0 |1 is obsolete| | Attachment #75043|0 |1 is obsolete| | --- Comment #67 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76994&action=edit Bug 19166: Database changes Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76994|0 |1 is obsolete| | --- Comment #68 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76995&action=edit Bug 19166: Database changes Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #69 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76996&action=edit Bug 19166: Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct Conflicts: C4/Budgets.pm Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #70 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76997&action=edit Bug 19166: Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #71 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76998&action=edit Bug 19166: Get correct value for encumbering when open for new lines https://bugs.koha-community.org/show_bug.cgi?id=19166 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #72 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76999&action=edit Bug 19166: (follow-up) Shipment cost is always added to 'spent' Two koha professionals agreed, also it is current behvaiour so this patch removes a change Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #73 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77000&action=edit Bug 19166: (follow-up) Add ADJ_REASON auhtorised value category and minor fixes This patch adds the ADJ_REASON authorised value category tot he atomic update, and fixes code to display a hint of no reasons are defined other minor updates to remove warns in logs To test: Apply patches Run updates Check authorised value categories to see ADJ_REASON exists Add an adjustment, not you have no reaosn drop down Note there is a hint if you hover Add a value to ADJ_REASON add another adjustment, note you can now add reasons (or not) Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #74 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77001&action=edit Bug 19166: Correct charset collate Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #75 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77002&action=edit Bug 19166: (follow-up) Reformat the new adjustments markup This follow-up makes some changes to the way invoice adjustments are displayed and added: - Move this section into a <fieldset> to set it off visually from the other sections of the page. - Take the "add adjustment" fields out of the table and display them in a standard way. - Hide the "add adjustment" fields by default, shown via "add an adjustment" link. - Add deletion confirmation to adjustment deletions. To test, add, delete, and change invoice adjustments as instructed in the original test plan. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #76 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77003&action=edit Bug 19166: (follow-up) Adjust table and files and QA issues Move to aqinvoice_adjustment Move to Koha::Acquisition::Invoice::Adjustments Test if variable exists before count -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #77 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77004&action=edit Bug 19166: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #78 from Nick Clemens <nick@bywatersolutions.com> --- QA tool will warn of deleted/created in same patchset - pfft - can squash on push It also complains of pod on the Schema files - I think is a red herring TT warns cleared -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76995|0 |1 is obsolete| | Attachment #76996|0 |1 is obsolete| | Attachment #76997|0 |1 is obsolete| | Attachment #76998|0 |1 is obsolete| | Attachment #76999|0 |1 is obsolete| | Attachment #77000|0 |1 is obsolete| | Attachment #77001|0 |1 is obsolete| | Attachment #77002|0 |1 is obsolete| | Attachment #77003|0 |1 is obsolete| | Attachment #77004|0 |1 is obsolete| | --- Comment #79 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77104&action=edit Bug 19166: Database changes Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77104|0 |1 is obsolete| | --- Comment #80 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77105&action=edit Bug 19166: Database changes Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #81 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77106&action=edit Bug 19166: Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #82 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77107&action=edit Bug 19166: Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #83 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77108&action=edit Bug 19166: Get correct value for encumbering when open for new lines https://bugs.koha-community.org/show_bug.cgi?id=19166 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #84 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77109&action=edit Bug 19166: (follow-up) Shipment cost is always added to 'spent' Two koha professionals agreed, also it is current behvaiour so this patch removes a change Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #85 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77110&action=edit Bug 19166: (follow-up) Add ADJ_REASON auhtorised value category and minor fixes This patch adds the ADJ_REASON authorised value category tot he atomic update, and fixes code to display a hint of no reasons are defined other minor updates to remove warns in logs To test: Apply patches Run updates Check authorised value categories to see ADJ_REASON exists Add an adjustment, not you have no reaosn drop down Note there is a hint if you hover Add a value to ADJ_REASON add another adjustment, note you can now add reasons (or not) Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #86 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77111&action=edit Bug 19166: Correct charset collate Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #87 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77112&action=edit Bug 19166: (follow-up) Reformat the new adjustments markup This follow-up makes some changes to the way invoice adjustments are displayed and added: - Move this section into a <fieldset> to set it off visually from the other sections of the page. - Take the "add adjustment" fields out of the table and display them in a standard way. - Hide the "add adjustment" fields by default, shown via "add an adjustment" link. - Add deletion confirmation to adjustment deletions. To test, add, delete, and change invoice adjustments as instructed in the original test plan. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #88 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77113&action=edit Bug 19166: (follow-up) Adjust table and files and QA issues Move to aqinvoice_adjustment Move to Koha::Acquisition::Invoice::Adjustments Test if variable exists before count -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #89 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77114&action=edit Bug 19166: DO NOT PUSH Schema updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77105|0 |1 is obsolete| | Attachment #77106|0 |1 is obsolete| | Attachment #77107|0 |1 is obsolete| | Attachment #77108|0 |1 is obsolete| | Attachment #77109|0 |1 is obsolete| | Attachment #77110|0 |1 is obsolete| | Attachment #77111|0 |1 is obsolete| | Attachment #77112|0 |1 is obsolete| | Attachment #77113|0 |1 is obsolete| | Attachment #77114|0 |1 is obsolete| | --- Comment #90 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77115&action=edit Bug 19166: Database changes Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #91 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77116&action=edit Bug 19166: Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #92 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77117&action=edit Bug 19166: Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #93 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77118&action=edit Bug 19166: Get correct value for encumbering when open for new lines https://bugs.koha-community.org/show_bug.cgi?id=19166 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #94 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77119&action=edit Bug 19166: (follow-up) Shipment cost is always added to 'spent' Two koha professionals agreed, also it is current behvaiour so this patch removes a change Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #95 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77120&action=edit Bug 19166: (follow-up) Add ADJ_REASON auhtorised value category and minor fixes This patch adds the ADJ_REASON authorised value category tot he atomic update, and fixes code to display a hint of no reasons are defined other minor updates to remove warns in logs To test: Apply patches Run updates Check authorised value categories to see ADJ_REASON exists Add an adjustment, not you have no reaosn drop down Note there is a hint if you hover Add a value to ADJ_REASON add another adjustment, note you can now add reasons (or not) Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #96 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77121&action=edit Bug 19166: Correct charset collate Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #97 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77122&action=edit Bug 19166: (follow-up) Reformat the new adjustments markup This follow-up makes some changes to the way invoice adjustments are displayed and added: - Move this section into a <fieldset> to set it off visually from the other sections of the page. - Take the "add adjustment" fields out of the table and display them in a standard way. - Hide the "add adjustment" fields by default, shown via "add an adjustment" link. - Add deletion confirmation to adjustment deletions. To test, add, delete, and change invoice adjustments as instructed in the original test plan. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #98 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77123&action=edit Bug 19166: (follow-up) Adjust table and files and QA issues Move to aqinvoice_adjustment Move to Koha::Acquisition::Invoice::Adjustments Test if variable exists before count -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #99 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77124&action=edit Bug 19166: DO NOT PUSH Schema updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77115|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77125&action=edit Bug 19166: Database changes Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77116|0 |1 is obsolete| | --- Comment #101 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77126&action=edit Bug 19166: Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77117|0 |1 is obsolete| | --- Comment #102 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77127&action=edit Bug 19166: Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77118|0 |1 is obsolete| | --- Comment #103 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77128&action=edit Bug 19166: Get correct value for encumbering when open for new lines https://bugs.koha-community.org/show_bug.cgi?id=19166 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77119|0 |1 is obsolete| | --- Comment #104 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77129&action=edit Bug 19166: (follow-up) Shipment cost is always added to 'spent' Two koha professionals agreed, also it is current behvaiour so this patch removes a change Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77120|0 |1 is obsolete| | --- Comment #105 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77130&action=edit Bug 19166: (follow-up) Add ADJ_REASON auhtorised value category and minor fixes This patch adds the ADJ_REASON authorised value category tot he atomic update, and fixes code to display a hint of no reasons are defined other minor updates to remove warns in logs To test: Apply patches Run updates Check authorised value categories to see ADJ_REASON exists Add an adjustment, not you have no reaosn drop down Note there is a hint if you hover Add a value to ADJ_REASON add another adjustment, note you can now add reasons (or not) Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77121|0 |1 is obsolete| | --- Comment #106 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77131&action=edit Bug 19166: Correct charset collate Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77122|0 |1 is obsolete| | --- Comment #107 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77132&action=edit Bug 19166: (follow-up) Reformat the new adjustments markup This follow-up makes some changes to the way invoice adjustments are displayed and added: - Move this section into a <fieldset> to set it off visually from the other sections of the page. - Take the "add adjustment" fields out of the table and display them in a standard way. - Hide the "add adjustment" fields by default, shown via "add an adjustment" link. - Add deletion confirmation to adjustment deletions. To test, add, delete, and change invoice adjustments as instructed in the original test plan. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77123|0 |1 is obsolete| | --- Comment #108 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77133&action=edit Bug 19166: (follow-up) Adjust table and files and QA issues Move to aqinvoice_adjustment Move to Koha::Acquisition::Invoice::Adjustments Test if variable exists before count Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77124|0 |1 is obsolete| | --- Comment #109 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77134&action=edit Bug 19166: DO NOT PUSH Schema updates Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #110 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Code all looks good now, tests all pass and qa script is happy. All my testing seems solid too, passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #111 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #112 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77329&action=edit Bug 19166: Remove 'IF NOT EXISTS' in kohastructure The table is removed just before, this clause is useless. It also fixes a test: t/db_dependent/Creators/Lib.t .. 1/645 # Failed test 'get_table_names return all tables matching' # at t/db_dependent/Creators/Lib.t line 1258. # Structures begin differing at: # $got->[10] = 'aqinvoice_adjustments' # $expected->[10] = 'aqinvoices' # Looks like you failed 1 test of 645. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #113 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master. Gracias, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #114 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #115 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe we could promote this to 'new feature' to hightlight in release notes? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sponsored by San Diego Law |Sponsored by San Diego Law release notes| | | |This enhancement to | |acquisitions allows | |libraries to record | |adjustments to invoices. | |These may be based on | |feedback from a vendor, for | |example, a credit for | |returned books or damaged | |books, or a debit for extra | |service charges etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sponsored by San Diego Law |This enhancement to release notes| |acquisitions allows |This enhancement to |libraries to record |acquisitions allows |adjustments to invoices. |libraries to record |These may be based on |adjustments to invoices. |feedback from a vendor, for |These may be based on |example, a credit for |feedback from a vendor, for |returned books or damaged |example, a credit for |books, or a debit for extra |returned books or damaged |service charges etc. |books, or a debit for extra | |service charges etc. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22110 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110 [Bug 22110] Editing adjustments doesn't work for Currencyformat != US -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 [Bug 25545] Invoice page - Adjustments are not included in the Total + Adjustments + Shipment cost (Column Tax. inc.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com --- Comment #116 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 10412 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34170 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org