[Bug 29768] New: hidepatronname hides guarantor name on borrower edit screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Bug ID: 29768 Summary: hidepatronname hides guarantor name on borrower edit screen Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: bdaeuber@cityoffargo.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The syspref hidepatronname is now hiding the guarantor name on memberentry.pl. This seems like a strange place to enforce that system preference since it's convenient for staff to be able to double check that info when editing patron information and personal information is already showing on that screen. It's not enforced on other patron details screens (such as moremember.pl) and I don't think it should impact patron edit screen either. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |emmi.takkinen@koha-suomi.fi Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 133542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133542&action=edit Bug 29768: Do not hide guarantor name from memberentry.pl Syspref "hidepatronname" currently hides guarantors name on memberentry.pl. This is inconsistent since name isn't hidden e.g. on moremember.pl and staff can already see patrons other personal information during edit. To test: 1) Disable syspref "hidepatronname" 2) Edit guarantee patrons information => Field "Guarantor" only shows guarantors cardnumber (or is empty if guarantor has no cardnumber) 3) Apply patch => Guarantors name is now displayed Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi Depends on| |25879 --- Comment #2 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Regression from bug 25879 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25879 [Bug 25879] Improve display of guarantor information in the patron entry form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- The patch is certainly wanted, however it has a bug, it removes the hyperlink to the guarantor info. I'd say it should be fixed in intranet-tmpl/prog/en/includes/patron-title.inc The hyperlink should be added regardless of the hide_patron_infos_if_needed value. Also, please remove the hide_patron_infos_if_needed=0 parameter completely, since that's the default default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |master --- Comment #4 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Changed the version to master as the bug happens with the latest version as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133542|0 |1 is obsolete| | --- Comment #5 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 133725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133725&action=edit Bug 29768: Do not hide guarantor name from memberentry.pl Syspref "hidepatronname" currently hides guarantors name on memberentry.pl. This is inconsistent since name isn't hidden e.g. on moremember.pl and staff can already see patrons other personal information during edit. To test: 1) Disable syspref "hidepatronname" 2) Edit guarantee patrons information => Field "Guarantor" only shows guarantors cardnumber (or is empty if guarantor has no cardnumber) 3) Apply patch => Guarantors name is now displayed (as a hyperlink) Also confirm hidepatronname still works as expected on other pages (holds table, items detail page etc.). Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Should this patch be back to needs signoff? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Jonathan Druart from comment #6)
Should this patch be back to needs signoff?
Yes it should :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- The bug fix to patron-title.inc misses the closing tag for the link "</a>", thus it produces now invalid HTML. It would make more sense to replace
[%- IF display_patron_name OR display_cardnumber -%]
with
[%- IF can_see_patron_infos -%]
also, that would then allow to get rid of the following block above it:
[%- IF hide_patron_infos_if_needed %] [%# Should only be set if patron is set -%] [%- SET can_see_patron_infos = logged_in_user.can_see_patron_infos( patron ) -%] [%- UNLESS can_see_patron_infos -%] [%- SET display_patron_name = 0 -%] [%- SET display_cardnumber = 0 -%] [%- ELSIF Koha.Preference('HidePatronName') -%] [%- SET display_patron_name = 0 -%] [%- END -%] [%- END -%]
Then similar bugs to miss a closing HTML tag would be avoided as everything would be under one if block. One more thing: could you please provide the bug fix in patron-title.inc in a separate commit so if it is needed to fix some other bug and/or we need to revert the fix you are doing here it would be possible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 --- Comment #9 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Joonas Kylmälä from comment #8)
The bug fix to patron-title.inc misses the closing tag for the link "</a>", thus it produces now invalid HTML.
It would make more sense to replace
[%- IF display_patron_name OR display_cardnumber -%]
with
[%- IF can_see_patron_infos -%]
also, that would then allow to get rid of the following block above it:
[%- IF hide_patron_infos_if_needed %] [%# Should only be set if patron is set -%] [%- SET can_see_patron_infos = logged_in_user.can_see_patron_infos( patron ) -%] [%- UNLESS can_see_patron_infos -%] [%- SET display_patron_name = 0 -%] [%- SET display_cardnumber = 0 -%] [%- ELSIF Koha.Preference('HidePatronName') -%] [%- SET display_patron_name = 0 -%] [%- END -%] [%- END -%]
Then similar bugs to miss a closing HTML tag would be avoided as everything would be under one if block.
One more thing: could you please provide the bug fix in patron-title.inc in a separate commit so if it is needed to fix some other bug and/or we need to revert the fix you are doing here it would be possible.
Weird, patch worked fine even when closing tag was behind
[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%].
And replacing
[%- IF display_patron_name OR display_cardnumber -%]
with
[%- IF can_see_patron_infos -%]
broke it :D so I don't think that's the best approache to this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133725|0 |1 is obsolete| | --- Comment #10 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134806&action=edit Bug 29768: Do not hide guarantor name from memberentry.pl Syspref "hidepatronname" currently hides guarantors name on memberentry.pl. This is inconsistent since name isn't hidden e.g. on moremember.pl and staff can already see patrons other personal information during edit. To test: 1) Disable syspref "hidepatronname" 2) Edit guarantee patrons information => Field "Guarantor" only shows guarantors cardnumber (or is empty if guarantor has no cardnumber) 3) Apply patch => Guarantors name is now displayed (as a hyperlink) Also confirm hidepatronname still works as expected on other pages (holds table, items detail page etc.). Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 --- Comment #11 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134807&action=edit Bug 29768: Fix hyperlink to the guarantor detail page We should display hyperlink to the guarantor detail page regardless of the hide_patron_infos_if_needed value. To test confirm hyperlink in gurarantee edit page to the guarantor detail page works. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- The last patch would break a lot of pages, e.g. see the browser title field after applying the patch. I fix would be to go for now how other pages have handled this: by grepping "patron-title.inc" you can find for examples:
./prog/en/modules/members/accountline-details.tt: <a href="/cgi-bin/koha/members/boraccount.pl?borrowernumber=[% patron.borrowernumber | uri %]">Account for [% INCLUDE 'patron-title.inc' %]</a>
so basically add the link manually around the patron-title.inc include statement. However the ideal solution would be to: 1. Modify the last patch from here to support in addition no_html = 1 parameter correctly in patron-title.inc (the current support is only partly done...) 2. add the no_html = 1 tag to all the places where patron-title.inc is used and it cannot contain a link (for example in a browser title tag or inside another link) If you don't decide to go with the ideal solution then let's open another bug report for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 --- Comment #13 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- err.. (In reply to Joonas Kylmälä from comment #12)
after applying the patch. I fix would be to go for now how other pages have
I fix -> One fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 --- Comment #14 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Joonas Kylmälä from comment #12)
1. Modify the last patch from here to support in addition no_html = 1 parameter correctly in patron-title.inc (the current support is only partly done...)
Hmm, so should there be something like this:
[%- IF !no_html AND ( display_patron_name OR display_cardnumber ) -%]
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 --- Comment #15 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Pyh.. I meant:
[%- IF no_html AND ( display_patron_name OR display_cardnumber ) -%]
not !no_hmtl.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 --- Comment #16 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- (In reply to Emmi Takkinen from comment #14)
(In reply to Joonas Kylmälä from comment #12)
1. Modify the last patch from here to support in addition no_html = 1 parameter correctly in patron-title.inc (the current support is only partly done...)
Hmm, so should there be something like this:
[%- IF !no_html AND ( display_patron_name OR display_cardnumber ) -%]
Yeah, and I think you got the if statement here right. IF no_html==0 basically, I don't quite remember the correct syntax for template toolkit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134806|0 |1 is obsolete| | --- Comment #17 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 139180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139180&action=edit Bug 29768: Do not hide guarantor name from memberentry.pl Syspref "hidepatronname" currently hides guarantors name on memberentry.pl. This is inconsistent since name isn't hidden e.g. on moremember.pl and staff can already see patrons other personal information during edit. To test: 1) Disable syspref "hidepatronname" 2) Edit guarantee patrons information => Field "Guarantor" only shows guarantors cardnumber (or is empty if guarantor has no cardnumber) 3) Apply patch => Guarantors name is now displayed (as a hyperlink) Also confirm hidepatronname still works as expected on other pages (holds table, items detail page etc.). Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134807|0 |1 is obsolete| | --- Comment #18 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 139181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139181&action=edit Bug 29768: Fix patron name displays and hyperlinks Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #19 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- The hyperlink is not shown in the latest patch version, the hide_patron_infos_if_needed check was reintroduced in this version of the patch, it was the one you removed earlier. Also, I'm thinking whether introducing a "no_link" variable or equivalent in addition to the "no_html" would be a good idea? Reading your last patch and patron-title.inc in more detail the patron's title (Mr, Dr, etc.) seems to be enclosed in a span, which would be valid inside hyperlink, however a hyperlink wouldn't be valid inside a hyperlink. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139180|0 |1 is obsolete| | --- Comment #20 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 142606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142606&action=edit Bug 29768: Do not hide guarantor name from memberentry.pl Syspref "hidepatronname" currently hides guarantors name on memberentry.pl. This is inconsistent since name isn't hidden e.g. on moremember.pl and staff can already see patrons other personal information during edit. To test: 1) Disable syspref "hidepatronname" 2) Edit guarantee patrons information => Field "Guarantor" only shows guarantors cardnumber (or is empty if guarantor has no cardnumber) 3) Apply patch => Guarantors name is now displayed (as a hyperlink) Also confirm hidepatronname still works as expected on other pages (holds table, items detail page etc.). Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139181|0 |1 is obsolete| | --- Comment #21 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 142607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142607&action=edit Bug 29768: Fix patron name displays and hyperlinks Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #22 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Joonas Kylmälä from comment #19)
The hyperlink is not shown in the latest patch version, the hide_patron_infos_if_needed check was reintroduced in this version of the patch, it was the one you removed earlier.
So it seems (how on earth it got there?), removed it again in latest patch.
Also, I'm thinking whether introducing a "no_link" variable or equivalent in addition to the "no_html" would be a good idea? Reading your last patch and patron-title.inc in more detail the patron's title (Mr, Dr, etc.) seems to be enclosed in a span, which would be valid inside hyperlink, however a hyperlink wouldn't be valid inside a hyperlink.
Hmm, I guess this could be useful. Feel free to add it if you have some sort idea how to implement it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks like second patch is on a bit different and complex issue. Maybe this report can deal with guarantor name only and create a new bug report for second patch, with a test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 --- Comment #24 from Fridolin Somers <fridolin.somers@biblibre.com> --- I've looked at code and tested. This causes a problem when syspref "HidePatronName" is "Show" and logged in staff user does not have permission "view_borrower_infos_from_any_libraries". When guarantor is from another library, it is displayed where it should not.* When syspref "HidePatronName" is "Don't show" only the cardnumber is shown which is odd. I think IF/ELSIF confidations should be revamped in patron-title.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 solene.ngamga@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |solene.ngamga@inlibro.com --- Comment #25 from solene.ngamga@inlibro.com --- I can't reproduce the problem. When I follow the steps, in step 2, I already get a hyperlink for the guarantor when I add it. The guarantor name is displayed (as a hyperlink) as desired in step 3. I did not need to apply the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 solene.ngamga@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 solene.ngamga@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142607|0 |1 is obsolete| | --- Comment #26 from solene.ngamga@inlibro.com --- Created attachment 145220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145220&action=edit Bug 29768: Fix patron name displays and hyperlinks Sponsored-by: Koha-Suomi Oy Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 --- Comment #27 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Hmm, I'm bit confused here. Is status of this "Failed QA" or "Patch doesn't apply" or even "RESOLVED INVALID"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 --- Comment #28 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to solene.ngamga from comment #25)
I can't reproduce the problem.
When I follow the steps, in step 2, I already get a hyperlink for the guarantor when I add it. The guarantor name is displayed (as a hyperlink) as desired in step 3. I did not need to apply the patch.
It does seem that second patch is mostly useless. Only part still valid is changes made to patron-title.inc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED --- Comment #29 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Looking this again and trying to figure out a simpler solution to original problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 --- Comment #30 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- As far as I can tell there isn't any simpler way to fix this. Althought, this could be probably also fixed with this line: [%- IF ( !no_html OR hide_patron_infos_if_needed ) AND ( display_patron_name OR display_cardnumber ) -%] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142606|0 |1 is obsolete| | Attachment #145220|0 |1 is obsolete| | --- Comment #31 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 188466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188466&action=edit Bug 29768: Do not hide guarantor name from memberentry.pl Syspref "hidepatronname" currently hides guarantors name on memberentry.pl. This is inconsistent since name isn't hidden e.g. on moremember.pl and staff can already see patrons other personal information during edit. To test: 1) Disable syspref "hidepatronname" 2) Edit guarantee patrons information => Field "Guarantor" only shows guarantors cardnumber (or is empty if guarantor has no cardnumber) 3) Apply patch => Guarantors name is now displayed (as a hyperlink) Also confirm hidepatronname still works as expected on other pages (holds table, items detail page etc.). Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #32 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Cleaned up patches and them in one patch. Links to patron should now work as expected and guarantor without cardnumber is displayed in guarantees mod page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188466|0 |1 is obsolete| | --- Comment #33 from David Nind <david@davidnind.com> --- Created attachment 190805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190805&action=edit Bug 29768: Do not hide guarantor name from memberentry.pl Syspref "hidepatronname" currently hides guarantors name on memberentry.pl. This is inconsistent since name isn't hidden e.g. on moremember.pl and staff can already see patrons other personal information during edit. To test: 1) Disable syspref "hidepatronname" 2) Edit guarantee patrons information => Field "Guarantor" only shows guarantors cardnumber (or is empty if guarantor has no cardnumber) 3) Apply patch => Guarantors name is now displayed (as a hyperlink) Also confirm hidepatronname still works as expected on other pages (holds table, items detail page etc.). Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |If the `hidepatronname` release notes| |system preference was set | |to "Don't show" it hid the | |guarantor's name when: | |- editing the guarantee's | |patron record (it shows the | |guarantor patron's card | |number) | |- viewing the guarantee | |patron's details page | | | |With this change, you can | |now see the guarantor's | |name in these areas. | | | |As this information is | |viewable by clicking the | |card number, it doesn't | |make much sense to hide the | |patron name for guarantors | |and guarantees. --- Comment #34 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Add a guarantor to a patron: I added Mary Burton as a guarantor to Lisa Charles. 2. Not sure how to test with a patron that does not have a card number, as this is a mandatory field for patrons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190805|0 |1 is obsolete| | --- Comment #35 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 192241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192241&action=edit Bug 29768: Do not hide guarantor name from memberentry.pl Syspref "hidepatronname" currently hides guarantors name on memberentry.pl. This is inconsistent since name isn't hidden e.g. on moremember.pl and staff can already see patrons other personal information during edit. To test: 1) Disable syspref "hidepatronname" 2) Edit guarantee patrons information => Field "Guarantor" only shows guarantors cardnumber (or is empty if guarantor has no cardnumber) 3) Apply patch => Guarantors name is now displayed (as a hyperlink) Also confirm hidepatronname still works as expected on other pages (holds table, items detail page etc.). Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 --- Comment #36 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 --- Comment #37 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org