[Bug 22249] New: Error when submitting Mana comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Bug ID: 22249 Summary: Error when submitting Mana comment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: koha-bugs@lists.koha-community.org, testopia@bugs.koha-community.org Depends on: 17047 Target Milestone: --- When I submit a Mana comment on a subscription the process completes successfully but in the console this error is returned: Can't locate object method "find" via package "Koha::Resource_comments" (perhaps you forgot to load "Koha::Resource_comments"?) at /home/vagrant/kohaclone/Koha/SharedContent.pm line 89. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Bug 22249 depends on bug 17047, which changed state. Bug 17047 Summary: Mana Knowledge Base : share data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|normal |major Keywords| |rel_19_05_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight@lboro.ac.uk --- Comment #1 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Not tackling the cause of this directly (ie why is it requesting a module that doesn't exist and hasn't be loaded into the code) but what about having something like this before line 89: my $loaded = $packages->VERSION; if(!$loaded) { eval('use '.$packages); if(!$packages->VERSION) { warn "Can't load package $packages: $!\n"; } } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jon Knight from comment #1)
Not tackling the cause of this directly (ie why is it requesting a module that doesn't exist and hasn't be loaded into the code) but what about having something like this before line 89:
my $loaded = $packages->VERSION; if(!$loaded) { eval('use '.$packages); if(!$packages->VERSION) { warn "Can't load package $packages: $!\n"; } }
We usually use Module::Load::Conditional, but yes it is the same idea. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 --- Comment #3 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 90379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90379&action=edit Bug 22249: Mana - Move comment process in a dedicated sub https://bugs.koha-community.org/show_bug.cgi?id=22259 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90379|0 |1 is obsolete| | --- Comment #4 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 90380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90380&action=edit Bug 22249: Mana - Move comment process in a dedicated sub -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #5 from Michal Denar <black23@gmail.com> --- Hi Alex, any test plan? Thank You. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90380|0 |1 is obsolete| | --- Comment #6 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 90917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90917&action=edit Bug 22249: Mana - Move comment process in a dedicated sub Test plan: - Go to a subscription's detail page, - click on "Report mistake" => "New comment", - check Koha logs file, - you can see the following warning: Can't locate object method "find" via package "Koha::Resource_comments" - Apply this patch, - same test again, - no wraning -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 --- Comment #7 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Michal Denar from comment #5)
Hi Alex, any test plan?
Thank You.
Hello Michal, Just added that in the commit message. Thx! -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 --- Comment #8 from Alex Arnaud <alex.arnaud@biblibre.com> --- Kyle, Patch rebased. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90917|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 90941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90941&action=edit Bug 22249: Mana - Move comment process in a dedicated sub Test plan: - Go to a subscription's detail page, - click on "Report mistake" => "New comment", - check Koha logs file, - you can see the following warning: Can't locate object method "find" via package "Koha::Resource_comments" - Apply this patch, - same test again, - no wraning Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90941|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91798&action=edit Bug 22249: Mana - Move comment process in a dedicated sub Test plan: - Go to a subscription's detail page, - click on "Report mistake" => "New comment", - check Koha logs file, - you can see the following warning: Can't locate object method "find" via package "Koha::Resource_comments" - Apply this patch, - same test again, - no wraning Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.03 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependency for 18.11.x, no backport -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org