https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22950 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89945&action=edit Bug 22950: Markup error in OPAC recent comment template This patch makes minor corrections to the template for the OPAC's recent comments view. These corrections fix errors returned by the HTML validator. The patch moves some inline CSS into a class in the global OPAC CSS. Some minor reindentation has also been done, so use diff with the '-w' flag. To reproduce the problem you should have the 'reviewson' system preference turned on, and your system should have one or more approved comments. View the "Recent comments" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "CSS: font-color: Property font-color doesn't exist." To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22950 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89945|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 90075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90075&action=edit Bug 22950: Markup error in OPAC recent comment template This patch makes minor corrections to the template for the OPAC's recent comments view. These corrections fix errors returned by the HTML validator. The patch moves some inline CSS into a class in the global OPAC CSS. Some minor reindentation has also been done, so use diff with the '-w' flag. To reproduce the problem you should have the 'reviewson' system preference turned on, and your system should have one or more approved comments. View the "Recent comments" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "CSS: font-color: Property font-color doesn't exist." To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22950 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22950 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22950 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes.