[Bug 12648] New: Link an order with patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Bug ID: 12648 Summary: Link an order with patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org A need is to notify 1+ patrons on receiving an order. As baskets, we could link patrons to an order and send them an email when the order is completely received. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Link an order with patrons |Link patrons to an order -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30024&action=edit Bug 12648: Link patrons to an order - DB changes This patch inserts the new notification template into the letters table. It also add the insert statements into the language specific files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30025&action=edit Bug 12648: Refactoring to prepare user search for reuse A previous enhancement allows to link basket with patrons. Next patches will use the same way to link order with patrons. In order to avoir c/p of code, this patch refactores this part of code. Test plan: 1/ Verify there is no regression on adding/modifying users to a basket. (acqui/basket.pl?basketno=XXX, "Managed by", "Add user"). 2/ Note that you get a friendly message if the user is already present in the list and when the user has correctly been added to the list. 3/ Note that the list uses the member search service (ie. DataTable + serverside processing). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30026&action=edit Bug 12648: Link patrons to an order This patch is the main patch. This feature adds the ability to link patrons to an order. On that way, they will be notified when the order is completely received. Test plan: 1/ Execute the updatedb entry and verify you have a new notification template in your table (tools/letter.pl). code: ACQ_NOTIF_ON_RECEIV, module: acquisition 2/ You can edit it if you want 3/ Create a basket and create an order with 1 or more items 4/ Link 1+ patrons to this order 5/ Close the basket and receive the order 6/ When you have received all items for this order, all patrons attached will be notified. Check the message_queue table to check if the letters have correctly been added to the queue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30027&action=edit Bug 12648: Add unit tests for C4::Acquisition::*OrderUsers Test plan: Verify that unit tests pass with prove t/db_dependent/Acquisition/OrderUsers.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi@cineca.it --- Comment #5 from Paola Rossi <paola.rossi@cineca.it> --- I've applied the patches against master 3.17.00.013. On adding/modifying users to a basket (acqui/basket.pl?basketno=XXX, "Managed by", "Add user"), the Search-for-patrons' Processing [opened in a new window] stops. On the contrary, on Patron module the patrons' searching is ok. On log I see: search: Template process failed: file error - .../koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt: not found at .../C4/Templates.pm line 131 So I pass the patch to "Failed QA" status. The first patch "Link patrons to an order - DB changes" needs to be rebased. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30024|0 |1 is obsolete| | Attachment #30025|0 |1 is obsolete| | Attachment #30026|0 |1 is obsolete| | Attachment #30027|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30988&action=edit Bug 12648: Link patrons to an order - DB changes This patch inserts the new notification template into the letters table. It also add the insert statements into the language specific files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30989&action=edit Bug 12648: Refactoring to prepare user search for reuse A previous enhancement allows to link basket with patrons. Next patches will use the same way to link order with patrons. In order to avoir c/p of code, this patch refactores this part of code. Test plan: 1/ Verify there is no regression on adding/modifying users to a basket. (acqui/basket.pl?basketno=XXX, "Managed by", "Add user"). 2/ Note that you get a friendly message if the user is already present in the list and when the user has correctly been added to the list. 3/ Note that the list uses the member search service (ie. DataTable + serverside processing). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30990&action=edit Bug 12648: Link patrons to an order This patch is the main patch. This feature adds the ability to link patrons to an order. On that way, they will be notified when the order is completely received. Test plan: 1/ Execute the updatedb entry and verify you have a new notification template in your table (tools/letter.pl). code: ACQ_NOTIF_ON_RECEIV, module: acquisition 2/ You can edit it if you want 3/ Create a basket and create an order with 1 or more items 4/ Link 1+ patrons to this order 5/ Close the basket and receive the order 6/ When you have received all items for this order, all patrons attached will be notified. Check the message_queue table to check if the letters have correctly been added to the queue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30991&action=edit Bug 12648: Add unit tests for C4::Acquisition::*OrderUsers Test plan: Verify that unit tests pass with prove t/db_dependent/Acquisition/OrderUsers.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #5)
On log I see: search: Template process failed: file error - .../koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt: not found at .../C4/Templates.pm line 131
I forgot to add 1 file :-/ Should be fixed now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Paola Rossi <paola.rossi@cineca.it> --- Thanks, Jonathan. I've applied the patches against master 3.17.00.016. [The first patch needs to be rebased] On the patrons' search window I read: "Search for patron: Only staff with superlibrarian or acquisitions permissions (or order_manage permission if granular permissions are enabled) are returned in the search results". But some of the listed patrons are students, and so on. I add a new patron, student category, with no permission. On adding/modifying users to a basket, I can link this student to the basket. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31273&action=edit Bug 12648: The users added to basket should have a permission Before this enh, the users to add to a basket should have the acquisition.order_manage permission. This patch reintroduces this behavior. The code in acqui/add_user_search.pl was never used. The filter should be done in the members/search service. But it is not possible easily to filter using a sql query, so the filter is done after. This means that we cannot use the DT pagination (otherwise the results will become inconsistent). Test plan: 1/ On adding patrons to a basket, verify that the search patron results contain patron with the acquisition.order_manage permission. 2/ Verify that all patrons are return on the 'normal' patron search and when adding patrons to an order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #11)
[The first patch needs to be rebased]
It's a trivial rebase.
On the patrons' search window I read: "Search for patron: Only staff with superlibrarian or acquisitions permissions (or order_manage permission if granular permissions are enabled) are returned in the search results".
But some of the listed patrons are students, and so on.
Yes, previous patches pretend to do the job but actually not at all. This last patch does it, but it's not smartly. Note for QA: I know this last patch is not the better way to do, but I don't have any other idea. Please let me know if you find another easy way to do the same job. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Depends on| |12833 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Bug 12833 breaks this enh. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31960&action=edit Bug 12648: Fix conflict with bug 12833 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31961&action=edit Bug 12648: Hide the result search on load When no search has been done yet, it's not necessary to display the result list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12633 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13021 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13021 Depends on|13021 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 32230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32230&action=edit Bug 12648: The patron's name should be the same as before The displayed patron's name should be surname + firstname -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from Paola Rossi <paola.rossi@cineca.it> --- I've applied the 8 patches against master 3.17.00.027 [The first patch needs trivial rebase] perl t/db_dependent/Acquisition/OrderUsers.t 1..3 not ok 1 - ModOrderUsers should link patrons to an order # Failed test 'ModOrderUsers should link patrons to an order' # at t/db_dependent/Acquisition/OrderUsers.t line 76. # got: '0' # expected: '1' Use of uninitialized value in numeric gt (>) at /var/root-koha/bug-7162/C4/Acquisition.pm line 1511. ok 2 - The letter has not been sent to message queue on receiving the order, the order is not entire received Use of uninitialized value in numeric gt (>) at /var/root-koha/bug-7162/C4/Acquisition.pm line 1511. not ok 3 - The letter has been sent to message queue on receiving the order # Failed test 'The letter has been sent to message queue on receiving the order' # at t/db_dependent/Acquisition/OrderUsers.t line 108. # got: '0' # expected: '1' # Looks like you failed 2 tests of 3. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30988|0 |1 is obsolete| | Attachment #30989|0 |1 is obsolete| | Attachment #30990|0 |1 is obsolete| | Attachment #30991|0 |1 is obsolete| | Attachment #31273|0 |1 is obsolete| | Attachment #31960|0 |1 is obsolete| | Attachment #31961|0 |1 is obsolete| | Attachment #32230|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33186&action=edit Bug 12648: Link patrons to an order - DB changes This patch inserts the new notification template into the letters table. It also add the insert statements into the language specific files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33187&action=edit Bug 12648: Refactoring to prepare user search for reuse A previous enhancement allows to link basket with patrons. Next patches will use the same way to link order with patrons. In order to avoir c/p of code, this patch refactores this part of code. Test plan: 1/ Verify there is no regression on adding/modifying users to a basket. (acqui/basket.pl?basketno=XXX, "Managed by", "Add user"). 2/ Note that you get a friendly message if the user is already present in the list and when the user has correctly been added to the list. 3/ Note that the list uses the member search service (ie. DataTable + serverside processing). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33188&action=edit Bug 12648: Link patrons to an order This patch is the main patch. This feature adds the ability to link patrons to an order. On that way, they will be notified when the order is completely received. Test plan: 1/ Execute the updatedb entry and verify you have a new notification template in your table (tools/letter.pl). code: ACQ_NOTIF_ON_RECEIV, module: acquisition 2/ You can edit it if you want 3/ Create a basket and create an order with 1 or more items 4/ Link 1+ patrons to this order 5/ Close the basket and receive the order 6/ When you have received all items for this order, all patrons attached will be notified. Check the message_queue table to check if the letters have correctly been added to the queue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33189&action=edit Bug 12648: Add unit tests for C4::Acquisition::*OrderUsers Test plan: Verify that unit tests pass with prove t/db_dependent/Acquisition/OrderUsers.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33190&action=edit Bug 12648: The users added to basket should have a permission Before this enh, the users to add to a basket should have the acquisition.order_manage permission. This patch reintroduces this behavior. The code in acqui/add_user_search.pl was never used. The filter should be done in the members/search service. But it is not possible easily to filter using a sql query, so the filter is done after. This means that we cannot use the DT pagination (otherwise the results will become inconsistent). Test plan: 1/ On adding patrons to a basket, verify that the search patron results contain patron with the acquisition.order_manage permission. 2/ Verify that all patrons are return on the 'normal' patron search and when adding patrons to an order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33191&action=edit Bug 12648: Fix conflict with bug 12833 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33192&action=edit Bug 12648: Hide the result search on load When no search has been done yet, it's not necessary to display the result list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #26 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33193&action=edit Bug 12648: The patron's name should be the same as before The displayed patron's name should be surname + firstname -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #18)
# Looks like you failed 2 tests of 3.
I don't get these failures, could you please retest with this new rebased patch set? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #28 from Paola Rossi <paola.rossi@cineca.it> --- I've tried to apply the patches agaist master 3.19.00.000 [The first patch needed a trivial rebase.] At the six-th patch: Applying: Bug 12648: Fix conflict with bug 12833 fatal: sha1 information is lacking or useless (svc/members/search). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12648: Fix conflict with bug 12833 So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33186|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34224&action=edit Bug 12648: Link patrons to an order - DB changes This patch inserts the new notification template into the letters table. It also add the insert statements into the language specific files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33187|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34225&action=edit Bug 12648: Refactoring to prepare user search for reuse A previous enhancement allows to link basket with patrons. Next patches will use the same way to link order with patrons. In order to avoir c/p of code, this patch refactores this part of code. Test plan: 1/ Verify there is no regression on adding/modifying users to a basket. (acqui/basket.pl?basketno=XXX, "Managed by", "Add user"). 2/ Note that you get a friendly message if the user is already present in the list and when the user has correctly been added to the list. 3/ Note that the list uses the member search service (ie. DataTable + serverside processing). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33188|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34226&action=edit Bug 12648: Link patrons to an order This patch is the main patch. This feature adds the ability to link patrons to an order. On that way, they will be notified when the order is completely received. Test plan: 1/ Execute the updatedb entry and verify you have a new notification template in your table (tools/letter.pl). code: ACQ_NOTIF_ON_RECEIV, module: acquisition 2/ You can edit it if you want 3/ Create a basket and create an order with 1 or more items 4/ Link 1+ patrons to this order 5/ Close the basket and receive the order 6/ When you have received all items for this order, all patrons attached will be notified. Check the message_queue table to check if the letters have correctly been added to the queue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33189|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34227&action=edit Bug 12648: Add unit tests for C4::Acquisition::*OrderUsers Test plan: Verify that unit tests pass with prove t/db_dependent/Acquisition/OrderUsers.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33190|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34228&action=edit Bug 12648: The users added to basket should have a permission Before this enh, the users to add to a basket should have the acquisition.order_manage permission. This patch reintroduces this behavior. The code in acqui/add_user_search.pl was never used. The filter should be done in the members/search service. But it is not possible easily to filter using a sql query, so the filter is done after. This means that we cannot use the DT pagination (otherwise the results will become inconsistent). Test plan: 1/ On adding patrons to a basket, verify that the search patron results contain patron with the acquisition.order_manage permission. 2/ Verify that all patrons are return on the 'normal' patron search and when adding patrons to an order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33191|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34229&action=edit Bug 12648: Fix conflict with bug 12833 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33192|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34230&action=edit Bug 12648: Hide the result search on load When no search has been done yet, it's not necessary to display the result list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33193|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34231&action=edit Bug 12648: The patron's name should be the same as before The displayed patron's name should be surname + firstname -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #37 from Jonathan Druart <jonathan.druart@biblibre.com> --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #38 from Paola Rossi <paola.rossi@cineca.it> --- I've applied the patches against master 3.19.00.000 About :
Test plan: 1/ Execute the updatedb entry and verify you have a new notification template in your table (tools/letter.pl). code: ACQ_NOTIF_ON_RECEIV, module: acquisition
I saw that the module is acquisition, OK
2/ You can edit it if you want
I saw that the "Koha module" is "Catalog" ERROR, while "Acquisition" is not an available option in the drop down list. On MASTER, in effect, the available modules are 8, and none of them is "Acquisition". So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #39 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34477&action=edit Bug 12648: Add the new 'Acquisition' entry in the letter module list -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #40 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #38)
2/ You can edit it if you want
I saw that the "Koha module" is "Catalog" ERROR, while "Acquisition" is not an available option in the drop down list.
On MASTER, in effect, the available modules are 8, and none of them is "Acquisition".
So I pass the patch to "Failed QA" status.
Sorry about that. It should be fixed now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34224|0 |1 is obsolete| | --- Comment #41 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34487&action=edit Bug 12648: Link patrons to an order - DB changes Thanks, Jonathan. I've applied the patches against master 3.19.00.000 IMO everything is OK as required. So I pass the patch to "Signed Off" status. Only [certain] staff patrons could be linked to a basket, whilest patrons of all categories could be linked to an order. When the pop-up to "Add users" was opened, no user was shown [OK] as required. And then, if I submitted with no search value, all the [allowed] users were listed [OK]. Newing [or modifying] an order, in "Patrons" tag, next to "To notify on reveiving:", I saw firstname + surname of the added users [OK]. In the message_queue records, in "content" field, I see "Dear firstname + surname ..." [OK]. In the patrons' list, I see "surname, firstname" datas in "Name" column [OK]. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34225|0 |1 is obsolete| | --- Comment #42 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34488&action=edit Bug 12648: Refactoring to prepare user search for reuse -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34226|0 |1 is obsolete| | --- Comment #43 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34489&action=edit Bug 12648: Link patrons to an order -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34227|0 |1 is obsolete| | --- Comment #44 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34490&action=edit Bug 12648: Add unit tests for C4::Acquisition::*OrderUsers -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34228|0 |1 is obsolete| | --- Comment #45 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34491&action=edit Bug 12648: The users added to basket should have a permission -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34229|0 |1 is obsolete| | --- Comment #46 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34492&action=edit Bug 12648: Fix conflict with bug 12833 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34230|0 |1 is obsolete| | --- Comment #47 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34493&action=edit Bug 12648: Hide the result search on load -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34231|0 |1 is obsolete| | --- Comment #48 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34494&action=edit Bug 12648: The patron's name should be the same as before -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34477|0 |1 is obsolete| | --- Comment #49 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34495&action=edit Bug 12648: Add the new 'Acquisition' entry in the letter module list -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34487|0 |1 is obsolete| | Attachment #34488|0 |1 is obsolete| | Attachment #34489|0 |1 is obsolete| | Attachment #34490|0 |1 is obsolete| | Attachment #34491|0 |1 is obsolete| | Attachment #34492|0 |1 is obsolete| | Attachment #34493|0 |1 is obsolete| | Attachment #34494|0 |1 is obsolete| | Attachment #34495|0 |1 is obsolete| | --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35056&action=edit [PASSED QA] Bug 12648: Link patrons to an order This patch is the main patch. This feature adds the ability to link patrons to an order. On that way, they will be notified when the order is completely received. Test plan: 1/ Execute the updatedb entry and verify you have a new notification template in your table (tools/letter.pl). code: ACQ_NOTIF_ON_RECEIV, module: acquisition 2/ You can edit it if you want 3/ Create a basket and create an order with 1 or more items 4/ Link 1+ patrons to this order 5/ Close the basket and receive the order 6/ When you have received all items for this order, all patrons attached will be notified. Check the message_queue table to check if the letters have correctly been added to the queue. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35056|0 |1 is obsolete| | --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35058&action=edit [PASSED QA] Bug 12648: Link patrons to an order This patch is the main patch. This feature adds the ability to link patrons to an order. On that way, they will be notified when the order is completely received. Test plan: 1/ Execute the updatedb entry and verify you have a new notification template in your table (tools/letter.pl). code: ACQ_NOTIF_ON_RECEIV, module: acquisition 2/ You can edit it if you want 3/ Create a basket and create an order with 1 or more items 4/ Link 1+ patrons to this order 5/ Close the basket and receive the order 6/ When you have received all items for this order, all patrons attached will be notified. Check the message_queue table to check if the letters have correctly been added to the queue. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35058|0 |1 is obsolete| | --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35059&action=edit [PASSED QA] Bug 12648: Link patrons to an order This patch is the main patch. This feature adds the ability to link patrons to an order. On that way, they will be notified when the order is completely received. Test plan: 1/ Execute the updatedb entry and verify you have a new notification template in your table (tools/letter.pl). code: ACQ_NOTIF_ON_RECEIV, module: acquisition 2/ You can edit it if you want 3/ Create a basket and create an order with 1 or more items 4/ Link 1+ patrons to this order 5/ Close the basket and receive the order 6/ When you have received all items for this order, all patrons attached will be notified. Check the message_queue table to check if the letters have correctly been added to the queue. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35060&action=edit [PASSED QA] Bug 12648: Add unit tests for C4::Acquisition::*OrderUsers Test plan: Verify that unit tests pass with prove t/db_dependent/Acquisition/OrderUsers.t Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #54 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35061&action=edit [PASSED QA] Bug 12648: The users added to basket should have a permission Before this enh, the users to add to a basket should have the acquisition.order_manage permission. This patch reintroduces this behavior. The code in acqui/add_user_search.pl was never used. The filter should be done in the members/search service. But it is not possible easily to filter using a sql query, so the filter is done after. This means that we cannot use the DT pagination (otherwise the results will become inconsistent). Test plan: 1/ On adding patrons to a basket, verify that the search patron results contain patron with the acquisition.order_manage permission. 2/ Verify that all patrons are return on the 'normal' patron search and when adding patrons to an order. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35062&action=edit [PASSED QA] Bug 12648: Fix conflict with bug 12833 Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #56 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35063&action=edit [PASSED QA] Bug 12648: Hide the result search on load When no search has been done yet, it's not necessary to display the result list. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35064&action=edit [PASSED QA] Bug 12648: The patron's name should be the same as before The displayed patron's name should be surname + firstname Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #58 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35065&action=edit [PASSED QA] Bug 12648: Add the new 'Acquisition' entry in the letter module list Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35066&action=edit Bug 12648 - QA Followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like this! Should we add a default letter (separate bug)? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34487|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #61 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #60)
I like this! Should we add a default letter (separate bug)?
The patch existed but it has been obsoleted (certainly a mistake). I reintroduced it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34488|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #62 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Jonathan, I like the patch set, but there are two minor things remaining: - Missing the kohastructure.sql addition - We should really stick with the adopted naming schema for tables. Even if it will not be consistent with the current table names for acquisitions (we should, at some point just rename them). I would accept 'aqorder_users', but the ideal one would be 'aquisition_order_users', that would map to Koha::Acquisition::Order::Users. I'm open to discussing the naming schema and I know this bug has been here before the guidelines have been accepted. It is just a minor refactoring that i will accept as PASSED-QA. Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34487|0 |1 is obsolete| | Attachment #34488|0 |1 is obsolete| | Attachment #35059|0 |1 is obsolete| | Attachment #35060|0 |1 is obsolete| | Attachment #35061|0 |1 is obsolete| | Attachment #35062|0 |1 is obsolete| | Attachment #35063|0 |1 is obsolete| | Attachment #35064|0 |1 is obsolete| | Attachment #35065|0 |1 is obsolete| | Attachment #35066|0 |1 is obsolete| | --- Comment #63 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36795&action=edit Bug 12648: Link patrons to an order - DB changes This patch inserts the new notification template into the letters table. It also add the insert statements into the language specific files. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Amended patch: Add the kohastructure.sql changes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #64 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36796&action=edit Bug 12648: Refactoring to prepare user search for reuse A previous enhancement allows to link basket with patrons. Next patches will use the same way to link order with patrons. In order to avoir c/p of code, this patch refactores this part of code. Test plan: 1/ Verify there is no regression on adding/modifying users to a basket. (acqui/basket.pl?basketno=XXX, "Managed by", "Add user"). 2/ Note that you get a friendly message if the user is already present in the list and when the user has correctly been added to the list. 3/ Note that the list uses the member search service (ie. DataTable + serverside processing). Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #65 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36797&action=edit Bug 12648: Link patrons to an order This patch is the main patch. This feature adds the ability to link patrons to an order. On that way, they will be notified when the order is completely received. Test plan: 1/ Execute the updatedb entry and verify you have a new notification template in your table (tools/letter.pl). code: ACQ_NOTIF_ON_RECEIV, module: acquisition 2/ You can edit it if you want 3/ Create a basket and create an order with 1 or more items 4/ Link 1+ patrons to this order 5/ Close the basket and receive the order 6/ When you have received all items for this order, all patrons attached will be notified. Check the message_queue table to check if the letters have correctly been added to the queue. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #66 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36798&action=edit Bug 12648: Add unit tests for C4::Acquisition::*OrderUsers Test plan: Verify that unit tests pass with prove t/db_dependent/Acquisition/OrderUsers.t Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #67 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36799&action=edit Bug 12648: The users added to basket should have a permission Before this enh, the users to add to a basket should have the acquisition.order_manage permission. This patch reintroduces this behavior. The code in acqui/add_user_search.pl was never used. The filter should be done in the members/search service. But it is not possible easily to filter using a sql query, so the filter is done after. This means that we cannot use the DT pagination (otherwise the results will become inconsistent). Test plan: 1/ On adding patrons to a basket, verify that the search patron results contain patron with the acquisition.order_manage permission. 2/ Verify that all patrons are return on the 'normal' patron search and when adding patrons to an order. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #68 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36800&action=edit Bug 12648: Fix conflict with bug 12833 Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #69 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36801&action=edit Bug 12648: Hide the result search on load When no search has been done yet, it's not necessary to display the result list. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #70 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36802&action=edit Bug 12648: The patron's name should be the same as before The displayed patron's name should be surname + firstname Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #71 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36803&action=edit Bug 12648: Add the new 'Acquisition' entry in the letter module list Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #72 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36804&action=edit Bug 12648 - QA Followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #73 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36805&action=edit Bug 12648: Rename aqorderusers to aqorder_users -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #74 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Tomás Cohen Arazi from comment #62)
- Missing the kohastructure.sql addition
First patch amended.
- We should really stick with the adopted naming schema for tables. Even if it will not be consistent with the current table names for acquisitions (we should, at some point just rename them).
I would accept 'aqorder_users', but the ideal one would be 'aquisition_order_users', that would map to Koha::Acquisition::Order::Users.
aqorderusers replaced with aqorders_users in the last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #75 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 36807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36807&action=edit Bug 12648: (RM followup) DBIx schema update Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #76 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36810&action=edit Bug 12648: Fix conflict with bug 8096 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #77 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 36817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36817&action=edit Bug 12648: Add some documentation on the kohastructure.sql file Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #78 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Good job Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14743 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 [Bug 14743] addorder.pl redirect problems under plack behind apache 2.4.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org