https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |tomascohen@gmail.com CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57344&action=edit Bug 17591: Use fully qualified C4::Items function names in C4::Circulation To test: - Run: $ prove prove t/db_dependent/Members/IssueSlip.t => FAIL: C4::Circulation is not being able to find the GetItem function. - Apply the patch - Run: $ prove prove t/db_dependent/Members/IssueSlip.t => SUCCESS: All green - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57344|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57350&action=edit [SIGNED-OFF] Bug 17591: Use fully qualified C4::Items function names in C4::Circulation To test: - Run: $ prove prove t/db_dependent/Members/IssueSlip.t => FAIL: C4::Circulation is not being able to find the GetItem function. - Apply the patch - Run: $ prove prove t/db_dependent/Members/IssueSlip.t => SUCCESS: All green - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57366&action=edit Bug 17591: Use fully qualified C4::Items function names in C4::Reserves -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14610 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The GetItem error from t/db_dependent/Members/IssueSlip.t is raised since: commit bf1563e60b31244f4ea977eb84954fb8501ed59a Bug 14610 - Add and update modules Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 [Bug 14610] Add ability to place article requests in Koha -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It also breaks t/db_dependent/Letters.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17599 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #9)

I have tried several things and never managed to fix the original error. I'd suggest to remove the use to C4::Circulation and move GetIssuingRule to Koha::IssuingRules. Patch is coming (on another bug report).

See bug 17599. Feel free to continue the job if you are interested. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- So, we finally fix the issue with bug 17599. To continue the discussion and find a more complete solution, see bug 17600. *** This bug has been marked as a duplicate of bug 17599 *** -- You are receiving this mail because: You are watching all bug changes.