[Bug 15333] New: Use Koha::Cache for caching all holidays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333 Bug ID: 15333 Summary: Use Koha::Cache for caching all holidays Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org Now that bug 14522 is pushed to master, this follow-up bug is to add Koha::Cache style caching for all 'holiday' subs() -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14522 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 [Bug 14522] Use Koha::Cache for accessing single_holidays() -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Fantastic that your looking into this mason. The patches on the prior bug go a long way to improving performance.. Nit only by reducing database hits by caching but also by reducing DateTime instantiations within loops, which are a well known performance bottleneck. So pleased to see work going on in this area. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Whilst we're on performance, I'd be interested to see if there was any discernible difference in using List::Utils any function over the loop found around line 140 of Koha::Calendar? Anyone fancy testing that.. use List::Utils qw/any/; #(It's in core perl in more recent releases anyways) return (any { /$date/ } @$holidays); They do exactly the same thing, only I think List::Utils functions does so in c instead of perl so I 'think' is usually quicker ;) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org