[Bug 22498] New: Can not select any funds for invoice adjustments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Bug ID: 22498 Summary: Can not select any funds for invoice adjustments Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Bug 14850 renamed budgets_loop to budgets but did not update the variables for invoice adjustments -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 86531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86531&action=edit Bug 22498: Rename variable for budgets loop for invoice adjustments To test: 1 - Try to add some adjustments to an invoice (receive shipments, create invoice, click 'finish receiving') 2 - Note the fund dropdown has only 'No fund' 3 - Apply patch 4 - Refresh page 5 - Note you can now select funds, hooray! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Depends on| |14850 Blocks| |22296 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 [Bug 22296] Invoice adjustments are not populating to budget views -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86531|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 86546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86546&action=edit Bug 22498: Rename variable for budgets loop for invoice adjustments To test: 1 - Try to add some adjustments to an invoice (receive shipments, create invoice, click 'finish receiving') 2 - Note the fund dropdown has only 'No fund' 3 - Apply patch 4 - Refresh page 5 - Note you can now select funds, hooray! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86546|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86567&action=edit Bug 22498: Rename variable for budgets loop for invoice adjustments To test: 1 - Try to add some adjustments to an invoice (receive shipments, create invoice, click 'finish receiving') 2 - Note the fund dropdown has only 'No fund' 3 - Apply patch 4 - Refresh page 5 - Note you can now select funds, hooray! Signed-off-by: Janet McGowan <janet.mcgowan@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just doing the honours of uploading Janets signed patch for her.. sandboxes don't like signing of dependants. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86567|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86595&action=edit Bug 22498: Rename variable for budgets loop for invoice adjustments To test: 1 - Try to add some adjustments to an invoice (receive shipments, create invoice, click 'finish receiving') 2 - Note the fund dropdown has only 'No fund' 3 - Apply patch 4 - Refresh page 5 - Note you can now select funds, hooray! Signed-off-by: Janet McGowan <janet.mcgowan@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- 18.05.x is missing 14850 dependency. won't backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org