[Bug 17734] New: Make possible to pay and writeoff from boraccount page and make action buttons split button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Bug ID: 17734 Summary: Make possible to pay and writeoff from boraccount page and make action buttons split button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com, | |rbit@rbit.cz Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 [Bug 17596] Simplify accounting UI in staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58009&action=edit Bug 17734: Make possible to pay and writeoff from boraccount page and make action buttons split button Test plan 0) Have a patron with some fines - some payd and some unpaid 1) Apply the patch 2) Go to boraccount.pl page 3) In most right column you should see apropriate combination of buttons for each row: Print - fee which was writted-off and write-off line Pay + Print in dropdown - unpaid fee, for user without permissin to writeoff Pay + Print and Write off in dropdown - unpaid fee, user with permission to writeoff Print + Reverse in dropdown - for payment row 4) Try all combination and use buttons and confirm they work as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58010&action=edit Bug 17734: Get rid of reverse_col parameter As it's not needed anymore, we have at least "Print" action button for each row Test plan: 1) Go to boraccount page, the last column header should have "Actions" title 2) git grep reverse_col should not return any appearence -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735 [Bug 17735] Merge boraccount and pay pages into one -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Chris Kirby <chris.kirby@ilsleypubliclibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.kirby@ilsleypubliclib | |rary.org --- Comment #3 from Chris Kirby <chris.kirby@ilsleypubliclibrary.org> --- Paid a fine using the pay button in right column. Reversed the payment using the reverse button dropdown Now, action displays "Pay" and dropdown arrow appears but know options visible. Should the dropdown arrow be removed since there are no longer are options? Or should the "write off" and "print" be displayed in the dropdown menu again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Chris Kirby from comment #3)
Paid a fine using the pay button in right column. Reversed the payment using the reverse button dropdown Now, action displays "Pay" and dropdown arrow appears but know options visible. Should the dropdown arrow be removed since there are no longer are options? Or should the "write off" and "print" be displayed in the dropdown menu again?
You are right, there should always be the print action. I'll attach a followup soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58009|0 |1 is obsolete| | --- Comment #5 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 58115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58115&action=edit Bug 17734: Make possible to pay and writeoff from boraccount page and make action buttons split button Test plan 0) Have a patron with some fines - some paid and some unpaid 1) Apply the patch 2) git grep reverse_col should not return any appearence 3) Go to boraccount page, the last column header should have "Actions" title 4) In the rightmost column you should see apropriate combination of buttons for each row: Print - fee which was written-off and write-off line Pay + Print in dropdown - unpaid fee, for user without permission to writeoff Pay + Print and Write off in dropdown - unpaid fee, user with permission to writeoff Print + Reverse in dropdown - for payment row 5) Try all combination and use buttons and confirm they work as expected Signed-off-by: Radek Šiman <rbit@rbit.cz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Patch doesn't apply --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Radek, what did you do with the patches? Looks like you join the second patch with commit message of first patch, so there is now code for second patch twice and no code from first patch... If don't know what happens, I can resubmit the original patches... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58115|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58009|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- I was contacted by Radek off Bugzilla and he now knows where the problem is and will try to re-sign off it, so I obsolete his attachment and unobsolete the original one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58009|0 |1 is obsolete| | Attachment #58010|0 |1 is obsolete| | --- Comment #9 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 58169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58169&action=edit Bug 17734: Make possible to pay and writeoff from boraccount page and make action buttons split button Test plan 0) Have a patron with some fines - some paid and some unpaid 1) Apply the patch 2) git grep reverse_col should not return any appearence 3) Go to boraccount page, the last column header should have "Actions" title 4) In the rightmost column you should see apropriate combination of buttons for each row: Print - fee which was written-off and write-off line Pay + Print in dropdown - unpaid fee, for user without permission to writeoff Pay + Print and Write off in dropdown - unpaid fee, user with permission to writeoff Print + Reverse in dropdown - for payment row 5) Try all combination and use buttons and confirm they work as expected Signed-off-by: Radek Šiman <rbit@rbit.cz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58169|0 |1 is obsolete| | --- Comment #10 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 58171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58171&action=edit Bug 17734: Make possible to pay and writeoff from boraccount page and make action buttons split button Test plan 0) Have a patron with some fines - some payd and some unpaid 1) Apply the patch 2) Go to boraccount.pl page 3) In most right column you should see apropriate combination of buttons for each row: Print - fee which was writted-off and write-off line Pay + Print in dropdown - unpaid fee, for user without permissin to writeoff Pay + Print and Write off in dropdown - unpaid fee, user with permission to writeoff Print + Reverse in dropdown - for payment row 4) Try all combination and use buttons and confirm they work as expected Signed-off-by: Radek Šiman <rbit@rbit.cz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58171|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58010|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58009|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #11 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Please forgive me, I'm really trying to do my best :-( I'm about to sign-off again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58009|0 |1 is obsolete| | --- Comment #12 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 58174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58174&action=edit Bug 17734: Make possible to pay and writeoff from boraccount page and make action buttons split button Test plan 0) Have a patron with some fines - some payd and some unpaid 1) Apply the patch 2) Go to boraccount.pl page 3) In most right column you should see apropriate combination of buttons for each row: Print - fee which was writted-off and write-off line Pay + Print in dropdown - unpaid fee, for user without permissin to writeoff Pay + Print and Write off in dropdown - unpaid fee, user with permission to writeoff Print + Reverse in dropdown - for payment row 4) Try all combination and use buttons and confirm they work as expected Signed-off-by: Radek Šiman <rbit@rbit.cz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58010|0 |1 is obsolete| | --- Comment #13 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 58175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58175&action=edit Bug 17734: Get rid of reverse_col parameter As it's not needed anymore, we have at least "Print" action button for each row Test plan: 1) Go to boraccount page, the last column header should have "Actions" title 2) git grep reverse_col should not return any appearence Signed-off-by: Radek Šiman <rbit@rbit.cz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I get a menu with "Pay", an arrow to open the dropdown, but it is empty. To recreate: - Create a manual invoice - Account tab, click pay - Reverse the payment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Blocks|17596 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 [Bug 17596] Simplify accounting UI in staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Component|Circulation |Fines and fees -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 24604 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24079 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079 [Bug 24079] Convert paycollect 'page' to a modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24604, 25976 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604 [Bug 24604] Add 'Pay' button under Transactions tab in patron accounting https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25976 [Bug 25976] Add 'Writeoff' button under Transactions tab in patron accounting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17735 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735 [Bug 17735] Merge boraccount and pay pages into one -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58174|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58175|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24079 | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 24079 *** Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079 [Bug 24079] Convert paycollect 'page' to a modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24604, 25976 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604 [Bug 24604] Add 'Pay' button under Transactions tab in patron accounting https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25976 [Bug 25976] Add 'Writeoff' button under Transactions tab in patron accounting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org