[Bug 43355] New: Add a /search API endpoint for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 Bug ID: 43355 Summary: Add a /search API endpoint for biblios Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: caroline.cyr-la-rose@inlibro.com, dcook@prosentient.com.au, hammat.wele@inlibro.com, jonathan.druart@gmail.com, kyle@bywatersolutions.com, m.de.rooy@rijksmuseum.nl, magnus@libriotech.no, mathsabypro@gmail.com, paul.derscheid@lmscloud.de, philippe.blouin@inlibro.com, tomascohen@gmail.com Depends on: 25870, 32734 Blocks: 27113, 27428 Target Milestone: --- +++ This bug was initially created as a clone of Bug #25870 +++ To try and get that bug moving again I thought I'd work from a blue sky proposal taking comments from the original bug into consideration and adding a dedicated /search endpoint. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 [Bug 25870] Add a q_ccl query parameter to /biblios (ie add search API endpoint) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 [Bug 27113] Elasticsearch: Autocomplete in search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 [Bug 27428] Show the number of records in the bibliographic record detail page with Elasticsearch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734 [Bug 32734] Add GET endpoint for listing Biblios -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|25870 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 [Bug 25870] Add a q_ccl query parameter to /biblios (ie add search API endpoint) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35052 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35052 [Bug 35052] OpacHiddenItemsHidesRecord system preference should be considered in search indexes instead of post filtering results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |26.11 Initiative type|--- |Feature -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43358 Blocks| |43359 Blocks| |43360 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Posting the overall plan this bug fits into, for anyone landing here from Bug 25870 or Bug 27113. The goal is a modern, decoupled search architecture for Koha: a dedicated /search endpoint using a Lucene-style query language (matching what Elasticsearch's own query_string handler already speaks natively), instead of overloading /biblios with a CCL query parameter. This is being built as a small chain of focused bugs rather than one large patch, so each piece can be reviewed and can land independently, and so Elasticsearch progress is not held hostage to Zebra parity (nor is Zebra being dropped outright) - the disagreement that has kept Bug 25870 stuck for six years. The chain, in dependency order: Bug 42835 (ElasticSearch should have an items index) and Bug 43151 (ES should apply search filters on each item discretely) - prerequisite infrastructure already in the pipeline independently of this program. A real per-item Elasticsearch index and the query mechanism for correctly correlating multiple item-level fields to the same item. Everything below depends on these landing. Bug 35052 (OpacHiddenItemsHidesRecord ... at index time) - submitted. Moves OpacHiddenItems/OpacHiddenItemsHidesRecord/OpacHiddenItemsExceptions enforcement from post-search-result processing to query time, using Bug 43151's items-index query mechanism. This fixes the actual reported bug (wrong pagination, wrong total-hit counts when hidden records are interspersed in a result set), and is also the correctness gap that failed QA on the original q_ccl patch for this bug - so it's foundational to doing a public /search route properly, not just a nice-to-have. Bug 43355 (this bug) - the core architecture: the Lucene query language, its AST, the /search and /public/search REST endpoints (GET and POST), curated index-derived result summaries (including real availability data from the items index, no DB round-trip needed), and facets, backed by Elasticsearch. Bug 43358 (Zebra: add a reduced-parity Lucene query translation layer) - depends on this bug. Zebra gets a real, documented, permanently reduced-parity implementation (basic Lucene syntax translated to PQF/CCL) rather than either blocking this bug or being abandoned. Zebra cannot index items separately or join bibs/items, so combined item-level filter correctness, facet accuracy against those filters, and query-time OpacHiddenItems enforcement stay Elasticsearch-only for Zebra installations, falling back to today's existing behaviour for those specific concerns. Bug 43359 (Migrate opac-search.pl to use the new /search architecture) - depends on this bug. Puts OPAC web search on the same code path as the new API, so results never diverge between the two - the divergence problem David Cook raised on Bug 25870. Bug 43360 (Wire the advanced search form to build Lucene queries) - depends on this bug. Retires the legacy internal query parameter format in favour of the same Lucene syntax the API uses, so there's one query language to maintain, not two. Once this bug lands, Bug 27113 (Elasticsearch: Autocomplete in search) should be able to build directly on the /search endpoint rather than staying blocked on the CCL approach. Full design notes and the cross-cutting decisions this program is built on (query syntax, route naming, result shape, facets scope, Zebra policy) are kept alongside the work rather than in Bugzilla; happy to share them if useful to reviewers. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43358 [Bug 43358] Zebra: add a reduced-parity Lucene query translation layer for the new /search endpoint https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43359 [Bug 43359] Migrate opac-search.pl to use the new /search architecture (Bug 43355) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43360 [Bug 43360] Wire the advanced search form to build Lucene queries via the new /search architecture (Bug 43355) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #2 from Blou <philippe.blouin@inlibro.com> --- upvote! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203944&action=edit Bug 43355: Extract shared _apply_opac_search_filters from search_compat -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203945&action=edit Bug 43355: Add Lucene field-prefix extraction and validation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203946&action=edit Bug 43355: Add search_marc_to_field.display for configurable /search API result fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203947&action=edit Bug 43355: Automated Schema Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203948&action=edit Bug 43355: Add authenticated GET /search/biblios -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203949&action=edit Bug 43355: Add public GET /public/search/biblios with OpacSuppression/OpacHiddenItems enforcement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203950&action=edit Bug 43355: Add _get_availability_by_biblionumbers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203951&action=edit Bug 43355: Add availability and selective facets to search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203952&action=edit Bug 43355: Make /search/biblios result fields configurable via search_marc_to_field.display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203953&action=edit Bug 43355: Add POST /search/biblios and /public/search/biblios -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203954&action=edit Bug 43355: Add admin UI toggle for search_marc_to_field.display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203955&action=edit Bug 43355: (QA follow-up) Fix critic, file permissions, and Test::NoWarnings in test files Test plan: 1. Enable Elasticsearch (e.g. `ktd --search-engine es8 up`, or your usual instance with ES enabled). 2. Catalogue two records: ZZZ43355ONE (title "The Stranger", author "Albert Camus", one available item) and ZZZ43355TWO (title "The Plague", author "Albert Camus", zero available items - e.g. all items withdrawn). 3. Rebuild indices: misc/search_tools/rebuild_elasticsearch.pl -a -r -v 4. GET /api/v1/search/biblios?q=camus as a logged-in catalogue user: expect both records, available: true for ONE and available: false for TWO. 5. GET /api/v1/search/biblios?q=title:stranger: expect only ONE. 6. GET /api/v1/search/biblios?q=camus&sort=title_asc: expect results ordered by title ascending. 7. GET /api/v1/search/biblios?q=camus&facets=itemtype: expect a facets.itemtype breakdown in the response. 8. GET /api/v1/search/biblios?q=notarealfield:camus: expect 400 with error_code INVALID_SEARCH_FIELD. 9. GET /api/v1/public/search/biblios?q=camus with no authentication at all: expect 200, same response shape. 10. Suppress ZZZ43355TWO (e.g. via its OpacSuppression field) and turn on the OpacSuppression system preference: repeat step 9 and confirm TWO no longer appears in the public route's results, but still appears in the authenticated route's results. 11. POST /api/v1/search/biblios with body {"q": "camus"}: expect the same shape as step 4. 12. POST /api/v1/search/biblios with body {"q": "camus", "_page": 2, "_per_page": 1}: expect page 2 of results, one result per page, matching what GET ...&_page=2&_per_page=1 returns for the same query. 13. Run the full test suite: prove t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t \ t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t \ t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t \ t/db_dependent/api/v1/search_biblios.t All tests should pass. 14. Run the QA test tool and confirm it is happy with the whole patch set: koha-qa.pl -v 2 --more-tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203956&action=edit Bug 43355: Document Lucene query_string syntax in the /search/biblios swagger spec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- I think /search/biblios is probably a bit of suboptimal naming. I think /search/catalog would be more accurate conceptually. But that's OK. I won't make a fuss about it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Great initiative, Martin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #18 from David Nind <david@davidnind.com> --- Some of the dependent bugs no longer apply cleanly 8-(... ... Error: Apply failed: Cannot apply cleanly patches from bug 35052. Everything will be left dirty. Cannot apply cleanly patches from bug 43151. Everything will be left dirty. Cannot apply cleanly patches from bug 42835. Everything will be left dirty. ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203944|0 |1 is obsolete| | Attachment #203945|0 |1 is obsolete| | Attachment #203946|0 |1 is obsolete| | Attachment #203947|0 |1 is obsolete| | Attachment #203948|0 |1 is obsolete| | Attachment #203949|0 |1 is obsolete| | Attachment #203950|0 |1 is obsolete| | Attachment #203951|0 |1 is obsolete| | Attachment #203952|0 |1 is obsolete| | Attachment #203953|0 |1 is obsolete| | Attachment #203954|0 |1 is obsolete| | Attachment #203955|0 |1 is obsolete| | Attachment #203956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 205618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205618&action=edit Bug 43355: Extract shared _apply_opac_search_filters from search_compat -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 205619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205619&action=edit Bug 43355: Add Lucene field-prefix extraction and validation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 205620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205620&action=edit Bug 43355: Add search_marc_to_field.display for configurable /search API result fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 205621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205621&action=edit Bug 43355: Automated Schema Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 205622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205622&action=edit Bug 43355: Add authenticated GET /search/biblios -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 205623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205623&action=edit Bug 43355: Add public GET /public/search/biblios with OpacSuppression/OpacHiddenItems enforcement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 205624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205624&action=edit Bug 43355: Add _get_availability_by_biblionumbers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 205625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205625&action=edit Bug 43355: Add availability and selective facets to search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 205626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205626&action=edit Bug 43355: Make /search/biblios result fields configurable via search_marc_to_field.display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 205627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205627&action=edit Bug 43355: Add POST /search/biblios and /public/search/biblios -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 205628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205628&action=edit Bug 43355: Add admin UI toggle for search_marc_to_field.display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 205629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205629&action=edit Bug 43355: (QA follow-up) Fix critic, file permissions, and Test::NoWarnings in test files Test plan: 1. Enable Elasticsearch (e.g. `ktd --search-engine es8 up`, or your usual instance with ES enabled). 2. Catalogue two records: ZZZ43355ONE (title "The Stranger", author "Albert Camus", one available item) and ZZZ43355TWO (title "The Plague", author "Albert Camus", zero available items - e.g. all items withdrawn). 3. Rebuild indices: misc/search_tools/rebuild_elasticsearch.pl -a -r -v 4. GET /api/v1/search/biblios?q=camus as a logged-in catalogue user: expect both records, available: true for ONE and available: false for TWO. 5. GET /api/v1/search/biblios?q=title:stranger: expect only ONE. 6. GET /api/v1/search/biblios?q=camus&sort=title_asc: expect results ordered by title ascending. 7. GET /api/v1/search/biblios?q=camus&facets=itemtype: expect a facets.itemtype breakdown in the response. 8. GET /api/v1/search/biblios?q=notarealfield:camus: expect 400 with error_code INVALID_SEARCH_FIELD. 9. GET /api/v1/public/search/biblios?q=camus with no authentication at all: expect 200, same response shape. 10. Suppress ZZZ43355TWO (e.g. via its OpacSuppression field) and turn on the OpacSuppression system preference: repeat step 9 and confirm TWO no longer appears in the public route's results, but still appears in the authenticated route's results. 11. POST /api/v1/search/biblios with body {"q": "camus"}: expect the same shape as step 4. 12. POST /api/v1/search/biblios with body {"q": "camus", "_page": 2, "_per_page": 1}: expect page 2 of results, one result per page, matching what GET ...&_page=2&_per_page=1 returns for the same query. 13. Run the full test suite: prove t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t \ t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t \ t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t \ t/db_dependent/api/v1/search_biblios.t All tests should pass. 14. Run the QA test tool and confirm it is happy with the whole patch set: koha-qa.pl -v 2 --more-tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 --- Comment #31 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 205630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205630&action=edit Bug 43355: Document Lucene query_string syntax in the /search/biblios swagger spec -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org