[Bug 17005] New: REST API: add routes to list checkouts history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Bug ID: 17005 Summary: REST API: add routes to list checkouts history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: mail@jkozlovsky.cz QA Contact: testopia@bugs.koha-community.org Add API to list checkouts history for a user. This is very useful for use with VuFind. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Jiří Kozlovský <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Mike <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Text to go in the| |Minucipal Libray Ceska release notes| |Trebova CC| |black23@gmail.com, | |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Mike <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Minucipal Libray Ceska |Municipal Libray Ceska release notes|Trebova |Trebova -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |larit@student.uef.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Jiri Kozlovsky <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13895 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 [Bug 13895] Add API routes for checkouts retrieval and renewal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #1 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- Created attachment 53843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53843&action=edit Bug 17005: REST API: add routes to list checkouts history GET /checkouts/history (get all old_issues' issue_id) GET /checkouts/history?borrowernumber={borrowernumber} (get all borrower's old_issues) GET /checkouts/history/{checkout_id} (get old_issue) + unit tests in t/db_dependent/api/v1/checkoutshistory.t Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission circulate_remaining_permissions. 2. Go to http://yourlibrary/api/v1/checkouts/history?borrowernumber=XXX (replace XXX with a borrowernumber that has some checkouts history) and check you receive correct data 3. Go to http://yourlibrary/api/v1/checkouts/history/YYY (replace YYY with an existing checkout id) and check you receive correct data 4. Run unit tests in t/db_dependent/api/v1/checkoutshistory.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #2 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- Since this bug depends on bug 13895, you should do "git bz apply 13895" first & then "git bz apply 17005" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Jiri Kozlovsky <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53843|0 |1 is obsolete| | --- Comment #3 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- Created attachment 53851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53851&action=edit Bug 17005: REST API: add routes to list checkouts history GET /checkouts/history (get all old_issues' issue_id) GET /checkouts/history?borrowernumber={borrowernumber} (get all borrower's old_issues) GET /checkouts/history/{checkout_id} (get old_issue) + unit tests in t/db_dependent/api/v1/checkoutshistory.t Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission circulate_remaining_permissions. 2. Go to http://yourlibrary/api/v1/checkouts/history?borrowernumber=XXX (replace XXX with a borrowernumber that has some checkouts history) and check you receive correct data 3. Go to http://yourlibrary/api/v1/checkouts/history/YYY (replace YYY with an existing checkout id) and check you receive correct data 4. Run unit tests in t/db_dependent/api/v1/checkoutshistory.t Added promised unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Jiri Kozlovsky <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53851|0 |1 is obsolete| | --- Comment #4 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- Created attachment 53852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53852&action=edit Bug 17005: REST API: add routes to list checkouts history GET /checkouts/history (get all old_issues' issue_id) GET /checkouts/history?borrowernumber={borrowernumber} (get all borrower's old_issues' issue_id) GET /checkouts/history/{checkout_id} (get old_issue) + unit tests in t/db_dependent/api/v1/checkoutshistory.t Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission circulate_remaining_permissions. 2. Go to http://yourlibrary/api/v1/checkouts/history?borrowernumber=XXX (replace XXX with a borrowernumber that has some checkouts history) and check you receive all the issues from patron's history 3. Go to http://yourlibrary/api/v1/checkouts/history/YYY (replace YYY with an existing checkout id) and check you receive correct data 4. Run unit tests in t/db_dependent/api/v1/checkoutshistory.t Now the endpoint with borrowernumber does not return all the details from within the old issues, but only their issue_id. This is made in order to enhance API performance. E.g. VuFind can retrieve all the issue_ids & use AJAX to query details about those, so user sees how the details come up one by one & does not have to wait for all of them at once (could be very long with really old users) In order to get issue details, use the endpoint with the checkout_id. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Jiri Kozlovsky <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53852|0 |1 is obsolete| | --- Comment #5 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- Created attachment 53858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53858&action=edit Bug 17005: REST API: add routes to list checkouts history GET /checkouts/history (get all old_issues' issue_id) GET /checkouts/history?borrowernumber={borrowernumber} (get all borrower's old_issues' issue_id) GET /checkouts/history/{checkout_id} (get old_issue) + unit tests in t/db_dependent/api/v1/checkoutshistory.t Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission circulate_remaining_permissions. 2. Go to http://yourlibrary/api/v1/checkouts/history?borrowernumber=XXX (replace XXX with a borrowernumber that has some checkouts history) and check you receive all the issues from patron's history 3. Go to http://yourlibrary/api/v1/checkouts/history/YYY (replace YYY with an existing checkout id) and check you receive correct data 4. Run unit tests in t/db_dependent/api/v1/checkoutshistory.t This patch on top of previous changes adds the condition that the old issue included in any response must have itemnumber. Those which does not have itemnumber does not count as such old issue is completely useless. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- I've just tried this patch in order to test bug 17005 depending patch. For me 4 tests are failing: 23, 24, 26, 27. It seems that each time, I've got this error: Can't call method "borrowernumber" on unblessed reference at <base>Koha/REST/V1/Checkout.pm line 81 It may be due to my testing environment. Can someone confirm that tests are still working on master? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #7 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- (In reply to Frédéric Demians from comment #6)
I've just tried this patch in order to test bug 17005 depending patch. For me 4 tests are failing: 23, 24, 26, 27. It seems that each time, I've got this error:
Can't call method "borrowernumber" on unblessed reference at <base>Koha/REST/V1/Checkout.pm line 81
It may be due to my testing environment. Can someone confirm that tests are still working on master?
Oh, did you apply the bug 13895 first before testing? It is based on that bug, which is not in master yet. Dependency is set already -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Jiri Kozlovsky from comment #7)
Oh, did you apply the bug 13895 first before testing? It is based on that bug, which is not in master yet. Dependency is set already
Indeed, my comment was for bug 13895! I've mixed up my browser tabs. I will recopy my comment on bug 13895 thread, and restore your patch status to 'Needs Signoff'. Thks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #9 from Lari Taskula <larit@student.uef.fi> --- Good work with the patch, Jiří! I will sign-off, but first I would like to present some thoughts: - Should we also allow user to access his own checkout history even if he does not have circulate_remaining_permissions? I think this would need to consider syspref 'opacreadinghistory'. Similar to Bug 13895. - If GET /checkouts/history returns only issue_ids, should we come up with a way to GET multiple issue_id's in one request? Say a client wants to display all old checkouts for a patron on with detailed information for each checkout; He makes a GET to /checkouts/history?borrowernumber=123. 1000 issue_ids are returned. The question is, is it better to individually GET /checkouts/history/1 ... /checkouts/history/1000 or do one request GET /checkouts/history?issue_id=1+2+3+...+999+1000 ? Same like availability has in Bug 16826. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mail@jkozlovsky.cz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #10 from Lari Taskula <larit@student.uef.fi> --- Created attachment 54198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54198&action=edit Bug 17005: Reword borrowers to patrons in Swagger tags for checkouts history Routes for checkouts history have tags called "borrowers". We should use "patrons" instead in order not to have both (endpoints for patrons already add "patrons"). This patch changes the tags from borrowers to patrons in: GET /checkouts/history GET /checkouts/history/{checkout_id} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53858|0 |1 is obsolete| | Attachment #54198|0 |1 is obsolete| | --- Comment #11 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 56698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56698&action=edit Bug 17005: REST API: add routes to list checkouts history GET /checkouts/history (get all old_issues' issue_id) GET /checkouts/history?borrowernumber={borrowernumber} (get all borrower's old_issues' issue_id) GET /checkouts/history/{checkout_id} (get old_issue) + unit tests in t/db_dependent/api/v1/checkoutshistory.t Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission circulate_remaining_permissions. 2. Go to http://yourlibrary/api/v1/checkouts/history?borrowernumber=XXX (replace XXX with a borrowernumber that has some checkouts history) and check you receive all the issues from patron's history 3. Go to http://yourlibrary/api/v1/checkouts/history/YYY (replace YYY with an existing checkout id) and check you receive correct data 4. Run unit tests in t/db_dependent/api/v1/checkoutshistory.t This patch on top of previous changes adds the condition that the old issue included in any response must have itemnumber. Those which does not have itemnumber does not count as such old issue is completely useless. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56698|0 |1 is obsolete| | --- Comment #12 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 56699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56699&action=edit Bug 17005: REST API: add routes to list checkouts history GET /checkouts/history (get all old_issues' issue_id) GET /checkouts/history?borrowernumber={borrowernumber} (get all borrower's old_issues' issue_id) GET /checkouts/history/{checkout_id} (get old_issue) + unit tests in t/db_dependent/api/v1/checkoutshistory.t Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission circulate_remaining_permissions. 2. Go to http://yourlibrary/api/v1/checkouts/history?borrowernumber=XXX (replace XXX with a borrowernumber that has some checkouts history) and check you receive all the issues from patron's history 3. Go to http://yourlibrary/api/v1/checkouts/history/YYY (replace YYY with an existing checkout id) and check you receive correct data 4. Run unit tests in t/db_dependent/api/v1/checkoutshistory.t This patch on top of previous changes adds the condition that the old issue included in any response must have itemnumber. Those which does not have itemnumber does not count as such old issue is completely useless. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #13 from Lari Taskula <lari.taskula@jns.fi> --- Rebased on top of master and moved permissions into Swagger, and added a HTTP 401 and 403 test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Endpoint does work as expected, but the test checkoutshistory.t is broken and also koha-qa says: FAIL Koha/REST/V1/Checkout.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL spelling perfomance ==> performance -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #15 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- Someone please help me, I'm stuck in writing unit tests in kohadevbox. This is what I got returned from sample API partons.t: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/api/v1/patrons.t t/db_dependent/api/v1/patrons.t .. DBD::mysql::st execute failed: Unknown column 'overdrive_auth_token' in 'field list' [for Statement "INSERT INTO `borrowers` ( `B_address`, `B_address2`, `B_city`, `B_country`, `B_email`, `B_phone`, `B_state`, `B_streetnumber`, `B_streettype`, `B_zipcode`, `address`, `address2`, `altcontactaddress1`, `altcontactaddress2`, `altcontactaddress3`, `altcontactcountry`, `altcontactfirstname`, `altcontactphone`, `altcontactstate`, `altcontactsurname`, `altcontactzipcode`, `borrowernotes`, `branchcode`, `cardnumber`, `categorycode`, `checkprevcheckout`, `city`, `contactfirstname`, `contactname`, `contactnote`, `contacttitle`, `country`, `dateenrolled`, `dateexpiry`, `dateofbirth`, `debarred`, `debarredcomment`, `email`, `emailpro`, `fax`, `firstname`, `flags`, `gonenoaddress`, `guarantorid`, `initials`, `lastseen`, `lost`, `mobile`, `opacnote`, `othernames`, `overdrive_auth_token`, `password`, `phone`, `phonepro`, `privacy`, `privacy_guarantor_checkouts`, `relationship`, `sex`, `sms_provider_id`, `smsalertnumber`, `sort1`, `sort2`, `state`, `streetnumber`, `streettype`, `surname`, `title`, `updated_on`, `userid`, `zipcode`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='VjklbDmEmoWudPhpCWvz7rJAfEEmrCSjbnCf6S4v8DtGZjkCI7jaHoADwHWOGYysHLuBeMzYorwm3992o_UDF3YKUpGYgoPJ', 1='GZgOWb', 2='tSVrqQ8', 3='wk', 4='bNj', 5='BI2aSjf', 6='pTkX6zIVE', 7='BmMDX', 8='Df9lTEgMW770zsj6qMmgo90AcPmCZ2f5yxR2tHtd2W1', 9='NiPDa3Is5', 10='aMIrS', 11='o2fw2mw_gx', 12='QJ96zi10BKHjf45i7UI5qhWEwYcYH4iXBfH8pDeqlMV5xWg2eSyeXiBd0OIboV3mNVJffAKQ0u75wDpIY05H7Iqe3TIbHMUPQ5CoevT1eg87PlkSp6CxoZLKyEzRTNbZS88WKtrzDV6T3NJnn1yDEBfoQdM8zl7n9BYWS6oSacsGTXXJ1fFwiVuNN0GiiulwCC7nhzw5vCmF3eNNxVDj2LF92S22PbUi5pTEiClTLuTqa4zABSs2', 13='a9RpXJAOZTH81_8QUy0ufD0qF_dMHStD3yzzQIr9fcV4KCVRYT_GRsLp4O6iyMI2vHk2LARICmB3crQiA9HjJA4wM4LHfrKDfcUpRurK4R4sH4GS_LxvX', 14='w6f9XgdIm4fUDi1LAlxHlnv0k6bAWvnX_NA7OhYNeInF24CbCzLyOWcX0iyUWwYo1rjUOK4X5DC8zuqiWZdxLveQVOQWCTb0TwFP5bYXCvX0Y20eePvWShnkw3BVm8dnoo8pSvENIIBPsEcbj49uUtuxt_tgye45oX2vYGS75ICIWtjZB6fP8RN6e33SCtoIE4c0wiB68iG6Njs', 15='N', 16='L6xkGcRxTqabsrPIv296A_YUr_TYIn4k4U_p0ESh3iNPfxR2iAh2hVGHQLc8snQXsvjeKQ7Pca0gcp_k9DVhTPcXi3JvdErJ9UBI6SkvmYXxDI7RRI2rm2R4mOuMuf8PbcfAQdWjTbWFnCag', 17='xIn07_7bog', 18='t', 19='d25sJFVrJ6sqNW6o4jw0E76EZkC6w6zmX95Ixsa1yNqZ58zSrN63q1fqCpzTO4HDx0bGCxGXOXVpOTL9cvbaepJ6d_JjBDKUkGsJtfNd7bMlpAx0ypzNE9a3zmIQKw8_ZBeB4M0uk6RONs2t0Pe_MLGTTMP7', 20='Gm1Mgmb4dr5tTD30kXY0y', 21='F3wl', 22='Y6PWhl_UhS', 23='wkINA3tkWfTGo', 24='cR4nYYRnj', 25='ii9I', 26='xlZTwq8', 27='ThXks0vXrW', 28='jImAGNe', 29='YFQrtDRDCCQCLeYC7c_dErxY2Ol5F7InDZk3oEn41zMl2sN_AQxoNYZjqtOugdmSJzUx9HXmdutL45Js8ZUWvfelGTPvCfLdPDIZziX_hNBbVnmwHyXUIoZboIWusA7CZllwzA0TvC2zJ4gKx09v_p5Zu2_42msD0KskMdg4iFzCRl09e6IufqZvS9CJ4uRAA1x4hyUbdy', 30='Z_Fqh', 31='Oba', 32='2017-03-12', 33='2017-03-12', 34='2017-03-12', 35='2017-03-12', 36='Mwf1IB5_qAvR4Fm1Fg2JdqZ2YWofYwVcC5l4dwcnIit4fba2Yopjh5rxZh__Dqhz3yNiWRVzG0M90V2kVFZ0pNRVGpt6DqVqVuJpZrKz0PArDdo5Aept70lMR9mbRHLo6ydPMHVMJcf8NYSajFO1DtQ4JYaT_bRjtdj5Q6ftsOM2yZEME', 37='lHLdEMU', 38='szanHw_MI3q', 39='iXZmy', 40='hlQ0BFbYzW5', 41=0, 42=54, 43=1365868268, 44='uW', 45='2017-03-12 20:34:07', 46=108, 47='gUpy', 48='cfPPJnisWoT', 49='KJSvZZdrF', 50='qm8Xqtvkp', 51='CuaSVbZHRgPLRSM8o5kj', 52='RJJf2lN_m7y', 53='XgyQAVDu', 54=1483959990, 55=1, 56='DkqBG8ZnY3UdRnqDJhvuuW6nnxkFa7Ynp6le', 57='w', 58='4', 59='BpAvEd8VoHTlNcxMHobD', 60='y_7ohFg3sH2tV7LPRQHXZ2x39fdcflRNl_y9UFROZFwAg2stPmeolaYYEY8', 61='eqNIYiKKN0zqJWW_HXk3WZmTAiNjrdRFfiTRsli8X4hkhUkXxH1hcVj5gLV3dSIkX9uAp4l_pS89W63', 62='DWqrDgqkQW', 63='mKq', 64='z9apII7dgaGVu9', 65='Sqj', 66='WXReDMh', 67='2017-03-12 20:34:07', 68='zrG1UCYaWyq7Aq3eSUT8R6MW12jWL0', 69='IcdAqkr_KCQl_wJIErkLSP'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_execute(): DBD::mysql::st execute failed: Unknown column 'overdrive_auth_token' in 'field list' [for Statement "INSERT INTO `borrowers` ( `B_address`, `B_address2`, `B_city`, `B_country`, `B_email`, `B_phone`, `B_state`, `B_streetnumber`, `B_streettype`, `B_zipcode`, `address`, `address2`, `altcontactaddress1`, `altcontactaddress2`, `altcontactaddress3`, `altcontactcountry`, `altcontactfirstname`, `altcontactphone`, `altcontactstate`, `altcontactsurname`, `altcontactzipcode`, `borrowernotes`, `branchcode`, `cardnumber`, `categorycode`, `checkprevcheckout`, `city`, `contactfirstname`, `contactname`, `contactnote`, `contacttitle`, `country`, `dateenrolled`, `dateexpiry`, `dateofbirth`, `debarred`, `debarredcomment`, `email`, `emailpro`, `fax`, `firstname`, `flags`, `gonenoaddress`, `guarantorid`, `initials`, `lastseen`, `lost`, `mobile`, `opacnote`, `othernames`, `overdrive_auth_token`, `password`, `phone`, `phonepro`, `privacy`, `privacy_guarantor_checkouts`, `relationship`, `sex`, `sms_provider_id`, `smsalertnumber`, `sort1`, `sort2`, `state`, `streetnumber`, `streettype`, `surname`, `title`, `updated_on`, `userid`, `zipcode`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='VjklbDmEmoWudPhpCWvz7rJAfEEmrCSjbnCf6S4v8DtGZjkCI7jaHoADwHWOGYysHLuBeMzYorwm3992o_UDF3YKUpGYgoPJ', 1='GZgOWb', 2='tSVrqQ8', 3='wk', 4='bNj', 5='BI2aSjf', 6='pTkX6zIVE', 7='BmMDX', 8='Df9lTEgMW770zsj6qMmgo90AcPmCZ2f5yxR2tHtd2W1', 9='NiPDa3Is5', 10='aMIrS', 11='o2fw2mw_gx', 12='QJ96zi10BKHjf45i7UI5qhWEwYcYH4iXBfH8pDeqlMV5xWg2eSyeXiBd0OIboV3mNVJffAKQ0u75wDpIY05H7Iqe3TIbHMUPQ5CoevT1eg87PlkSp6CxoZLKyEzRTNbZS88WKtrzDV6T3NJnn1yDEBfoQdM8zl7n9BYWS6oSacsGTXXJ1fFwiVuNN0GiiulwCC7nhzw5vCmF3eNNxVDj2LF92S22PbUi5pTEiClTLuTqa4zABSs2', 13='a9RpXJAOZTH81_8QUy0ufD0qF_dMHStD3yzzQIr9fcV4KCVRYT_GRsLp4O6iyMI2vHk2LARICmB3crQiA9HjJA4wM4LHfrKDfcUpRurK4R4sH4GS_LxvX', 14='w6f9XgdIm4fUDi1LAlxHlnv0k6bAWvnX_NA7OhYNeInF24CbCzLyOWcX0iyUWwYo1rjUOK4X5DC8zuqiWZdxLveQVOQWCTb0TwFP5bYXCvX0Y20eePvWShnkw3BVm8dnoo8pSvENIIBPsEcbj49uUtuxt_tgye45oX2vYGS75ICIWtjZB6fP8RN6e33SCtoIE4c0wiB68iG6Njs', 15='N', 16='L6xkGcRxTqabsrPIv296A_YUr_TYIn4k4U_p0ESh3iNPfxR2iAh2hVGHQLc8snQXsvjeKQ7Pca0gcp_k9DVhTPcXi3JvdErJ9UBI6SkvmYXxDI7RRI2rm2R4mOuMuf8PbcfAQdWjTbWFnCag', 17='xIn07_7bog', 18='t', 19='d25sJFVrJ6sqNW6o4jw0E76EZkC6w6zmX95Ixsa1yNqZ58zSrN63q1fqCpzTO4HDx0bGCxGXOXVpOTL9cvbaepJ6d_JjBDKUkGsJtfNd7bMlpAx0ypzNE9a3zmIQKw8_ZBeB4M0uk6RONs2t0Pe_MLGTTMP7', 20='Gm1Mgmb4dr5tTD30kXY0y', 21='F3wl', 22='Y6PWhl_UhS', 23='wkINA3tkWfTGo', 24='cR4nYYRnj', 25='ii9I', 26='xlZTwq8', 27='ThXks0vXrW', 28='jImAGNe', 29='YFQrtDRDCCQCLeYC7c_dErxY2Ol5F7InDZk3oEn41zMl2sN_AQxoNYZjqtOugdmSJzUx9HXmdutL45Js8ZUWvfelGTPvCfLdPDIZziX_hNBbVnmwHyXUIoZboIWusA7CZllwzA0TvC2zJ4gKx09v_p5Zu2_42msD0KskMdg4iFzCRl09e6IufqZvS9CJ4uRAA1x4hyUbdy', 30='Z_Fqh', 31='Oba', 32='2017-03-12', 33='2017-03-12', 34='2017-03-12', 35='2017-03-12', 36='Mwf1IB5_qAvR4Fm1Fg2JdqZ2YWofYwVcC5l4dwcnIit4fba2Yopjh5rxZh__Dqhz3yNiWRVzG0M90V2kVFZ0pNRVGpt6DqVqVuJpZrKz0PArDdo5Aept70lMR9mbRHLo6ydPMHVMJcf8NYSajFO1DtQ4JYaT_bRjtdj5Q6ftsOM2yZEME', 37='lHLdEMU', 38='szanHw_MI3q', 39='iXZmy', 40='hlQ0BFbYzW5', 41=0, 42=54, 43=1365868268, 44='uW', 45='2017-03-12 20:34:07', 46=108, 47='gUpy', 48='cfPPJnisWoT', 49='KJSvZZdrF', 50='qm8Xqtvkp', 51='CuaSVbZHRgPLRSM8o5kj', 52='RJJf2lN_m7y', 53='XgyQAVDu', 54=1483959990, 55=1, 56='DkqBG8ZnY3UdRnqDJhvuuW6nnxkFa7Ynp6le', 57='w', 58='4', 59='BpAvEd8VoHTlNcxMHobD', 60='y_7ohFg3sH2tV7LPRQHXZ2x39fdcflRNl_y9UFROZFwAg2stPmeolaYYEY8', 61='eqNIYiKKN0zqJWW_HXk3WZmTAiNjrdRFfiTRsli8X4hkhUkXxH1hcVj5gLV3dSIkX9uAp4l_pS89W63', 62='DWqrDgqkQW', 63='mKq', 64='z9apII7dgaGVu9', 65='Sqj', 66='WXReDMh', 67='2017-03-12 20:34:07', 68='zrG1UCYaWyq7Aq3eSUT8R6MW12jWL0', 69='IcdAqkr_KCQl_wJIErkLSP'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 249 # Looks like your test exited with 255 before it could output anything. t/db_dependent/api/v1/patrons.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 21/21 subtests Test Summary Report ------------------- t/db_dependent/api/v1/patrons.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 21 tests but ran 0. Files=1, Tests=0, 2 wallclock secs ( 0.02 usr 0.01 sys + 1.44 cusr 0.16 csys = 1.63 CPU) Result: FAIL I think it's obvious there is some problem with DB, but I have no idea what it could be about :( It's also obvious I cannot write any unit tests for this API because they would eventually fail from similar reason so I wouldn't see if they pass or no. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jiri Kozlovsky from comment #15)
Someone please help me, I'm stuck in writing unit tests in kohadevbox.
t/db_dependent/api/v1/patrons.t .. DBD::mysql::st execute failed: Unknown column 'overdrive_auth_token' in 'field list'
I think it's obvious there is some problem with DB, but I have no idea what it could be about :(
You are right, looks like you do need to update your database schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #17 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- (In reply to Josef Moravec from comment #16)
(In reply to Jiri Kozlovsky from comment #15)
Someone please help me, I'm stuck in writing unit tests in kohadevbox.
t/db_dependent/api/v1/patrons.t .. DBD::mysql::st execute failed: Unknown column 'overdrive_auth_token' in 'field list'
I think it's obvious there is some problem with DB, but I have no idea what it could be about :(
You are right, looks like you do need to update your database schema
I thought kohadevbox takes care of that? Btw I'm running it with this command: LOCAL_ANSIBLE=1 SYNC_REPO="/etc/koha/kohaclone" SKIP_WEBINSTALLER=1 CREATE_ADMIN_USER=1 vagrant up --provision -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jiri Kozlovsky from comment #17)
(In reply to Josef Moravec from comment #16)
(In reply to Jiri Kozlovsky from comment #15)
Someone please help me, I'm stuck in writing unit tests in kohadevbox.
t/db_dependent/api/v1/patrons.t .. DBD::mysql::st execute failed: Unknown column 'overdrive_auth_token' in 'field list'
I think it's obvious there is some problem with DB, but I have no idea what it could be about :(
You are right, looks like you do need to update your database schema
I thought kohadevbox takes care of that?
Btw I'm running it with this command:
LOCAL_ANSIBLE=1 SYNC_REPO="/etc/koha/kohaclone" SKIP_WEBINSTALLER=1 CREATE_ADMIN_USER=1 vagrant up --provision
I don't think you'd like to run provision just for updating the database, there is quicker way: cd kohaclone sudo koha-shell kohadev installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #19 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 61197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61197&action=edit Bug 17005 - REST API: add routes to list checkouts history - Followup1. Fix date_due timeformat in tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18795 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 [Bug 18795] REST API: DELETE (anonymize) checkout history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit | |y.org | Component|Web services |REST api CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion CC| |tomascohen@gmail.com --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This bug reproduces a design issue with our DB structure. Checkouts and OldCheckouts are the same thing, they've just been splitted for some reason (which leads to several problems). That said, I think this functionality should be implemented in /checkouts. And there should be a checked_in boolean for 'OldCheckouts'. Once this is actually implemented on the DB, it will be simpler. In the meantime, we can do it on the controller. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Municipal Libray Ceska | release notes|Trebova | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Assignee|mail@jkozlovsky.cz |josef.moravec@gmail.com URL| |https://wiki.koha-community | |.org/wiki/Checkouts_endpoin | |t_RFC#Update_-_Circulation_ | |history_aka_old_checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87254&action=edit Bug 17005: Add checked_in checkouts to REST API response This patch implements parameter 'checked_in' on checkouts endpoint to enable getting circulation history. Test plan: 1) Apply the patch and restart plack 2) Use your favorite REST API tester and play with /checkouts endpoint: - use it without checked_in parameter - use checked_in=1 for getting all (not only current) checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #22 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87255&action=edit Bug 17005: Test for checked_in parameter Test plan: prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56699|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61197|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22613 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613 [Bug 22613] Add /patrons/patron_id/checkouts endpoints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 [Bug 17003] REST API: add route to get checkout's renewability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87254|0 |1 is obsolete| | Attachment #87255|0 |1 is obsolete| | --- Comment #23 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87383&action=edit Bug 17005: Add checked_in checkouts to REST API response This patch implements parameter 'checked_in' on checkouts endpoint to enable getting circulation history. Test plan: 1) Apply the patch and restart plack 2) Use your favorite REST API tester and play with /checkouts endpoint: - use it without checked_in parameter - use checked_in=1 for getting returned checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #24 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87384&action=edit Bug 17005: Test for checked_in parameter Test plan: prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #25 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87385&action=edit Bug 17005: Add plugin parameters to /checkouts endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala@helsinki.fi --- Comment #26 from Ere Maijala <ere.maijala@helsinki.fi> --- If you have paging parameters, the response should also include the total number of records. Otherwise it's difficult to build a pager. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #27 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Ere Maijala from comment #26)
If you have paging parameters, the response should also include the total number of records. Otherwise it's difficult to build a pager.
According to Pagination plugin, there should be header X-Total-Count in response and Link headers with rel=prev|next|first|last see bug 19196, I am not aware of any documentation for this, but it looks like we need some ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #28 from Ere Maijala <ere.maijala@helsinki.fi> --- Oh, right, sorry, I totally missed the headers! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
see bug 19196, I am not aware of any documentation for this, but it looks like we need some ;)
Did I hear 'documentation'? :) Should this be added to the wiki for devs? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #30 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Katrin Fischer from comment #29)
see bug 19196, I am not aware of any documentation for this, but it looks like we need some ;)
Did I hear 'documentation'? :) Should this be added to the wiki for devs?
You hear right ;) Yes, I think it should be added to wiki. We need both, the guide for developers how to use this plugin (even it is relatively easy) and for api consumers what they could expect from this features. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87383|0 |1 is obsolete| | --- Comment #31 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87405&action=edit Bug 17005: Add checked_in checkouts to REST API response This patch implements parameter 'checked_in' on checkouts endpoint to enable getting circulation history. Test plan: 1) Apply the patch and restart plack 2) Use your favorite REST API tester and play with /checkouts endpoint: - use it without checked_in parameter - use checked_in=1 for getting returned checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87384|0 |1 is obsolete| | --- Comment #32 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87406&action=edit Bug 17005: Test for checked_in parameter Test plan: prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87385|0 |1 is obsolete| | --- Comment #33 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87407&action=edit Bug 17005: Add plugin parameters to /checkouts endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18407 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18407 [Bug 18407] REST API: Include renewability information on checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #34 from Ere Maijala <ere.maijala@helsinki.fi> --- I bz-applied this including dependencies but there seems to be a conflict: Applying: Bug 17005: Add checked_in checkouts to REST API response Using index info to reconstruct a base tree... M Koha/REST/V1/Checkouts.pm M api/v1/swagger/paths/checkouts.json Falling back to patching base and 3-way merge... Auto-merging api/v1/swagger/paths/checkouts.json Auto-merging Koha/REST/V1/Checkouts.pm CONFLICT (content): Merge conflict in Koha/REST/V1/Checkouts.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87405|0 |1 is obsolete| | --- Comment #35 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87442&action=edit Bug 17005: Add checked_in checkouts to REST API response This patch implements parameter 'checked_in' on checkouts endpoint to enable getting circulation history. Test plan: 1) Apply the patch and restart plack 2) Use your favorite REST API tester and play with /checkouts endpoint: - use it without checked_in parameter - use checked_in=1 for getting returned checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87406|0 |1 is obsolete| | --- Comment #36 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87443&action=edit Bug 17005: Test for checked_in parameter Test plan: prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87407|0 |1 is obsolete| | --- Comment #37 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87444&action=edit Bug 17005: Add plugin parameters to /checkouts endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #38 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Ere Maijala from comment #34)
I bz-applied this including dependencies but there seems to be a conflict:
Applying: Bug 17005: Add checked_in checkouts to REST API response Using index info to reconstruct a base tree... M Koha/REST/V1/Checkouts.pm M api/v1/swagger/paths/checkouts.json Falling back to patching base and 3-way merge... Auto-merging api/v1/swagger/paths/checkouts.json Auto-merging Koha/REST/V1/Checkouts.pm CONFLICT (content): Merge conflict in Koha/REST/V1/Checkouts.pm
I rebased the patches on to of bug 17003, should apply cleanly now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87442|0 |1 is obsolete| | Attachment #87443|0 |1 is obsolete| | Attachment #87444|0 |1 is obsolete| | --- Comment #39 from Michal Denar <black23@gmail.com> --- Created attachment 87447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87447&action=edit Bug 17005: Add checked_in checkouts to REST API response This patch implements parameter 'checked_in' on checkouts endpoint to enable getting circulation history. Test plan: 1) Apply the patch and restart plack 2) Use your favorite REST API tester and play with /checkouts endpoint: - use it without checked_in parameter - use checked_in=1 for getting returned checkouts Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #40 from Michal Denar <black23@gmail.com> --- Created attachment 87448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87448&action=edit Bug 17005: Test for checked_in parameter Test plan: prove t/db_dependent/api/v1/checkouts.t Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #41 from Michal Denar <black23@gmail.com> --- Created attachment 87449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87449&action=edit Bug 17005: Add plugin parameters to /checkouts endpoint Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87447|0 |1 is obsolete| | --- Comment #42 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88263&action=edit Bug 17005: Add checked_in checkouts to REST API response This patch implements parameter 'checked_in' on checkouts endpoint to enable getting circulation history. Test plan: 1) Apply the patch and restart plack 2) Use your favorite REST API tester and play with /checkouts endpoint: - use it without checked_in parameter - use checked_in=1 for getting returned checkouts Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87448|0 |1 is obsolete| | --- Comment #43 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88264&action=edit Bug 17005: Test for checked_in parameter Test plan: prove t/db_dependent/api/v1/checkouts.t Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87449|0 |1 is obsolete| | --- Comment #44 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88265&action=edit Bug 17005: Add plugin parameters to /checkouts endpoint Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #45 from Josef Moravec <josef.moravec@gmail.com> --- Just rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88263|0 |1 is obsolete| | Attachment #88264|0 |1 is obsolete| | Attachment #88265|0 |1 is obsolete| | --- Comment #46 from Michal Denar <black23@gmail.com> --- Created attachment 88329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88329&action=edit Bug 17005: Add checked_in checkouts to REST API response This patch implements parameter 'checked_in' on checkouts endpoint to enable getting circulation history. Test plan: 1) Apply the patch and restart plack 2) Use your favorite REST API tester and play with /checkouts endpoint: - use it without checked_in parameter - use checked_in=1 for getting returned checkouts Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #47 from Michal Denar <black23@gmail.com> --- Created attachment 88330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88330&action=edit Bug 17005: Test for checked_in parameter Test plan: prove t/db_dependent/api/v1/checkouts.t Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #48 from Michal Denar <black23@gmail.com> --- Created attachment 88331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88331&action=edit Bug 17005: Add plugin parameters to /checkouts endpoint Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #49 from Michal Denar <black23@gmail.com> --- Please rebase on master. Thank you -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88329|0 |1 is obsolete| | --- Comment #50 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91166&action=edit Bug 17005: Add checked_in checkouts to REST API response This patch implements parameter 'checked_in' on checkouts endpoint to enable getting circulation history. Test plan: 1) Apply the patch and restart plack 2) Use your favorite REST API tester and play with /checkouts endpoint: - use it without checked_in parameter - use checked_in=1 for getting returned checkouts Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88330|0 |1 is obsolete| | --- Comment #51 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91167&action=edit Bug 17005: Test for checked_in parameter Test plan: prove t/db_dependent/api/v1/checkouts.t Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88331|0 |1 is obsolete| | --- Comment #52 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91168&action=edit Bug 17005: Add plugin parameters to /checkouts endpoint Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #53 from Josef Moravec <josef.moravec@gmail.com> --- Rebased on master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91166|0 |1 is obsolete| | --- Comment #54 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91235&action=edit Bug 17005: Add checked_in checkouts to REST API response This patch implements parameter 'checked_in' on checkouts endpoint to enable getting circulation history. Test plan: 1) Apply the patch and restart plack 2) Use your favorite REST API tester and play with /checkouts endpoint: - use it without checked_in parameter - use checked_in=1 for getting returned checkouts Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91167|0 |1 is obsolete| | --- Comment #55 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91236&action=edit Bug 17005: Test for checked_in parameter Test plan: prove t/db_dependent/api/v1/checkouts.t Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91168|0 |1 is obsolete| | --- Comment #56 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91237&action=edit Bug 17005: Add plugin parameters to /checkouts endpoint Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #57 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91238&action=edit Bug 17005: Fix bad rebase Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch still applies - pinging Tomas about this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91235|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91236|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91237|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91238|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #59 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 93757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93757&action=edit Bug 17005: Add checked_in checkouts to REST API response This patch implements parameter 'checked_in' on checkouts endpoint to enable getting circulation history. Test plan: 1) Apply the patch and restart plack 2) Use your favorite REST API tester and play with /checkouts endpoint: - use it without checked_in parameter - use checked_in=1 for getting returned checkouts Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #60 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 93758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93758&action=edit Bug 17005: Test for checked_in parameter Test plan: prove t/db_dependent/api/v1/checkouts.t Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #61 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 93759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93759&action=edit Bug 17005: Add plugin parameters to /checkouts endpoint Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #62 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 93760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93760&action=edit Bug 17005: Fix bad rebase Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API: add routes to |Extend /checkouts route to |list checkouts history |list circulation history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27544 [Bug 27544] Simplilfy /checkouts implementation -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org