[Bug 24244] New: Cannot create suggestion with branch set to 'Any'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Bug ID: 24244 Summary: Cannot create suggestion with branch set to 'Any' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org There is a foreign key constraint, we get an internal server error when trying to save branchcode 'Any' = '' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96284&action=edit Bug 24244: Send null instead of empty string if branch not set -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |nick@bywatersolutions.com |ommunity.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96284|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96293&action=edit Bug 24244: Add test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96294&action=edit Bug 24244: Send null instead of empty string if branch not set Fix NewSuggestion if branchcode is passed with an empty string. Error was "Broken FK constraint" Test plan: Create a new suggestion, select "any" for the library. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22907 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 [Bug 22907] Cannot add new suggestion with strict SQL modes turned on -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 [Bug 7047] Renewing serials note not visible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |joonas.kylmala@helsinki.fi --- Comment #4 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- After this change the purchase suggestion would not be shown in the list at </cgi-bin/koha/suggestion/suggestion.pl>. So I would like to see a patch that handles these any library suggestions before we merge this otherwise I think we are left with a even worse situation where we have patrons submitting suggestions successfully" but then the librarians never knowing about them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22368 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 [Bug 22368] Table suggestions lacks foreign key constraints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Joonas Kylmälä from comment #4)
After this change the purchase suggestion would not be shown in the list at </cgi-bin/koha/suggestion/suggestion.pl>. So I would like to see a patch that handles these any library suggestions before we merge this otherwise I think we are left with a even worse situation where we have patrons submitting suggestions successfully" but then the librarians never knowing about them.
This is a regression - in the past we could create these suggestions and they have never been shown by default. You should be able to see them by opening the Acquisition information filter and setting library to Any Making that more obvious is a separate bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It appears to fix the staff side, but we still got big trouble in the OPAC: - Activate anonymous suggestions for the OPAC - Place a suggestion while logged out - Boom! Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88 Leaving this bug right now as I think we could add the important OPAC (end users!) fix into this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #6)
It appears to fix the staff side, but we still got big trouble in the OPAC: - Activate anonymous suggestions for the OPAC - Place a suggestion while logged out - Boom!
Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88
It works for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #7)
(In reply to Katrin Fischer from comment #6)
It appears to fix the staff side, but we still got big trouble in the OPAC: - Activate anonymous suggestions for the OPAC - Place a suggestion while logged out - Boom!
Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88
It works for me.
Strange :( I can retest, but thought I had made sure yesterday to restart everything. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #8)
(In reply to Jonathan Druart from comment #7)
(In reply to Katrin Fischer from comment #6)
It appears to fix the staff side, but we still got big trouble in the OPAC: - Activate anonymous suggestions for the OPAC - Place a suggestion while logged out - Boom!
Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88
It works for me.
Strange :( I can retest, but thought I had made sure yesterday to restart everything.
I still see the error, double checked that I had the patches applied and 'restart_all' was done before testing. I think the problem is, that I hadn't set an Anonymous patron, it was still the default of 0. - Not sure if this is a bug we need to fix. Signing off now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96293|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96728&action=edit Bug 24244: Add test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96294|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96729&action=edit Bug 24244: Send null instead of empty string if branch not set Fix NewSuggestion if branchcode is passed with an empty string. Error was "Broken FK constraint" Test plan: Create a new suggestion, select "any" for the library. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
I still see the error, double checked that I had the patches applied and 'restart_all' was done before testing. I think the problem is, that I hadn't set an Anonymous patron, it was still the default of 0. - Not sure if this is a bug we need to fix. Signing off now.
... or if we want to, fix separately as the issue seems to be a different constraint? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24327 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #6)
It appears to fix the staff side, but we still got big trouble in the OPAC: - Activate anonymous suggestions for the OPAC - Place a suggestion while logged out - Boom!
Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88
Opened bug 24327. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- pushed to 19.11.x for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org