http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adrien.saurat@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2012-02-29 17:35:15 UTC --- Didn't we get rid of the \r on purpose some time back? Let me try to find the bug... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5586 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff CC| |koha@univ-lyon3.fr --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #5)

Shouldn't we adhere to the SIP2 specs? Or at least, if we do things differently add that as an option? yes we should adhere to the SIP2 specs. But it seems 3M don't respect his own standard in France, we have to deal with this problem.

We could define $EOL and set it either to CR or CR-LF, depending on a configuration otion, e.g. that's an option, right. My first request was to have someone testing the patch to see if it *break* SIP2 for others or not. I don't request a signoff to push the patch.

(In reply to comment #4)

I think Liz is right - we changed it on purpose in the past. Yes I know, but it break french 3M hardware :( We updated one of our libraries since then and had no problems - it seems the self checks of this vendor support both. I am not sure if this should be a configuration option? Perhaps there is a way to configure the 3M self check machines to work with the new line endings?

We have investigated the machine and couldn't found anything about that. Lyon3 was supposed to ask 3M, I just added them in the cc list of this bug Siwtching back to need signoff and, I repeat, I won't push this patch without community agreement, I just want some feedback for now. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #8 from Colin Campbell <colin.campbell@ptfs-europe.com> --- There are two problems one is the non flushing of output buffers which is done on CRLF and not if you just past \r. a second problem is that most clients are windows boxes and seem to lazily assume that everything is windows (or HTTP) and will send crlf. Although crlf is non what the standard dictates this will work for most clients (and if you use telnet you get crlf anyway!!). I've found one machine that it kills completely if you use crlf. I'm going to test a version of this patch but add the ability to override it and be strictly compliant in the SIPConfig which should mean that it shouldnt break any machine that is currently working. Longer term the code should separate the handling out of the sip data message and the transport (which Sip 3.0 really requires and sidesteps this issue) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #9)

This seems to also be related to bug 6620.

$CRLF is used in C4/SIP/SIPServer.pm in the telnet_transport... but not anywhere else.

Personally I think we should code for the standard as it's defined, not as it's implemented, but that's apt to make a lot of people running non-standard implementations very unhappy. If we can find a compromise that doesn't break SIP for one half of the world or the other, I'd be quite happy.

Perhaps an entry in SIPConfig.xml?

i agree with Ian's idea for a SIPConfig.xml option, any other opinions? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7937|0 |1 is obsolete| | Assignee|paul.poulain@biblibre.com |colin.campbell@ptfs-europe. | |com --- Comment #12 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 10031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10031&action=edit Revised Patch I was tempted to sign this off as I've had to implement my own version of Paul's patch on two or three sites. However I've abstracted it sightly using a constant for the message terminator and adding comments describing how to reset this. In the longer term we should extract this out to allow the parameter to be settable by the admin user. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #13)

We have a SIPConfig.xml file, could we put the terminator in there? If no one can sees a floor in that plan, I'll go ahead and do it now.

+1, that's the easiest & best option (even if, as the file is in gitted, it will require a patch, but that's not a big deal) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Have signed off the first patch, since this works and fixes the immediate problem. Working on a follow up to shift setting the line end character out of the .pm into the config file. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Actually, the config object is not passed through to the write_msg sub, so it would take quite a bit of a rewrite. So for now, people will need to change the variable in the C4/SIP/Sip.pm. This works well enough, so I think it should move on to QA. The followup would still be nice, but I don't think we should hold up pushing this fix until then. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Thatcher Rea <thatcher.rea@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thatcher.rea@bywatersolutio | |ns.com --- Comment #20 from Thatcher Rea <thatcher.rea@bywatersolutions.com> --- US Customers using Overdrive are experiencing problems with this patch - we can fix as per Chris' suggestion to modify C4/SIP/Sip.pm in order to resolve the problem manually. +1 for rewriting this patch in the future to be configurable. :T -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- OverDrive (http://www.overdrive.com/) is an eBook vendor. After upgrading to 3.8.3 our patrons lost the ability to log in to OverDrive using SIP. The problem was fixed by reverting this patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9531 -- You are receiving this mail because: You are watching all bug changes.