http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- I agree, it would be nice is there was a way for this preference to be split in to two. One for the staff and one for the OPAC - I'd add that it would be nice if this preference were a list of messages you could offer. So if you wanted to only allow holds and advanced notices to be options you could put 'hold|advanced|' or something like that in the preference. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #2 from Vitor Fernandes <vfernandes@keep.pt> --- Created attachment 14199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14199&action=edit Bug 9254: Problem with EnhancedMessagingPreferences First I don't know the right component to this bug. The problem is the following: - when enabling EnhancedMessagingPreferences, the staff client if able to set the messaging preferences for the patrons categories, and then for the patron (normally the messaging preferences are the same for everyone) - when enabling EnhancedMessagingPreferences, the patrons can set in the OPAC their messaging preferences, which can be against the library rules Solution: - enabling EnhancedMessagingPreferences, should allow the the staff client to set the patrons messaging preferences - enabling EnhancedMessagingPreferences, should't allow patrons to set their messaging preferences (the link doesn't appear in the usermenu.inc) - should be another preference to allow the patrons to set their messaging preferences. Test plan: - apply the patch - enable EnhancedMessagingPreferences, the messaging page should appear in OPAC - disable OPACEnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC - disable EnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC Sponsored-by: KEEP SOLUTIONS -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14199|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14244&action=edit [SIGNED-OFF] Bug 9254: Problem with EnhancedMessagingPreferences First I don't know the right component to this bug. The problem is the following: - when enabling EnhancedMessagingPreferences, the staff client if able to set the messaging preferences for the patrons categories, and then for the patron (normally the messaging preferences are the same for everyone) - when enabling EnhancedMessagingPreferences, the patrons can set in the OPAC their messaging preferences, which can be against the library rules Solution: - enabling EnhancedMessagingPreferences, should allow the the staff client to set the patrons messaging preferences - enabling EnhancedMessagingPreferences, should't allow patrons to set their messaging preferences (the link doesn't appear in the usermenu.inc) - should be another preference to allow the patrons to set their messaging preferences. Test plan: - apply the patch - enable EnhancedMessagingPreferences, the messaging page should appear in OPAC - disable OPACEnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC - disable EnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC Sponsored-by: KEEP SOLUTIONS Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14246&action=edit Bug 9254 - Problem with EnhancedMessagingPreferences - Followup - Rename pref to EnhancedMessagingPreferencesOPAC If the new pref is named EnhancedMessagingPreferencesOPAC, it will show up adjacent to EnhancedMessagingPreferences -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14244|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15010&action=edit [SIGNED-OFF] Bug 9254: Problem with EnhancedMessagingPreferences First I don't know the right component to this bug. The problem is the following: - when enabling EnhancedMessagingPreferences, the staff client if able to set the messaging preferences for the patrons categories, and then for the patron (normally the messaging preferences are the same for everyone) - when enabling EnhancedMessagingPreferences, the patrons can set in the OPAC their messaging preferences, which can be against the library rules Solution: - enabling EnhancedMessagingPreferences, should allow the the staff client to set the patrons messaging preferences - enabling EnhancedMessagingPreferences, should't allow patrons to set their messaging preferences (the link doesn't appear in the usermenu.inc) - should be another preference to allow the patrons to set their messaging preferences. Test plan: - apply the patch - enable EnhancedMessagingPreferences, the messaging page should appear in OPAC - disable OPACEnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC - disable EnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC Sponsored-by: KEEP SOLUTIONS Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Rebased on master (2013-02-01) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15010|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15764&action=edit Bug 9254: Problem with EnhancedMessagingPreferences First I don't know the right component to this bug. The problem is the following: - when enabling EnhancedMessagingPreferences, the staff client if able to set the messaging preferences for the patrons categories, and then for the patron (normally the messaging preferences are the same for everyone) - when enabling EnhancedMessagingPreferences, the patrons can set in the OPAC their messaging preferences, which can be against the library rules Solution: - enabling EnhancedMessagingPreferences, should allow the the staff client to set the patrons messaging preferences - enabling EnhancedMessagingPreferences, should't allow patrons to set their messaging preferences (the link doesn't appear in the usermenu.inc) - should be another preference to allow the patrons to set their messaging preferences. Test plan: - apply the patch - enable EnhancedMessagingPreferences, the messaging page should appear in OPAC - disable OPACEnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC - disable EnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC Sponsored-by: KEEP SOLUTIONS Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Rebased on master (2013-02-01) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to comment #8)

There is a typo in the first patch: 6380 A

Ouch! My mistake. Fixed -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux@biblibre.co | |m --- Comment #13 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- As described in Koha Manual, 1.12.12. EnhancedMessagingPreferences Default: Allow Asks: ___ patrons to choose which notices they receive and when they receive them. Values: Allow Don't allow Important This only applies to certain kinds of notices, overdue notices will be sent based on the library's rules, not the patron's choice. So this syspref is defined to allow patrons to choose the notifications they want to receive. What Victor describes as a problem is not one. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- A customer asked me the same request then I developed a patch and completely forgot this one. So I will provide a followup with what I needed some months ago :) But after a little reflexion, I don't know if it is relevant. I think it is not pleasant not to let the choice to the user. Are you sure it is legal not to let the user deactivate notifications? Switch to in discussion. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20332&action=edit Bug 9254: redirect to 404 if at least 1 pref is off And set the value of EnhancedMessagingPreferencesOPAC = EnhancedMessagingPreferences -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, the display as it currently is might be a bit confusing to patrons. Maybe we also need to think about how to "pretty" it up a bit. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #20 from Koha Team AMU <koha.aixmarseille@gmail.com> --- We wanted to test this patch but it doesn't apply on a sandbox : "Applying: Bug 9254: Problem with EnhancedMessagingPreferences\nUsing index info to reconstruct a base tree...\nFalling back to patching base and 3-way merge...\nAuto-merging C4/Auth.pm Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl\nFailed to merge in the changes.\nPatch failed at 0001 Bug 9254: Problem with EnhancedMessagingPreferences\nWhen you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort".\nBug 9254 - Problem with EnhancedMessagingPreferences" -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15764|0 |1 is obsolete| | --- Comment #21 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38122&action=edit Bug 9254: Problem with EnhancedMessagingPreferences First I don't know the right component to this bug. The problem is the following: - when enabling EnhancedMessagingPreferences, the staff client if able to set the messaging preferences for the patrons categories, and then for the patron (normally the messaging preferences are the same for everyone) - when enabling EnhancedMessagingPreferences, the patrons can set in the OPAC their messaging preferences, which can be against the library rules Solution: - enabling EnhancedMessagingPreferences, should allow the the staff client to set the patrons messaging preferences - enabling EnhancedMessagingPreferences, should't allow patrons to set their messaging preferences (the link doesn't appear in the usermenu.inc) - should be another preference to allow the patrons to set their messaging preferences. Test plan: - apply the patch - enable EnhancedMessagingPreferences, the messaging page should appear in OPAC - disable OPACEnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC - disable EnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC Sponsored-by: KEEP SOLUTIONS NOTE: Re-worked by Mark Tompsett, that's why I removed sign-offs. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20332|0 |1 is obsolete| | --- Comment #23 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38124&action=edit Bug 9254: redirect to 404 if at least 1 pref is off And set the default value of EnhancedMessagingPreferencesOPAC = EnhancedMessagingPreferences -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #25 from Marc Véron <veron@veron.ch> --- There is a typo in koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc line 81 Koha.Preferences('EnhancedMessagingPreferencesOPAC') should be: Koha.Preference('EnhancedMessagingPreferencesOPAC') (Preferences -> Preference) I tested after locally fixing the issue. IMO status 'In Discussion' could be removed. Regarding comment #19: '...display as it currently is might be a bit confusing to patrons...': Maybe there could be some explanation like in the tab 'your privacy'. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38124|0 |1 is obsolete| | --- Comment #27 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38514&action=edit Bug 9254: redirect to 404 if at least 1 pref is off And set the default value of EnhancedMessagingPreferencesOPAC = EnhancedMessagingPreferences -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38513|0 |1 is obsolete| | --- Comment #29 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38516&action=edit Bug 9254: Followup - Rename pref to EnhancedMessagingPreferencesOPAC If the new pref is named EnhancedMessagingPreferencesOPAC, it will show up adjacent to EnhancedMessagingPreferences Comment: Works as described. But the patch only hides the link, not disable the feature. If you refresh OPAC after unset EnhancedMessagingPreferencesOPAC, you can still change your messaging preferences. NOTE: Mark Tompsett removed sign off, since he completely reworked it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #31 from M. Tompsett <mtompset@hotmail.com> --- Leaving in discussion as per comments #17, #18, and #19. Which I raised in comment #24. Even though Marc V. suggested that 'In Discussion' was not required in his opinion in comment #25. These other attachments in between were because he pointed out a typo I believe I may have made in rescuing the patch. Apply the latest and follow any test plans given in comments #28, #29, and #30. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Problem with |New option to block patrons |EnhancedMessagingPreference |from changing messaging |s |preferences in OPAC -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 jvr <jvr@fct.unl.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jvr@fct.unl.pt --- Comment #33 from jvr <jvr@fct.unl.pt> --- Hello All, I have been playing around with Koha since version 2.xx. So, version 3.xx is better than 2.xx and this conversion (id=9254) started by Victor Fernandes 2012-12-10 15:18:28, 4 years ago, still with no solution because you don´t want to see the solution and we are all one tracked mind. The solution is not to amend or the change the existing code (Koha's programmers don´t have time for that, please note, I am not a Koha programmer), but to understand want Koha already has in its framework that no one uses because no one sees it in front of their eyes... I am talking about OPACUuserCSS property in Administration System Preferences. CSS is there to change the aspect of your OPAC, so why not use it ? Remember what your question is? Answer: You just want to hide something... If you want to hide an hiperlink in OPAC that use CSS to hide it with a value="display: none", and it is just what all you are waiting for 4 years. For example, to hide the message's hipelink use the following block code. #usermenu ul li a[href="/cgi-bin/koha/opac-messaging.pl"] { display: none; } Please open your minds for similar problems that can be resolved in the use of OPACUserCSS... Thank you and please don't ask the community to change Koha coding when it is working well, doing that will create another problem that needs to be taken care later... For more information goto https://bd2.fct.unl.pt/wiki_koha/#99-pt (sorry mainly in portuguese language) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #35 from M. Tompsett <mtompset@hotmail.com> --- (In reply to jvr from comment #34)

So, now we don´t want to hide the messaging hiperlink due to human rigth issues...

...

Then just hide the SUBMIT BUTTON. How? ANSWER: OPACUserCSS

No, that doesn't work. There exists a user somewhere, that knows how to unhide the things your CSS hides. It needs to physically not be there. CSS is great for situations which don't have further implications if someone decides to forcefully make it visible again or read page source. Plus by serving the page with the information required to shoot yourself legally, you have most likely violated some legal situation you are trying to avoid. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #37 from Marc Véron <veron@veron.ch> --- 3 option pref ++ -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure moderation is the right answer here. What will you do if you don't agree with the settings the user has changed? Will you contact them by email to tell them why their choice wasn't good or just deny the change without any explanation? Moderation is great for a lot of things, but I think for switches like that, it wouldn't work really well. Another suggestion would be to only allow changing settings for some, but not all notices/messages. But I feel like this should be separate from this bug and would be another enhancement. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12528 -- You are receiving this mail because: You are watching all bug changes.