http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |olli-antti.kivilahti@jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 23389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23389&action=edit Bug 11369 - Updating the jquery.cookie.js-plugin The current jquery.cookie-plugin crashes when trying to fetch all cookies using $.cookie(); Downloaded the newest plugin version and minified it. Now works as intended. Encountered an issue with the plugin now returning null when no cookies are found, and applied a fix in browser.js. ------------- - Test plan - ------------- Plugin is used in browser.js and batchMod.js so testing both --- browser.js --- In catalogue/search.pl look for any record. You should get a search cookie stored in your browsers cache with the following format: 4Xea40qp : {"offset":1,"query":"idx=kw&q=read","limit":"","sort":"","pagelen":20,"results":[1430,2253,2255,2256,2257,2258,2307,2326,2344,2595,2961,3588,3974,3995,4026,4405,4410,4412,4414,4435]} Select any record for detailed view. You should get a navigation panel on your left part of screen. You should be able to move to the previous and next record and return to results. --- batchMod.js --- Select a handful of barcodes to batch modify, then continue. The cookie affected stores the columns you want displayed. Try showing/hiding columns. When you make another batch modification attempt, your column selection persists via the showColumns-cookie. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Sponsored by Joensuu Regional Library -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23389|0 |1 is obsolete| | --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 25662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25662&action=edit Bug 11369 - Updating the jquery.cookie.js-plugin The current jquery.cookie-plugin crashes when trying to fetch all cookies using $.cookie(); Downloaded the newest plugin version and minified it. Now works as intended. Encountered an issue with the plugin now returning null when no cookies are found, and applied a fix in browser.js. ------------- - Test plan - ------------- Plugin is used in browser.js and batchMod.js so testing both Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23390|0 |1 is obsolete| | --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 25663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25663&action=edit Bug 11369 - Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. To replicate this issue, make multiple searches in catalogue/search.pl. 50+ Should be enough to cause the HTTP-request header to overgrow. One can verify this issue by observing the searchCookie growth in browser's stored cookies. ------------- - TEST PLAN - ------------- Keep making searches. One should never have more than 10 searchCookies. Browser might display only 9, because for some reason the newest js-generated cookie is not included in Firefox's cookies listing. ------------ - DRAWBACK - ------------ Removing these cookies disables the search cursor for traversing search results (next/previous) for the removed cookie. This maybe be problematic in some cases, (for ex when multiple search tabs need to be open and they need to be traversed) One easy solution is to grow the amount of stored searchCookies from 10 to 20, but 10 is chosen so there will be plenty of room for other cookies as well. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10404 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 --- Comment #9 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 25667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25667&action=edit Bug 11369 - Correct usage of me.searchid in browser.js In browser.js, at creation of browser, the searchid is transmited to JS object into me.searchid. To be consistant, me.searchid should always be use, never searchid alone. In browseRecords function, setting searchid as parameter is useless because it is defined in me.searchid. Test with test plan of Bug 10404 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 --- Comment #11 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Two new patches need signoff : Bug 11369 - Correct usage of me.searchid in browser.js Bug 11369 - General searchid in browser.js -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25730&action=edit Bug 11369 - Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. To replicate this issue, make multiple searches in catalogue/search.pl. 50+ Should be enough to cause the HTTP-request header to overgrow. One can verify this issue by observing the searchCookie growth in browser's stored cookies. ------------- - TEST PLAN - ------------- Keep making searches. One should never have more than 10 searchCookies. Browser might display only 9, because for some reason the newest js-generated cookie is not included in Firefox's cookies listing. ------------ - DRAWBACK - ------------ Removing these cookies disables the search cursor for traversing search results (next/previous) for the removed cookie. This maybe be problematic in some cases, (for ex when multiple search tabs need to be open and they need to be traversed) One easy solution is to grow the amount of stored searchCookies from 10 to 20, but 10 is chosen so there will be plenty of room for other cookies as well. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25732&action=edit Bug 11369 - General searchid in browser.js The search browser fearture uses nearly only the browser.js file. That is why I propose to move the searchid generation from search.pl to browser.js. We then use Date.getTime() to use current timestamp as searchid, prefixed by 'scs_' like before. Test by using test plan of main patch : Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this patch can cause some problems, when you still have an old cookie in your browser. I had this error showing when testing batch modifying items: Error: Syntax error, unrecognized expression: :nth-child ...{href:function(a){return a.getAttribute("href")},type:function(a){return a.getAt... After restarting the browser, it's no problem. ... just noting - no blocker. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26502&action=edit [PASSED QA] Bug 11369 - Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. To replicate this issue, make multiple searches in catalogue/search.pl. 50+ Should be enough to cause the HTTP-request header to overgrow. One can verify this issue by observing the searchCookie growth in browser's stored cookies. ------------- - TEST PLAN - ------------- Keep making searches. One should never have more than 10 searchCookies. Browser might display only 9, because for some reason the newest js-generated cookie is not included in Firefox's cookies listing. ------------ - DRAWBACK - ------------ Removing these cookies disables the search cursor for traversing search results (next/previous) for the removed cookie. This maybe be problematic in some cases, (for ex when multiple search tabs need to be open and they need to be traversed) One easy solution is to grow the amount of stored searchCookies from 10 to 20, but 10 is chosen so there will be plenty of room for other cookies as well. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26504&action=edit [PASSED QA] Bug 11369 - General searchid in browser.js The search browser feature uses nearly only the browser.js file. That is why I propose to move the searchid generation from search.pl to browser.js. We then use Date.getTime() to use current timestamp as searchid, prefixed by 'scs_' like before. Test by using test plan of main patch : Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. Tested the browse functionality in staff by using the different options (back to results, next, previous, etc) and the batch modifications for items. An old cookie can cause a Javascript error, but after restarting the browser/deleting cookies it all works correctly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25729|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25731|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works as described, at least if I haven't missed something. Like some of the other commenters I would feel a bit better about this if we were not losing history here at some point by limiting the number of cookies, but stored the data in another place - sessions or using the HTML5 feature. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #24 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 --- Comment #26 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #22)

This works as described, at least if I haven't missed something.

Like some of the other commenters I would feel a bit better about this if we were not losing history here at some point by limiting the number of cookies, but stored the data in another place - sessions or using the HTML5 feature.

I think using sessions is really the way to go. I'm going to backport this patch to our local Koha, but I still think it's less than ideal. I think the best way to do this is to keep using unique IDs for the search, and to store them and the relevant data in the active session in the database. In this way, we can still have multiple tabs open with unique searches and still use the record browser without the limits imposed by using cookies. At the moment, we store the OPAC record browser info in the active session in the database, but the limitation is that the key isn't unique (ie the key is "busc"). That means if you have multiple tabs open, the browser for all of them will return the results for the latest search... definitely not a good thing! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12295 --- Comment #27 from David Cook <dcook@prosentient.com.au> --- Adding reference to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 for anyone adding patches manually... -- You are receiving this mail because: You are watching all bug changes.